Repository navigation
spec(epic): record FIX-1816/FIX-1817 epic-row changes and the P2-wait decision (FIX-1815) - #2904
Conversation
…ecision Under ER-11, from the child specs the product owner approved on 2026-10-08 (FIX-1816 at #2900 964ecb6, FIX-1817 at #2899 163730d): L5 reshaped to addTask's waitForResponse; L6 dropped; L7's depth half holds at depth 1 with a fixed sweeper-fired timeout; ER-5 reads as an opt-in option; L9 adds answerTask and addTask.followUpOf. The product owner's call: if FIX-1794 P2 slips, ask waits with it, no stop-gap waker (ER-7). EVOLUTION rows, the box and path figures re-derived. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qmij1MasdpEs8jm9ZpDzNq
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
Second-look + architecture pass (spec-only PR, no code to refactor) Overall: the shape is right. It records approved child-spec outcomes against the epic rows (ER-11) and touches nothing else. Cross-file consistency holds: I grepped for stale
No code or architecture-deepening opportunities apply here; the one structural point is #3 (one home per fact). Items 1–2 are the ones I'd fix before merge. Generated by Claude Code |
L2's wait binding names the task row under the reshaped L5, not a request. EVOLUTION's FIX-1537 row records FIX-1816's approved call (ER-18): FIX-1537 closes as a duplicate of FIX-1816 and stays FIX-1312's child. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qmij1MasdpEs8jm9ZpDzNq
There was a problem hiding this comment.
Problem
Epic FIX-1815 merged on main (#2891) with a heavier Layer 1 story (awaitDispatch / resultOf, L6 lease parking, open-ended depth cap). Child specs (#2900, #2899) reshaped ask around addTask + waitForResponse, dropped L6, and fixed L7 — this PR records that delta. The question is whether the recording is as lean as the design it captures.
Verdict
Direction: approve. Folding ask into the existing task board (not a parallel request-wait API) is the simpler architecture and matches how orchestration already thinks (notices, park/resume, runOnce). Dropping L6 follows from depth-1-by-construction. The P2-slip decision (wait with P2, no stop-gap waker) is consistent with ER-7.
This PR’s shape: mostly right, a bit heavy. EVOLUTION rows + D5 table updates are the necessary amendment surface. Re-stating the same bullets in DECISIONS (“Recorded under ER-11…”), D3/D4 locks, PLAN, both SVGs, and epic DOCS draft increases drift risk — and we already have small inconsistencies (see inline).
Simpler approach (if you were doing it again)
- Epic first draft: Frame L5 as “task on asker’s board +
waitForResponse” from the spike, avoidingawaitDispatch/ L6 in #2891 entirely. - Amendment PR:
EVOLUTION.md+DECISIONS.mdD5/D3/D4/ER rows +PLAN.mdP2 gate; defer epicDOCS.mdquoted sections to FIX-1816/1817DOCS.md(ownership table already says children publish specifics). - Retention: Rename the child-spec log section so it doesn’t share the ER-11 label with the “no extra Layer 1” rule — or link only to
#recorded-under-er-11-from-the-child-specswithout saying “under ER-11” in prose.
Skipped (not blocking)
- Renumbering L6 away: keeping the ghost row is defensible for #2891 lineage; just gloss it wherever L-ranges appear.
- Sweeper-based 10–20m timeout: inherent tradeoff of D1 + periodic expiry; FIX-1816 owns the exact deadline wording.
No changeset needed (spec-only).
Sent by Cursor Automation: Review For Best Approach
Cross-spec pass, authorized by the product owner on 2026-10-08: - ER-22: an asked task gets no parkOnQuestion in v1 (coordinator call, overrulable by the product owner); FIX-1817 owns, FIX-1816 mirrors. Ownership figure gains its row. - ER-12: FIX-1817's L9 rows (S5 work entry, S6 session key, S7 capability) are a second agreed touch of FIX-1794 code; on S6, FIX-1817 lands after FIX-1816 P3. ER-15, ER-21, PLAN seams follow. - D5 L9: parkOnQuestion added; turnReentries counts question re-entries too. - Tool count: one set of task tools per turn; the check is "waitForResponse adds no tool". FIX-1786 ER-32's literal "eight" is raised as an amendment request. Review 5463206853: the ER-11 section is renamed "D5 amendments from the child specs"; ER-4's check is a stalled ask's timeout and cancel; DOCS has one timeout sentence pointing at FIX-1816's DOCS; the set row describes ask as a task on the asker's own board. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qmij1MasdpEs8jm9ZpDzNq
|
from: fsd-pm CI note on 1444530: This isn't caused by this PR. It only touches Generated by Claude Code |


Follow-up to #2891, the merged epic spec for FIX-1815, and to #2893, which recorded Q1 and Q3. This PR records decisions made on 2026-10-08. On that date the product owner approved the two child specs in session: FIX-1816 at #2900 (head
964ecb69) and FIX-1817 at #2899 (head163730d8). Under ER-11 the epic has to record the changes those specs make to its rows. This PR records them as decided, and the results of the cross-spec pass below, and changes nothing else. It edits onlyspecs/epics/FIX-1815/.What it records
addTaskwith awaitForResponseoption. There is no new tool, no new core export, and noawaitDispatchorresultOf:waitForResponseadds no tool. The product owner's reason: ask and add both add a task.answerTaskas a new task tool, andaddTask.followUpOf, which binds a follow-up to the root task's session. A follow-up is refused while that session still has an unfinished task. A person's message keeps the shippedallowconcurrency.Cross-spec pass, authorized by the product owner on 2026-10-08: (1) an asked task gets no
parkOnQuestionin v1, new ER-22, owned by FIX-1817 and mirrored by FIX-1816, a coordinator call the product owner can overrule; (2) ER-12 gains a second agreed exception, FIX-1817's L9 changes to FIX-1794's S5 to S7, landing after FIX-1816 P3 where both touch S6, withfix-1786-pmtold before FIX-1794 P2 merges (ER-21); (3) D5 L9 addsparkOnQuestionandturnReentriesnow counts question re-entries; (4) the tool check is one set per turn, "waitForResponseadds no tool", with FIX-1786's ER-32 literal "eight" raised as an amendment request. Recorded in DECISIONS → Decided in the cross-spec pass.What changed
DOCS.md; it says asks don't nest and an asked worker can't question back.end-state.svgdropsawaitDispatchand the parked asker row, and addswaitForResponse,answerTaskand "no nested asks".path.svgchanges ask's build lane to L1–L3, L5, L7, L8.end-state.svgnamesparkOnQuestionbesideanswerTask;ownership.svggains ER-22's row.Checks: the spec-figures verify block passes. Both changed figures were rendered in light and dark and checked by eye.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Qmij1MasdpEs8jm9ZpDzNq
Generated by Claude Code