Repository navigation
POC: one overlap harness for the abort checks (FIX-1665) - #2982
Closed
cursor[bot] wants to merge 2 commits into
Closed
cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
…g keeps the other's controller (FIX-1665) The abort registry held one controller per request id, so when the stale sweep and /continue left two runs of one request live in a process, the second registration replaced the first, and whichever run ended first deregistered the survivor's controller. The survivor could then no longer be aborted. The registry now holds one controller per live run under the id: an abort fires all of them, and a run deregisters only its own controller. `deregisterAbortController` keeps its id-only form (removes all). Also adds a repro of the cross-process half of FIX-1665 (a run in another process finalizes and deregisters the id while this one still writes), marked it.fails: fencing it needs a store-contract decision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DME8pzA4e4Rc7fRLGsYavW
POC only. The new overlap file copied the parked-run harness that request-finalization-overlap already had. Co-authored-by: Jake Hoffner <jhoffner@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Collaborator
|
Closing this POC because #2971 already includes it. Its test changes match #2971's exactly, and #2971 adds the Generated by Claude Code |
Collaborator
|
Closing unmerged: its test-harness subtraction was folded into #2971 (6dff11e), which has merged. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does not merge. It is a smaller shape of #2971. Fold the subtraction there, then close this unmerged after that PR lands.
Subtracted
request-attempt-overlap.test.tscopied the parked-run harness already inrequest-finalization-overlap.test.ts(the two gates, the secondonFinishedhold, interrupt, then/continue). One harness now drives the retention checks and the abort checks. Net −102 lines (156 insertions, 258 deletions). The abort registry,runAction, and the host are unchanged.The parked handler also returns when its signal aborts, so an aborted run can finish. The retention checks still release on the gate.
What still passes
pnpm --filter @flow-state-dev/engine exec vitest run --root . test/request-finalization-overlap.test.ts test/abort.test.ts7 overlap tests, including the
it.failscross-process repro, and 108 abort tests. All passed.Same assertions: after one run ends, abort still reaches the other; one abort reaches both live runs; the cross-process finalize case stays red.