Repository navigation
Conversation
Report-only. No source changes. Do not merge. Co-authored-by: Jake Hoffner <jhoffner@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b935357ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | **Why it matters** | If a process registers a wide org collection and never registers the owner-private declaration, in-run `list()` can see other users’ `~owner` rows. HTTP routes still fence. Correctly configured Workforce apps are fine. | | ||
| | **Evidence** | `specs/issues/FIX-1549/poc/unarmed-leak/unarmed-leak.poc.test.ts`. Startup overlap refusal when owner-private **is** registered. | | ||
| | **Follow-up** | Document in `apps/docs/docs/resources/collections.md`. Optional engine hardening is a spec, not a drive-by. | |
There was a problem hiding this comment.
Remove the already-fixed unarmed-registry leak
The reviewed commit already prevents this exact scenario: fenceOwnerKeys in packages/engine/src/context/resource-registry.ts filters list() results through ownerKeyAdmits, which rejects owner-marked keys for collections without an owner rule regardless of whether the registry registered an owner-private declaration. packages/engine/test/owner-private-fence.test.ts explicitly covers a process that never declared one. The retained FIX-1549 POC describes the earlier drafted implementation, not the shipped key fence. Mark this gap as resolved rather than recommending documentation and hardening for a leak the current implementation blocks.
Useful? React with 👍 / 👎.
Three weeks of very high merge rate left a few security leftovers, a half-wired ask path, and several mechanisms that should be one family. This PR is the review only.
What this does
Adds
docs/internal/tech-debt-review-2026-10.md. No source, test, or docs-site changes. Do not merge.What's asked of you
Read the top 10 and decide which follow-ups to file or pick up. Nothing here is yours to merge.
Parts worth reviewing closely
The top 10 and the two engine-route leftovers (
get_sessionwithoutloadCheckedSession;resolveTemplateRawstill unfiltered after FIX-1568). Vocabulary findings are inventory for FIX-1796, not a second rename.Links
Internal report only. No Linear issue. No changeset (private/internal docs).
How to review this
This is a report PR. Judge whether the findings are evidenced and the follow-ups are one-PR sized. Do not review it as a product change.
Everything else
Window: 2026-09-18 → 2026-10-10. 577 merged GitHub PRs. Review HEAD: origin/main at 3ba7177. Method: git log, merged-PR search, Linear status, file reads, 30 prioritized review-thread scans.
In-progress work (FIX-1816, FIX-1796, FIX-1802, FIX-1792) is listed as remaining surface, not forgotten work.
Unconfirmed: Docker Hub rate-limit incidents (image is unpinned; Actions logs were not pulled), external consumers of leftover shims, and any deferred nit outside the 30-PR sample.