Skip to content

FIX-1887: the epic's closure check (not ready: four findings open) - #3374

Closed
jhoffner wants to merge 11 commits into
mainfrom
claude/project-thread-3uxjhz
Closed

jhoffner wants to merge 11 commits into
mainfrom
claude/project-thread-3uxjhz

Conversation

@jhoffner

@jhoffner jhoffner commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Requested by Jake · project thread

What's asked of you

Nothing yet. This stays a draft until FIX-1992 to FIX-1995 merge and a fresh run of the whole plan passes on one main commit. Then this body becomes the QA report.

Before: each child of FIX-1870 had its own check, but nothing had run them all on one commit, or checked that the epic changed nothing in those checks but names.

After: goals/dispatching-work/runs-on-dispatch-task-alone/ runs every hand-off and coordinator check together with their controls. It also adds two scripts. One judges each of the epic's merges for name-only changes, and the other sweeps the public surface for retired tools.

What changed

First run (26121fd + 37f8058)

The hand-off and coordinator checks pass, and every control fails as documented. Four findings, each a child of FIX-1870 that blocks FIX-1887:

Release notes: none. Only goals/ and spec files change.

🤖 Generated with Claude Code

https://claude.ai/code/session_01X74reh7rJTWyXWHvTVz7y8


Generated by Claude Code


Note

Medium Risk
Mostly goals/spec QA, but it changes how coordinator and mailbox goal checks read evidence (post rows vs ledger) and how delegated-post controls are wired in test flows, so grading semantics could drift if fence lines are wrong.

Overview
Adds FIX-1887 epic closure QA under goals/dispatching-work/runs-on-dispatch-task-alone/: a goal.md + run.mts runner that composes existing hand-off/coordinator goals and two moved scripts (rename-map.mjs, surface-sweep.mjs), with a large fence-lines.json listing allowed non–name-only hunks in coordinator checks.

rename-map.mjs is extended per D3/D4: judge each pinned child merge (M^1..M) instead of one epic-wide diff; optional --fix to combine a follow-up PR’s files with the child merge; one-sided fence entries and outcome-evidence lines; stricter handling for ask→wait in type keys and regex literals; more --control plants.

Several goal checks and controls are updated to match shipped FIX-1872/FIX-1875 behavior: delivery ledger reads → board post rows (postDeliveries / toPostDeliveries), addTasks("dispatchTask"|"addTask", …) split, internal → task delegated-post entry with quiet flows that answer then fail the turn (no-landing, kitchen-sink landing control), plus docs/comments in those goals.

Specs (FIX-1887 decisions CR-10/CR-14, PLAN/SPEC) document D3/D4; POC paths get stub READMEs pointing at the new goal folder.

Reviewed by Cursor Bugbot for commit e08ec8e. Configure here.

Adds goals/dispatching-work/runs-on-dispatch-task-alone/: goal.md, a thin
runner shaped like FIX-1820's (one clean commit, each check its own
process, controls graded on their exact red set), and the spec's two POC
scripts moved in unchanged in rule: rename-map.mjs with fence-lines.json
(FIX-1872's ledger reads turned row reads, and #3168's addTasks(tool)
fence), and surface-sweep.mjs. The POC folders keep a pointer.

Also fixes two stale spec lines: the epic plan's FIX-1872 row took two
PRs, and FIX-1872's V11 notes that another user's session answers
session-not-found as shipped.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X74reh7rJTWyXWHvTVz7y8
The runner listed no co-failures for no-self-choice and turn-after-route,
though their check's verdict log documents them, and stripped only one
provider key for the keyless kitchen-sink check. Both are the runner's
data, not its rule. goal.md logs the run on 37f8058.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X74reh7rJTWyXWHvTVz7y8
…(D3)

The single diff from f1ae352 can't pass: fixes from outside the epic
(FIX-1933, FIX-1979, FIX-1981, FIX-1925, FIX-1967) changed the checks
after the spec was written. The runner now pins the epic's child PRs,
finds each merge on main and judges its diff from its first parent.

rename-map.mjs admits a name as a type-literal or object key and a name
ending a regex literal, with controls proving a non-name change in each
still fails. Amends DECISIONS (D3), CR-10, SPEC's How we verify and
PLAN P1.m.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X74reh7rJTWyXWHvTVz7y8
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X74reh7rJTWyXWHvTVz7y8
@vercel

vercel Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
flow-state-dev-docs Ignored Ignored Oct 14, 2026 7:32pm UTC
flow-state-dev-kitchen-sink Ignored Ignored Oct 14, 2026 7:32pm UTC
flow-state-dev-ui Ignored Ignored Preview Oct 14, 2026 7:32pm UTC

Request Review

@linear-code

linear-code Bot commented Oct 14, 2026

Copy link
Copy Markdown

FIX-1887

@cursor

cursor Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 938fe2c5-edd9-40b4-bd58-f89d4ba206dd)

Appends FIX-1995's 98 fence lines for #3232 and accepts a null side: a
line added or removed with no partner, matched as a whole line. Two
outcome lines in hands-each-post-to-its-delegates move their evidence
from the removed ledger to post rows, listed as outcome-evidence and
printed apart. Controls prove an unlisted pure addition or removal still
fails and a one-sided entry admits nothing in a regression check.
D4 recorded; CR-14 amended.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X74reh7rJTWyXWHvTVz7y8
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X74reh7rJTWyXWHvTVz7y8
Appends FIX-1994's six fence lines for #3180 (the leg c dispatch step as a
one-sided entry). Adds --fix to the rename-map script: the files a
finding's fix PR touches are judged from the merge's first parent to the
fix's merge, every other file at the merge alone. run.mts pins #3180 with
#3377 and pairs them once #3377 is on main; until then #3180 is judged
alone. D4 and CR-10 amended.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X74reh7rJTWyXWHvTVz7y8
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X74reh7rJTWyXWHvTVz7y8
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X74reh7rJTWyXWHvTVz7y8
@cursor

cursor Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 03b356b1-030f-4c53-9b7c-c97257e442d7)

#3375 taught the POC sweep to read the vocabulary sweep's WR-25b keep
entries; the merge carried that onto the moved file, so its import now
climbs two levels, not five. At HEAD the sweep passes (0 live lines);
at 9e0cabe it fails at 165; --control exits 2.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X74reh7rJTWyXWHvTVz7y8
@cursor

cursor Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: e4d9d0b8-7d54-4481-b25e-9b1adfac2ac4)

@jhoffner jhoffner closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants