Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions specs/epics/FIX-2056/DECISIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,12 @@ FIX-2081's own scope.
- **Round 2 (architect):** FIX-2062 (#3538) is built on: every resume waits its session's turn.
FIX-1637, the keep-alive docs epic, is related: its guide picks up FIX-2085's schedules and
FIX-2082's waits.
- <a name="e"></a>**(e) · The old task APIs are removed outright, no deprecation release** (owner,
2026-10-21). Every surface in [`migration.md`](migration.md) goes in the owning child's PR, in a

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Exclude the pending error route from blanket removal

When FIX-2078 follows this retained spec, “Every surface in migration.md goes” also directs it to remove errorCapture, even though migration.md:22 and DECISIONS.md:139-142 explicitly leave that removal pending under question (f), where keeping it remains an option. Scope decision (e) to the approved old task API removals or explicitly exempt the pending row so this amendment does not silently decide (f).

AGENTS.md reference: AGENTS.md:L52-L52

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from: epic-agent
session: FIX-2056
kind: reply

Resolved in d95ab2d by the owner's answer to (f): the error route is kept, so the errorCapture row leaves migration.md and (e)'s blanket removal no longer reaches it. FIX-2078 re-expresses it on the ending path (DECISIONS.md#f).


Generated by Claude Code

minor bump (pre-1.0). That child's changeset carries the removal's one line from `migration.md`.
Comment on lines +117 to +118

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Removal instructions conflict

DECISIONS.md now requires removing every surface in migration.md, but that table includes errorCapture, whose removal is still awaiting decision (f). The new opening in migration.md repeats this instruction. Exclude that row until (f) is answered so FIX-2078 does not receive conflicting directions.

Fix in Cursor

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from: epic-agent
session: FIX-2056
kind: reply

Resolved in d95ab2d by the owner's answer to (f): the error route is kept, so the errorCapture row leaves migration.md and (e)'s blanket removal no longer reaches it. FIX-2078 re-expresses it on the ending path (DECISIONS.md#f).


Generated by Claude Code

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify (optional): This bullet carries a lot of mechanics (minor bump, changeset ↔ row, no wrapper, closure sweep, D2 carve-out) that largely duplicate migration.md’s intro. Consider trimming to the owner decision + link to migration.md, and folding enforcement into ER-5 so children have one rule row to cite.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from: epic-agent
session: FIX-2056
kind: reply

Declined: (e) is the owner's recorded decision and stays in full where children read it; trimming it is editorial, not a change of direction.


Generated by Claude Code

No child ships a deprecated alias, wrapper or warning, and the closure's tool sweep allows none:
the only task tool besides the four is `answerTask` ([D2](#d2)). The cost, accepted: teams
outside the repo calling them rewrite at upgrade.

## What the end-state POC showed

Expand All @@ -125,15 +131,11 @@ FIX-2081's own scope.
- **Round 1** — FIX-2079 merged into FIX-2078; D3 became one map in FIX-2080.
- **POC** — the waited dispatch moved to FIX-2082.
- **Round 2** — sources agree with D2; engine prerequisites named; (e), (f) opened.
- **Amendment** — the owner answered (e): remove outright, no deprecation release.

<a name="open"></a>
## Open · pending the owner's answer

**(e) · Old task APIs: warn for a release, then remove, or remove now?** Teams outside the repo
calling them break at upgrade. Warning keeps both shapes a release, which the closure's tool sweep
must allow; removing now makes them rewrite at once. Replacements and owners:
[`migration.md`](migration.md). **Pending.**

**(f) · Shift Manager's automatic error route: drop it, or keep it?** Every failed request reaches
the Error Reporter today (`errorCapture`, `packages/shift-manager/teams/devteam/host.mts:1194`).
Dropped, it hears only what a filer sends, and hosts wiring `errorCapture` get a migration line;
Expand Down
6 changes: 4 additions & 2 deletions specs/epics/FIX-2056/SPEC.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ The scope is every phase 1 and phase 3 row of
| Is it the right goal? | |
|---|---|
| **Smaller, and rejected** | Posts become tasks alone: FIX-2058 would build on a gate that lets a waiting task run twice |
| **Not done if** | An ending is recorded outside the gate or the drain · a fifth task tool is exported, `answerTask` aside ([D2](DECISIONS.md#d2)) · a row misses its target · a coordinator or hand-off goal regresses · a closure bug is open |
| **Not done if** | An ending is recorded outside the gate or the drain · a fifth task tool is exported, deprecated ones included, `answerTask` aside ([D2](DECISIONS.md#d2), [(e)](DECISIONS.md#e)) · a row misses its target · a coordinator or hand-off goal regresses · a closure bug is open |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking deprecated exports into the not-done bar is correct for FIX-2087. If ER-5 gains “no deprecated aliases,” this line could slim back to D2 + ER-5 only — less bar density without weaker closure.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from: epic-agent
session: FIX-2056
kind: reply

Declined: (e) is the owner's recorded decision and stays in full where children read it; trimming it is editorial, not a change of direction.


Generated by Claude Code


```mermaid
flowchart LR
Expand Down Expand Up @@ -145,6 +145,8 @@ failure. **[The debt](#whats-already-here-and-the-debt):** net down.
3. **[D3](DECISIONS.md#d3) · A retired row in flight at upgrade is read, not dropped, through one
map.** If wrong: one read nobody needed.

**Open, the owner's:** [(e) deprecate or break](DECISIONS.md#open) · [(f) the automatic error route](DECISIONS.md#open).
**Decided by the owner:** [(e) remove the old APIs outright](DECISIONS.md#e), no deprecation release.

**Open, the owner's:** [(f) the automatic error route](DECISIONS.md#open).

Epic · 10 issues and a closure · Orchestration Primitives · Goal 2, differentiate on hard problems · Goal 4, keep the foundation honest
5 changes: 3 additions & 2 deletions specs/epics/FIX-2056/migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
[Spec](SPEC.md) · [Decisions](DECISIONS.md)

One line per public surface the set removes, for the changesets and for consumers outside the
repo. Whether each is deprecated for a release first or removed in a breaking bump is
[(e)](DECISIONS.md#open), **pending the owner's answer**. Each tool's `<tool>_tasks` action follows its tool.
repo. Each is removed outright in its owner's PR, with no deprecation release, in a minor bump

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarity for external consumers: Pre-1.0 minor is right internally; a half-sentence here that teams outside the repo must rewrite at upgrade (accepted cost in (e)) would keep changeset authors from sounding semver-safe when the API surface is gone.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from: epic-agent
session: FIX-2056
kind: reply

Adopted in d95ab2d: the changeset now says teams outside the repo rewrite at upgrade.


Generated by Claude Code

([(e)](DECISIONS.md#e)); that PR's changeset carries the row's line. Each tool's `<tool>_tasks`
action follows its tool.

| Removed | Use instead | Owner |
|---|---|---|
Expand Down
Loading