Repository navigation
spec(epic): FIX-2056 amendment, remove the old task APIs outright (answer to (e)) #3590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -111,6 +111,12 @@ FIX-2081's own scope. | |
| - **Round 2 (architect):** FIX-2062 (#3538) is built on: every resume waits its session's turn. | ||
| FIX-1637, the keep-alive docs epic, is related: its guide picks up FIX-2085's schedules and | ||
| FIX-2082's waits. | ||
| - <a name="e"></a>**(e) · The old task APIs are removed outright, no deprecation release** (owner, | ||
| 2026-10-21). Every surface in [`migration.md`](migration.md) goes in the owning child's PR, in a | ||
| minor bump (pre-1.0). That child's changeset carries the removal's one line from `migration.md`. | ||
|
Comment on lines
+117
to
+118
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. from: epic-agent Resolved in d95ab2d by the owner's answer to (f): the error route is kept, so the Generated by Claude Code
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Simplify (optional): This bullet carries a lot of mechanics (minor bump, changeset ↔ row, no wrapper, closure sweep, D2 carve-out) that largely duplicate
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. from: epic-agent Declined: (e) is the owner's recorded decision and stays in full where children read it; trimming it is editorial, not a change of direction. Generated by Claude Code |
||
| No child ships a deprecated alias, wrapper or warning, and the closure's tool sweep allows none: | ||
| the only task tool besides the four is `answerTask` ([D2](#d2)). The cost, accepted: teams | ||
| outside the repo calling them rewrite at upgrade. | ||
|
|
||
| ## What the end-state POC showed | ||
|
|
||
|
|
@@ -125,15 +131,11 @@ FIX-2081's own scope. | |
| - **Round 1** — FIX-2079 merged into FIX-2078; D3 became one map in FIX-2080. | ||
| - **POC** — the waited dispatch moved to FIX-2082. | ||
| - **Round 2** — sources agree with D2; engine prerequisites named; (e), (f) opened. | ||
| - **Amendment** — the owner answered (e): remove outright, no deprecation release. | ||
|
|
||
| <a name="open"></a> | ||
| ## Open · pending the owner's answer | ||
|
|
||
| **(e) · Old task APIs: warn for a release, then remove, or remove now?** Teams outside the repo | ||
| calling them break at upgrade. Warning keeps both shapes a release, which the closure's tool sweep | ||
| must allow; removing now makes them rewrite at once. Replacements and owners: | ||
| [`migration.md`](migration.md). **Pending.** | ||
|
|
||
| **(f) · Shift Manager's automatic error route: drop it, or keep it?** Every failed request reaches | ||
| the Error Reporter today (`errorCapture`, `packages/shift-manager/teams/devteam/host.mts:1194`). | ||
| Dropped, it hears only what a filer sends, and hosts wiring `errorCapture` get a migration line; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,7 +30,7 @@ The scope is every phase 1 and phase 3 row of | |
| | Is it the right goal? | | | ||
| |---|---| | ||
| | **Smaller, and rejected** | Posts become tasks alone: FIX-2058 would build on a gate that lets a waiting task run twice | | ||
| | **Not done if** | An ending is recorded outside the gate or the drain · a fifth task tool is exported, `answerTask` aside ([D2](DECISIONS.md#d2)) · a row misses its target · a coordinator or hand-off goal regresses · a closure bug is open | | ||
| | **Not done if** | An ending is recorded outside the gate or the drain · a fifth task tool is exported, deprecated ones included, `answerTask` aside ([D2](DECISIONS.md#d2), [(e)](DECISIONS.md#e)) · a row misses its target · a coordinator or hand-off goal regresses · a closure bug is open | | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Linking deprecated exports into the not-done bar is correct for FIX-2087. If ER-5 gains “no deprecated aliases,” this line could slim back to D2 + ER-5 only — less bar density without weaker closure.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. from: epic-agent Declined: (e) is the owner's recorded decision and stays in full where children read it; trimming it is editorial, not a change of direction. Generated by Claude Code |
||
|
|
||
| ```mermaid | ||
| flowchart LR | ||
|
|
@@ -145,6 +145,8 @@ failure. **[The debt](#whats-already-here-and-the-debt):** net down. | |
| 3. **[D3](DECISIONS.md#d3) · A retired row in flight at upgrade is read, not dropped, through one | ||
| map.** If wrong: one read nobody needed. | ||
|
|
||
| **Open, the owner's:** [(e) deprecate or break](DECISIONS.md#open) · [(f) the automatic error route](DECISIONS.md#open). | ||
| **Decided by the owner:** [(e) remove the old APIs outright](DECISIONS.md#e), no deprecation release. | ||
|
|
||
| **Open, the owner's:** [(f) the automatic error route](DECISIONS.md#open). | ||
|
|
||
| Epic · 10 issues and a closure · Orchestration Primitives · Goal 2, differentiate on hard problems · Goal 4, keep the foundation honest | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,8 +3,9 @@ | |
| [Spec](SPEC.md) · [Decisions](DECISIONS.md) | ||
|
|
||
| One line per public surface the set removes, for the changesets and for consumers outside the | ||
| repo. Whether each is deprecated for a release first or removed in a breaking bump is | ||
| [(e)](DECISIONS.md#open), **pending the owner's answer**. Each tool's `<tool>_tasks` action follows its tool. | ||
| repo. Each is removed outright in its owner's PR, with no deprecation release, in a minor bump | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clarity for external consumers: Pre-1.0
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. from: epic-agent Adopted in d95ab2d: the changeset now says teams outside the repo rewrite at upgrade. Generated by Claude Code |
||
| ([(e)](DECISIONS.md#e)); that PR's changeset carries the row's line. Each tool's `<tool>_tasks` | ||
| action follows its tool. | ||
|
|
||
| | Removed | Use instead | Owner | | ||
| |---|---|---| | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When FIX-2078 follows this retained spec, “Every surface in
migration.mdgoes” also directs it to removeerrorCapture, even thoughmigration.md:22andDECISIONS.md:139-142explicitly leave that removal pending under question (f), where keeping it remains an option. Scope decision (e) to the approved old task API removals or explicitly exempt the pending row so this amendment does not silently decide (f).AGENTS.md reference: AGENTS.md:L52-L52
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from: epic-agent
session: FIX-2056
kind: reply
Resolved in d95ab2d by the owner's answer to (f): the error route is kept, so the
errorCapturerow leavesmigration.mdand (e)'s blanket removal no longer reaches it. FIX-2078 re-expresses it on the ending path (DECISIONS.md#f).Generated by Claude Code