Repository navigation
FIX-2080: a task runs by the settings it was filed with, and nothing waits on work that will never finish #3624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+4,417
−1,328
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
c8600eb
wip(FIX-2080): substrate slice
claude d2cdf84
wip(FIX-2080): orchestration tests
claude d62aea0
wip(FIX-2080): workforce
claude 356cc00
wip(FIX-2080): direct filed cascade
claude 2302506
wip(FIX-2080): ui and goals vocabulary
claude 2f0d88a
wip(FIX-2080): filing-settings goal
claude 28eb765
wip(FIX-2080): docs, goal verdicts, filing-settings goal.md
claude 7052203
wip(FIX-2080): changeset; devtool finds a board's tools without block…
claude 0d5a235
fix(FIX-2080): retired-term wording in tests; unexport module-interna…
claude 98db332
fix(FIX-2080): break the cascade/ledger import cycle by handing the l…
claude 76a057a
Merge origin/main into fix/FIX-2080 (FIX-2076 lands first)
claude d414662
fix(FIX-2080): release a retried legacy blocked row; keep its reason …
claude af73d28
fix(FIX-2080): a dependency that ends while its dependent is written …
claude 966252f
fix(FIX-2080): a late filed-cascade payment cancels only the ending's…
claude 1cdb63a
test(FIX-2080): a refused Workforce batch files none of its rows
claude 5578448
fix(FIX-2080): a batch row filed already ended counts as a dead depen…
claude fef68ec
fix(FIX-2080): refuse a Workforce batch that names one id twice
claude 767e85f
fix(FIX-2080): a piece added after its task ended is cancelled by its…
claude 898357f
fix(FIX-2080): a touch cancels dependents an ending in another proces…
claude 92406a5
fix(FIX-2080): updateTask releases last, after a reassignment lands
claude a7e4e37
fix(FIX-2080): refuse a follow-up of a task that never ran; rename it…
claude 397137a
fix(FIX-2080): a replan naming a failed task skips it instead of fail…
claude e02bfb8
docs(FIX-2080): a held task keeps a board from finishing; batch and t…
claude efe6a5c
test(FIX-2080): reword a test goal off a retired term
claude 1602e62
fix(FIX-2080): keep the dead-dependents sweep module-internal
claude d4e601d
test(FIX-2080): the filing-settings goal files its pieces for a helper
claude b194f86
fix(FIX-2080): pay a drain's owed cascades after its workers, not bef…
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(FIX-2080): refuse a Workforce batch that names one id twice
The dependency ordering kept only the first row for a repeated id, so the batch reported success with a row missing. assertUniqueIds refuses it as duplicate_task_id before anything is written (Codex review, board.ts). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VaN4uTiYqiabCbsFLWM52A
- Loading branch information
commit fef68ecc8ef516489211ddd9ffb34fa4b609f976
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should-fix:
assertFollowUpHasRunmisses a follow-up whose root is in the same batch, so the earlier finding 7 still reproduces throughaddTasks.checkFilinglooks the root up withref.get. A root filed in the same batch isn't stored yet, so the lookup returnsundefined, and the rule leaves it "to the caller's own lookup". By the time the follow-up is added, the root has already been added, so that lookup passes too.Evidence: I ran the new
follow_up_of_unruntest withh.controls.batch.add("s1")and anassigneeon the follow-up. Nothing was refused. The root stayedheld, and "Polish the brief" ran tocompletedin the root's session. Filed one at a time, the same rows are refused. The changeset says the rule holds "from the tools and from the board's ref alike".Fix: give the batch check a lookup that sees the batch rows. A follow-up whose root is a row in the same batch has never run, so refuse it. For example, pass
(id) => batchById.get(id) ?? ref.get(id)and let therun === undefinedtest refuse it.Generated by Claude Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #3639 (FIX-2096), commit b234f0d. The guarded batch passes its own rows to
assertFollowUpHasRun(filedWith.get(id) ?? ref.get(id)), so a root filed in the same batch reads as never run and the follow-up is refusedfollow_up_of_unrun. The whole batch files nothing. New test inconversation-board-filing-settings.test.ts, which failed on main.Generated by Claude Code