Repository navigation
spec(epic): same pieces, different apps (FIX-2152) - #3783
Conversation
Epic spec for two labs built only from the workforce package plus config, React UI and small flows: a Claude Code-style app (session and threads modes) and a Grok Bot-style app. Sets the bar, the inventory, the gap rule, and the closure FIX-2156. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwpAiiUuq5pNkkmtNnc5pv
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
@codex review Please look closely at three things. First, whether D2 (a settled notice taken before the filer's next model call, through the existing steer path) is consistent with the one-ending rule and one request per session in Generated by Claude Code |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture pass (spec-level, direction only)I read Fold in before merge1. D2 reuses the steer path less directly than the spec says.
2. The ER-5 adapter is a fourth kind of code, so ER-1's check fails on its own design.
3. ER-1's bar can be gamed, and ER-3 pushes UI duplication into the labs.
4. Question whether the closure should block on FIX-2157.
Noted, no change needed
Architecture opportunity (only because the gap issues will touch it)The mid-turn gap (D2) and the existing steer take both read "things that arrived while the request ran" before a model call. When the gap is built, it should extend that shared take rather than add a parallel one. That keeps one place that answers "what has this running request not yet seen". I'm not recommending a refactor now. The gap issue's spec should say which side owns the shared helper. Generated by Claude Code |
D3 becomes one optional conversation key (FIX-2158), not workstreams; D2 takes the architect's conditions (FIX-2159); FIX-2154 is blocked by FIX-2070; D2 and D3 are concept amendments for the owner's sign-off. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwpAiiUuq5pNkkmtNnc5pv
There was a problem hiding this comment.
Simplify review (spec-only)
This epic is directionally sound and already matches the lean workforce epic shape (FIX-2056 / FIX-2058): SPEC + DECISIONS, ER table in decisions, coordination seams, no PLAN/BR split. The extra surface vs peers is mostly D4 (fixtures-first UI) and three decision SVGs — justified if Jake’s 2026-10-23 sequencing call stays non-negotiable.
What I would not simplify away (the spec already argues these well):
- Two labs — Kitchen Sink / Shift Manager are the wrong product story; the GTM/evaluation table needs two familiar shells plus honest per-app inventories (ER-3 “no shared code” is painful but coherent with that goal).
- D2 mid-turn settled notices — reusing
prepareStep/ steer-context is the right package seam; building a third concurrency model would be worse. - Threads mode (FIX-2157) — if Claude Code parity requires session + threads, a second leg is fair; folding it only helps process (fewer epic children), not product proof.
Where complexity crept in (worth trimming in a follow-up amend, not a rewrite)
- Same fork, many surfaces — D2, ER-6, the mid-turn gap row, Open §3, and leg-a control failure all describe one behavior. Child gap specs can own mechanics; the epic could keep D2 + one acceptance line and drop ER-6’s duplicate “deferred notice turn” prose (or make ER-6 a one-line pointer to D2).
- D1 + “each lab’s spec may add more” — logically unbounded epic growth. D1 already has the “epic-sized gap” escape hatch; consider adding an explicit cap at direction approval: script-blocking children filed in one batch per lab when that lab’s spec merges (everything else → project link only). That preserves D1 without surprise scope.
- D4 × ER-3 — two isolated adapters/fixture sets while FIX-2056/2058/2070 names move is the highest delivery risk, not a wrong call. Mitigations that don’t violate ER-3: FIX-2153 spec documents adapter layout FIX-2154 copies; shared test-only harness for anti-game waits (event-driven, not sleep loops); optional FIX-2056-style POC on settled-notice +
prepareStepbefore wiring PRs. - Open vs decided — D3/ER-7 and FIX-2154 message view (Open §4) are still architect-pending while UI starts under D4. Fine for layout mocks; adapter functions that encode D3 semantics should wait until mailbox #46 is folded, or the epic should say fixtures for those gaps are stub UI only until then.
- Figures — decision tree (mermaid) + d1/d2/d4 SVGs + ownership SVG largely restate the D tables. If spec-figures policy allows, one diagram (
end-stateor ownership) plus prose tables would cut maintenance; not blocking.
Skipped (larger product/process forks — only if you reopen the brief)
- Package epic (D2 + D3) then lab-only epic — clearer merge order, splits narrative.
- Defer threads to post-closure — drops leg c from the 14-step bar.
- UI after refactors (reject D4) — contradicts approved sequencing.
Verdict
Approve for direction: two labs, two known package gaps, inventory discipline, and closure on real-model scripts are the right bar for “same pieces, different apps.” Address the duplication and D1 batching nits when child specs land; resolve Open items before wiring adapters that bet on D3/message-view semantics.
No changeset needed (spec only).
Sent by Cursor Automation: Review For Best Approach
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d86ce462b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…FIX-2152) D3 needs no model change: a lab session is an ordinary session of the worker, and FIX-2158 only lists them. Session-to-session messaging goes to FIX-2160, outside the epic (rule 21). ER-1 gets path rules and caps; FIX-2058 is marked planned; D2 names the transferred notice transaction; D1 batches gaps at each lab's spec merge. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwpAiiUuq5pNkkmtNnc5pv
|
@codex review Second round, on 7483234. Please check that ER-1's path rules and caps can actually be checked, and that D2's transferred take/handle/ack keeps each ending heard exactly once. Generated by Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7483234fe8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex round 2: a take in a task-backed session would skip that task's own ending work in the queued onTaskSettled. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwpAiiUuq5pNkkmtNnc5pv
|
@codex review Round 3, on a070af5. The only change is in D2: a notice is taken only by a conversation request in a session that no task backs. Please check that this closes the double-handling and skipping you found, and doesn't open a new path. Generated by Claude Code |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwpAiiUuq5pNkkmtNnc5pv
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |


Requested by Jake · project thread
Goal: two apps copy the core layout and interaction of Claude Code and Grok Bot. Each way of working passes one scripted session with a real model. App code is only configuration, React UI and a few small flows. All other needs are gaps in the package.
The closure issue FIX-2156 proves it on one
maincommit. Its control turns off the mid-turn notice, and step 4 of leg a must then fail. Why this goal and not a smaller one: SPEC.md.Each lab adds only its layout, its worker files and a few small flows. A need goes to the package, not into the lab.
Why now. The one task primitive (FIX-2056) is on
mainexcept its closure, and worker messaging (FIX-1989) is merged. Jake approved the specs, the UI design and the front ends on 2026-10-23. Only the wiring waits for the refactors.The set (as of 2026-10-23, live state in Linear):
fsd-architect checked the gaps and the worker-talk view against
main(answer, D3 correction). Session-to-session messaging, which the correction proposed, is filed outside this epic as FIX-2160: no script needs it, and it conflicts with rule 21 (a message never addresses a raw session).Each rule has one owner. FIX-2153 owns the lab rules because it goes first.
Sign off
The goal, at that size: three scripts, 14 steps, with a real model, and an inventory with no other row. If wrong: the labs look correct on fixtures and prove nothing about the package.
The set's debt: up, by two private labs and two package entries. The labs are the evidence. Each entry is a gap that the next app gets for nothing. If wrong: two labs that nobody maintains.
A gap that blocks a lab's script is built in this epic · D1
It comes down to whether the epic can finish on its own work. Gaps join in one batch when each lab's spec merges; a later one needs your sign-off. If wrong: the epic grows by package work that another epic should own.
A background result reaches the main session during its turn · D2
It comes down to working the way Claude Code does. It amends rule 7 of the coordination concept: an ending's notice gets a third destination. If wrong: step 4 of the session-mode script changes, and the lab works differently from the app it copies.
Front ends are built now, on fixtures behind one adapter · D4
It comes down to finishing the UI first. If wrong: part of the UI is done again when a shape changes.
Decided as engineering, no sign-off: D3, a lab session is an ordinary session of the worker. Nothing enforces one conversation per worker; the derived session stays the default conversation, and FIX-2158 only lists the others.
Open: nothing beyond the sign-off. A merge of this PR approves the rule 7 amendment (D2).
Reviewers · look here
DECISIONS.md, Who owns what): do the path rules and caps catch glue, and is the manual gate the right home for the rest?SPEC.md · DECISIONS.md · FIX-2152 · handle agent-mailbox#46
How to review this
This is an epic-spec: the shared objective and cross-cutting decisions for a set of
issues, in a retained document set. It is not any one issue's implementation design, and it
is not a schedule.
In scope to challenge:
SPEC.md— is this body of work worth doing, and is thegoal the real need at full size, or a smaller one the set could meet while the need stays
unmet? Would the closure issue's check fail if the goal were not met?
That question can only be asked here.
SPEC.md— something the set overlaps and doesn't name, or adds anddoesn't list.
DECISIONS.md— shared surface, naming, sequencing, contracts.DECISIONS.md→ Who owns what with no owner, or two.Out of scope — owned by the individual issue specs:
poc/show shape and scoping, not shippable implementation. Directional evidence, experimental
isolation and absence of secrets/generated dependencies remain in scope.
Feedback in the second list is routed to the issue it concerns as an implementer note, not
folded in here.
Required repository checks, approvals and review-thread policy still govern merge.
Optional comments are triaged, not a reason to grind to zero or restart the design review.
🤖 Generated with Claude Code
https://claude.ai/code/session_01KwpAiiUuq5pNkkmtNnc5pv