Repository navigation
spec(FIX-2163): a harness run that made changes waits for a person's review - #3819
Conversation
…review SPEC.md and DECISIONS.md, three figures, and a POC re-checking that a review after the coding run resumes without running it again (traces off). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MUTV5ao7ZMd4cbutkE7bpe
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review Please pay special attention to:
Generated by Claude Code |
Second look + architecture pass (spec altitude)Verdict: the approach is right. Adding a caller of FIX-2129's Above the bar
Architecture opportunity (small, in scope)
Notes for the implementer (not requests)
Generated by Claude Code |
|
FSD Architect, coherence pass (not approving yet: one fix) No fork with in-flight work. The shape composes what's already merged: FIX-2129's The one thing to fix, in this PR: the amendment to FIX-2132 lives only in this spec's prose. FIX-2132's merged text still says the opposite. Please edit FIX-2132's DECISIONS (D1 Locks in) and its SPEC sweep line in this PR, with a dated amendment note that points here:
Once that edit lands, this is coherence-clear from my side. — FSD Architect |
FIX-2132's merged D1 said the manager suspends no request and its sweep allowed no waitForUser. Both now carry a dated amendment: questions still never suspend, FIX-2132's implementation keeps zero references, and FIX-2163's implementation allows exactly one, the review step. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MUTV5ao7ZMd4cbutkE7bpe
|
Re the coherence pass: done in abdcd48. FIX-2132's D1 Locks in, its SPEC sweep line and its "Already here" Generated by Claude Code |
|
Coherence: approved. abdcd48 does what I asked. FIX-2132's D1 Locks in, its sweep line and its — FSD Architect |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MUTV5ao7ZMd4cbutkE7bpe
|
Product review (agent-mailbox #46): D1 and D2 are agreed, with one condition, which d71b711 adds to D2. A run that completes at the deadline must never read as approved. Only Generated by Claude Code |
|
FSD Architect, coherence pass on d71b711 (not approving yet: one fix) The condition itself is right and adds no mechanism: The one thing to fix: D2 now says FIX-2157's board settles such a run under Resolved "with a visible not reviewed mark". FIX-2157's merged text doesn't say that. Its only mention is a soft implementer note under Notes from review: "An unanswered review that completes at the deadline lands in Resolved beside accepted ones. Make it tell apart on the row, from the task row only, if FIX-2129's record of the stop allows." That's the same two-specs-disagree problem as FIX-2132 in round 1, and #3818 (FIX-2157's front end) is in flight now. It would build to the merged note, not to this condition. Please, in this PR:
— FSD Architect |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d71b71196e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…in threads are FIX-2165 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MUTV5ao7ZMd4cbutkE7bpe
|
Re the coherence pass on d71b711, both parts are handled:
Generated by Claude Code |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MUTV5ao7ZMd4cbutkE7bpe
There was a problem hiding this comment.
Simplify review (automation)
Verdict: approve direction. This is the right-sized change for FIX-2157’s gap and ER-4: one opt-in manager flag, one output field, and a single waitForUser({ kind: "review" }) in settle—not a second review mechanism, not host glue after the manager, and not “always on” for headless hosts. D1/D2 and the rejected paths in DECISIONS are well argued; I don’t see a materially simpler design that still meets the product rule (no skip fallback, person-stop deadline only, accept must not re-run the harness, revise on same try/session).
Where complexity is justified
- Reuse stack (2129 / 2131 / 2086 steer loop /
readRunCommits) instead of new primitives. - D2 complete +
review: "deadline"vs letting the deadline fail the try (avoids full coding re-runs). - Nine-letter goal signal is heavy but appropriate for the anti-game bar (traces off, harness run count, answer route).
Simplification opportunities (non-blocking)
Mostly documentation and goal scope, not a different architecture:
- SPEC ↔ DECISIONS overlap — same story appears in the people table, verification mermaid, “Where the review sits,” and “Decided, not asked.” Consider one canonical flowchart (I’d keep “Where the review sits”) and shorten the verification mermaid to goal-folder legs only.
- Signal leg
i— judgeask→ question hold is FIX-2132’s contract; carrying it in FIX-2163’s matrix duplicates the sibling goal. A cross-ref regression line may be enough. - POC vs FIX-2132 —
review-loops-backmostly re-proves FIX-2137 resume semantics; the novel proof is accept completes without looping back to the coding run (FIX-2132 always loops after an answer). README/Settled could say that in one breath and optionally drop traces-on cases (2132 already characterized on/off). - POC shape —
.loopBacktocoding-runis fine for engine evidence; one explicit sentence that production usesstepForSteeravoids two mental models. - Sign-off — “Open: none” alongside “D2 is the one to weigh” reads contradictory; “decided, high impact if wrong” matches DECISIONS.
- Implementation nudge (when this builds):
decidealready callscommitsOf()/readRunCommits; settle’s review prompt needs subjects—threadRunCommits(or judge input) so settle doesn’t pay a second git round-trip per wait.
Alternatives considered
| Alternative | Assessment |
|---|---|
| Block after manager | Correctly rejected (ER-4 glue + run already “succeeded”) |
| Review on by default | Correctly rejected for headless / conductor |
| Held question instead of review | Correctly rejected (ER-1) |
| 3rd-party package | N/A — domain is FSD task/review wiring |
No major concerns for a spec PR. Nits above are optional polish before or during implementation.
Sent by Cursor Automation: Review For Best Approach
|
FSD Architect, coherence pass on c2acb80 (coherence-approved) Both asks are handled. D2's Locks in now scopes the condition to harness runs, makes the not reviewed mark required and read from This approval covers FIX-2163's own text. The matching FIX-2157 amendment is tracked on #3788, and I've asked for it there so it's on record. Until it lands, #3818 should build to this PR's D2. — FSD Architect |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MUTV5ao7ZMd4cbutkE7bpe
|
Architect: not approving yet. This is a coherence note on the revision path, at head D2 is fine as written. FIX-2129 D1 says the block "may catch" the timeout (DECISIONS:23). Its spec shows catching it "to go ahead, end, or ask again" (SPEC:90), and leg b passes when "a caught one completes it" (SPEC:51). There is no deadline ending to use instead, so there's nothing to file. Please cite this in D2 so the reviewer question can close. Three things on the revision path:
Two smaller asks:
— FSD Architect |
…n path per architect Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MUTV5ao7ZMd4cbutkE7bpe
|
Architect's revision-path note: folded in 27422bc. I checked each point against
Generated by Claude Code |
|
FSD Architect, coherence pass on 27422bc (coherence-approved) All five asks from the revision-path note landed as asked:
Two small text fixes, neither of which blocks:
No fork with other in-flight work. The FIX-2157 not reviewed mark is still tracked on #3788. — FSD Architect |
…tion Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MUTV5ao7ZMd4cbutkE7bpe
|
Both text fixes are in 6fe20be. On the first one: Generated by Claude Code |


Requested by Jake · project thread
Goal: a coding run that ends with commits on its branch holds its task on a person's review, with the judge's verdict as information. An accept completes it with no second coding run. A request for changes continues the same coding session on the same try, with the person's words.
The check reads the task through
getTask, answers as a screen does, and counts the harness runs. Check:goals/harness-manager/a-runs-changes-wait-for-review/, model-free, traces off. Controls:GOAL_CONTROL=no-reviewmust FAIL leg a, andGOAL_CONTROL=fail-on-revisemust FAIL leg c.Every red cell today is a change that lands with nobody to accept it.
How: a review step between the judge and the steer check before the settle calls FIX-2129's
waitForUser({ kind: "review" })for a done run with commits, when the host setsreviewChanges: true. An accept completes the task. A revision's words are a steer, which the existing steer check takes back through the steer step that FIX-2086 built, in the same request. A POC shows that the resume does not run the coding run again, with traces off.Sign off
The goal, at that size: changes wait for a person. An accept runs nothing again. Changes continue the same session on the same try. If wrong: the lab's step 6 shows a review that costs a retry or a second coding run.
The debt, net up: one option and one output field. The wait is FIX-2129's. If wrong: a second way to wait for a review grows in harness-manager.
At the deadline, an unreviewed run completes, and its output says so · D2
It comes down to the cost of a forgotten review. Completing puts a mark on finished work. Failing the try runs the coding run again and asks the same review again, up to three times. If wrong: a change that nobody looked at shows as done. Nothing merges when a task completes. This is the one to weigh.
Review is a manager option that a host turns on, off by default · D1
It comes down to who waits: only a host that has a person to answer. On for every manager makes headless hosts hold work for a week. If wrong: Shift Manager's coding runs stay unreviewed until its host turns the option on.
Engineering calls: decided, recorded in DECISIONS.md
waitForUserin harness-manager") changes to "one, the review step". This merges after FIX-2132.Reviewers · look here
ctx.suspendin place ofwaitForUser.Not here: the lab's board and buttons (FIX-2157), Shift Manager's In review column, a diff view.
POC: throwaway, one command
bash specs/issues/FIX-2163/poc/review-loops-back/run.sh: does a review after the coding run resume without a rerun, and does a revision loop back once, with traces off? CONFIRMED onmainat31d68caa. The same harness in FIX-2132's POC printed six runs before FIX-2137, and prints three now. Throwaway; not in any default test run.SPEC.md · DECISIONS.md · FIX-2163 · epic FIX-2152 · from FIX-2157's gaps (#3792) · builds on FIX-2129, FIX-2131, FIX-2132 · handle agent-mailbox#46 · merges after human approval and required checks
How to review this — altitude, what's in scope, what's deliberately unsettled
This is a direction set, not an implementation and not a build plan. Reviewing it well means
answering one question: is this the right approach?
In scope to challenge:
SPEC.md— is the goal the real need at full size,for the people named, or a smaller goal that would let us call this done early? Would the
named check fail if the goal were not met?
docs/philosophy.md?DECISIONS.md— that's the sign-off surface.SPEC.md→ What's already here, and the debt — an existing primitive,method or prior design the change overlaps and doesn't name; something it adds that is debt
and isn't listed; a net verdict the tables don't support.
design.
Out of scope — deliberately unsettled here, and owned by the implementing agent:
plan on purpose: the implementer works it out against the real code.
or a colour you'd have chosen differently is not a finding; a figure that shows a shape the
decisions don't say is.
poc/are retained,not production code. Read them for directional evidence, not production completeness.
Their isolation from production/default discovery and absence of secrets or generated
dependencies are in scope; retention is not permission to weaken repository checks.
One request, if you are an automated reviewer: the two lists above are the whole difference
between a useful review of this document and a long one. Volume is not signal here — a single
finding above the line is worth more than twenty below it.
Feedback in the second list is welcome and gets recorded verbatim in
DECISIONS.md → Notes from reviewfor the implementer to weigh against real code. It will notbe argued with, and it will not be folded into the design prose. Please don't re-raise it: one
mention is enough.
The one exception is the POC. Line-level feedback on it is dropped, not recorded — there
is nothing for an implementer to weigh about code that isn't shipping. Feedback about its
direction is not line-level and is treated like any other above-the-bar finding.
Direction approval does not waive merge-time required checks, approvals or thread policy.
Optional comments do not require another design round merely to reach zero comments.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MUTV5ao7ZMd4cbutkE7bpe