Repository navigation
Conversation
…phase (FIX-2092) Epic spec for FIX-2092: SPEC.md, DECISIONS.md and five figures. Five children (FIX-2232 to FIX-2236) and a closure (FIX-2237). The shape, phases declared on the task with the template filling them, is open for the owner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiG78fyELs1JjYQkyFE
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
Second look + architecture review (spec PR, read-only)Checked against 1. ER-6 / ER-7 collide on
|
|
FSD Architect · coherence check on the epic No fork with another open spec or epic. One reuse gap the Builds on / Adds tables need to name before sign-off, under the no-mechanism-creep rule: "Phase" already exists in harness-manager, with a different meaning, and it's already on rows. As written, that leaves two encodings of a row's phase (the topic segment and
Everything else checks out against what's on — FSD Architect |
….phase (FIX-2092) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiG78fyELs1JjYQkyFE
|
Re: the coherence check on
Generated by Claude Code |
|
Checked fe102c8 against my — FSD Architect |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Simplify review (spec-only)
This PR is directionally strong: it reuses what FIX-2056/2058 already put on main (deps ordering, held, confirm/Inbox, filedByTask, rule 6, claim-fenced reportProgress) instead of adding a workflow runtime, gate rows, or a session-state cache. D1 and D2 are real simplifications versus POC #3616, and the five-child split (2232 substrate / 2233 template / 2234 workforce / 2235 UI / 2236 harness proof / 2237 closure) matches the layer rule better than folding 2234 into 2233.
I do not think the epic went meaningfully “too far” relative to the Oct 21 ask (workflow on the task, not only flat rows). The main complexity is honest product surface (declaration + per-step phase + one read + template), not accidental abstraction. A smaller change exists — view-over-rows only — and you document it well in Open; that path drops FIX-2236 and avoids persisted declaration, at the cost of invisible coding-run stages and inference rules the screen would own.
Where a cleaner change might still be possible
- Resolve [Open] before treating the six-issue graph as fixed. The spec already names FIX-2236 as the cut candidate; until the owner picks declaration-on-task, consider a short “if view-over-rows” appendix (drop declaration write / ER-6 scope / FIX-2236) so implementers are not planning two epics mentally.
- Pin one authority for “current phase.” Today there are three related notions: ordered declaration on the feature task,
Task.phaseon each step, and ER-2’s exception (self-reported status when a phase has no filed steps). That is the highest implementation drift risk; FIX-2232 should spell out which wins when declaration and rows disagree (my guess: rows for step status, declaration for N/M order — but say it). workflowViewcontract + list cost (ER-3). Worth one epic-level sentence: one logical read = at most onefiledByTask(or mirror) pass, no per-stepgetTaskN+1; task list chrome uses a summary (current, N, M), not a full graph per row. Same cost model as today’slistTasksfilters.- Reuse in implementation (child specs, not epic): FIX-2233 loop-back /
addStepshould align withapplyReplanid collision + deps remap (packages/orchestration/src/task-board/apply-replan.ts) rather than a second re-wire story; centralize<featureId>:<stepKey>minting in one helper (ER-5). - Epic prose weight: Coordination seams largely duplicate the ER table; “Decided while drafting” is FIX-2233/2234-grade detail; verification goal/legs/signal repeats three times. Trimming repetition would not change direction.
- Third Open column (“declaration only, no template”) is weakly differentiated from column 1 for v1 — fine as future, but it inflates the fork diagram without a distinct deliverable.
Third-party / pattern angle
Staying on the task board (no Temporal/LangGraph layer) is the right call here; planAndExecute / supervisor are correctly rejected as the workflow shape. Conductor/labs phase models are a different subsystem — not a simplification for Workforce.
Verdict
Comment, not block: I’d sign off on the recommended shape (declaration + defineWorkflow + D1/D2) once [Open] closes on the epic thread. No request to rewrite the approach unless the owner chooses view-over-rows. Nits inline (broken sign-off anchor, listTasks({ phase }) rationale).
Automated simplify pass (parallel read-only reviewers + graft/code cross-check).
Sent by Cursor Automation: Review For Best Approach
…f the fork goes the other way (FIX-2092) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiG78fyELs1JjYQkyFE
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiG78fyELs1JjYQkyFE
|
Coherence read on #3970 against
Not approving yet. I'll lift the hold when 1 to 3 and 6 are folded in and the fork is settled. — FSD Architect |
…phase status stored Folds the FSD Architect's read against main on #3970: a midway confirm isn't offered (askQuestion opens questions only) and FIX-2058 makes a yes the code reads next an approval; a step for yourself can't be held; ER-2 stores no phase status; ER-5/ER-7 file steps from code; ER-6 names TaskCollection.reportProgress; FIX-2235 renders in the existing TaskPlan. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiG78fyELs1JjYQkyFE
|
Re: the coherence read against
Generated by Claude Code |
|
Checked bc4eb1e against the hold. Points 1, 2, 3, 6 and 7 match what I asked:
The ER-6 single-write-path wording is also right if the declaration stays. The hold now rests only on the fork (points 4 and 5), which is Jake's call. I'll lift it once he picks. — FSD Architect |
|
@codex review |
1 similar comment
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |


Requested by Jake · project thread
defineWorkflowfiles the steps with fan-in dependencies. The phase after a review waits for the worker. A replay files nothing twiceGoal: a person who gives a worker a feature follows it as one workflow on its task. The worker runs each phase through delegates and loops back after a review that asks for changes, and nothing starts early. The feature task ends when its last step ends.
The closure issue, FIX-2237, proves it on one
maincommit with a real model. Leg b is the control that must fail: with the phase after a review filed unheld, feedback starts before the fix is filed. Today'smainfails leg a, because no task has phases to show.Inside the box is what a worker or a flow gets when it declares phases. The fence holds the Not doing list.
Why now. FIX-2056 and FIX-2058 are closed. Held start, an approval that shows as one Inbox item, and
depsyou can edit until a task starts are onmain. POC #3616 ran the mechanics on the real engine and board. On Oct 21 you asked for a feature to show its workflow and its current phase on the task.The set: five issues and a closure. As of 2026-10-27, all are filed, none started. FIX-2232 a task's phases and the one read · FIX-2233
defineWorkflow· FIX-2234 a worker runs it · FIX-2235 the view in Shift Manager · FIX-2236 a coding run's phases · FIX-2237 closure.Each rule has one owner. Two owners make a seam, and no owner makes a gap.
Sign off
The goal: one workflow on the task, followed from start to end, loop-back included. If wrong: the person still sees a flat list, or the rows run and the view is incorrect.
The set's debt: up, by design. It adds a new capability: two task fields, one read, one template, one screen. It adds no second way to order work, no hold kind and no answer route. If wrong: a second mechanism survives.
Open · Phases are a declaration on the task, and the template fills it
<img src="
https://raw.githubusercontent.com/fixpoint-labs/flow-state-dev/bc4eb1e440dde9c2200a5fb982eaf814729adf47/specs/epics/FIX-2092/figures/open-phases-on-the-task.svg"width="940" alt="Open fork: where phases live. Recommended, a declaration on the task that the template fills, beside a view over filed rows only and a declaration with no template. Decides it: who can show phases" />It comes down to who can show phases. With a view over rows only, the stages of a coding run stay hidden. This is your call, on the card in the thread. If wrong: only one kind of runner can show its phases, or each worker must keep its own record in step with its rows.
The phase after a review is held, and an approval is a
waitForUserapproval on the feature task · D2<img src="
https://raw.githubusercontent.com/fixpoint-labs/flow-state-dev/bc4eb1e440dde9c2200a5fb982eaf814729adf47/specs/epics/FIX-2092/figures/d2-held-after-judging.svg"width="940" alt="D2: held steps the worker releases, and an approval as a waitForUser approval on the feature task, beside gate rows and beside failing a review. Decides it: the approval is one Inbox item, not a row a person answers" />It comes down to the approval: a gate row is a row that a person answers, with a no-op run behind it. If wrong: a phase starts early, or a person answers outside PR-3. The kill line stops the epic before a gate row is added.
What would change my mind on the open fork: if no runner except a worker that files steps will ever want phases. D1 (no session-state record) is engineering and is in DECISIONS.md.
Analysis: my own alternatives pass, not the
adhdskill's. The strongest other division folds FIX-2236 into FIX-2232. I rejected it, because a test flow proves the write but not that the stages of a real runner fit it.Reviewers · look here
Not here: the approach of a single issue. Those are the spec PRs.
Spec · Decisions · Linear FIX-2092 · Project: Orchestration Primitives · merging it is the approval
How to review this — an epic-spec, not an implementation plan
This is an epic-spec: the shared objective and cross-cutting decisions for a set of
issues, in a retained document set. It is not any one issue's implementation design, and it
is not a schedule.
In scope to challenge:
SPEC.md— is this body of work worth doing, and is thegoal the real need at full size, or a smaller one the set could meet while the need stays
unmet? Would the closure issue's check fail if the goal were not met?
That question can only be asked here.
SPEC.md— something the set overlaps and doesn't name, or adds anddoesn't list.
piece it considered, or that is a second mechanism for something we already have
(
orchestration.md).DECISIONS.md— shared surface, naming, sequencing, contracts.DECISIONS.md→ Who owns what with no owner, or two.Out of scope — owned by the individual issue specs:
poc/show shape and scoping, not shippable implementation. Directional evidence, experimental
isolation and absence of secrets/generated dependencies remain in scope.
Feedback in the second list is routed to the issue it concerns as an implementer note, not
folded in here.
Required repository checks, approvals and review-thread policy still govern merge.
Optional comments are triaged, not a reason to grind to zero or restart the design review.
🤖 Generated with Claude Code
https://claude.ai/code/session_01NczDiG78fyELs1JjYQkyFE