Repository navigation
Add CI workflow for type checking and testing - #4
Merged
Merged
Conversation
jhoffner
commented
Feb 27, 2026
Collaborator
- Created a new GitHub Actions workflow in ci.yml to automate type checking and testing on pull requests and pushes to the main branch.
- Configured the workflow to use Node.js version 22 and pnpm for package management.
- Included steps for checking out the code, installing dependencies, type checking, and running tests.
- Created a new GitHub Actions workflow in ci.yml to automate type checking and testing on pull requests and pushes to the main branch. - Configured the workflow to use Node.js version 22 and pnpm for package management. - Included steps for checking out the code, installing dependencies, type checking, and running tests.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Added a new step in the GitHub Actions workflow to build packages using pnpm before type checking. - This enhancement ensures that the packages are built and ready for type checking during the CI process.
- Added "zod": "^3.25.76" to devDependencies in package.json to support validation in development. - This addition enhances the development environment for testing and type checking.
- Included zod version 3.25.76 in the devDependencies section of pnpm-lock.yaml. - This addition aligns with the recent updates to enhance the development environment for validation and type checking.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
6 of 7 tasks
This was referenced Jun 25, 2026
This was referenced Jul 8, 2026
jhoffner
pushed a commit
that referenced
this pull request
Jul 14, 2026
… (owner-confirmed) Owner chose clean break over migration. Replace the lazy per-scope migration (§4.6) with a cheap first-access legacy detector that throws a clear "legacy layout, will not read — move aside or delete" error instead of silently mis-serving old flat files (satisfies BP-030's "reject removed keys loudly"). This deletes the entire migration bug-class the review surfaced: durable marker, stage-before-unlink, per-scope lock, case/Unicode fold aliasing, empty-segment/leading-dot quarantine, notes/notes.md clobber. Also: document Windows reserved device basenames (con/aux/nul/com*/lpt*) as a new-write key constraint (§11 #4); a one-time migration tool is a documented follow-up (§8) if ever needed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WdNcANsuBvoc3iw6JXNKyX
jhoffner
pushed a commit
that referenced
this pull request
Jul 14, 2026
…-guard scan; document denylist carve-out Address re-review of 5acdfe7: - §3.1 wrongly claimed the shared conformance suite covers files/src/utils.ts; verified it does not. Corrected, and §5 now requires ADDING that dotted-key case to the suite. - Read-then-set gap: writing the marker is now a `set` responsibility — every set ensures the marker (idempotent, wx) before its data file, even if an earlier read cached the "fresh" scan; so no process/restart ever sees a data file without a marker and misreads a fresh store as legacy. - The whole-subtree legacy scan lstat-guards and skips symlinked dirs (same rule as get/set/delete/collectRecords) — a vault symlink can't make the scan escape the store. - Denylist minimized (.DS_Store/Thumbs.db/.gitignore/.gitkeep + .git/.obsidian/ .svn/.hg dirs) with the residual documented as an accepted micro-limitation (§11 #4): a legacy key/scope-id byte-identical to a denylisted name isn't auto-detected — errs toward the app working on macOS/VCS vaults. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WdNcANsuBvoc3iw6JXNKyX
This was referenced Jul 16, 2026
This was referenced Jul 19, 2026
jhoffner
pushed a commit
that referenced
this pull request
Jul 21, 2026
… goal check + transcript retry test Three codex P2 review findings on the spec: - alphaVantageRequest now specifies it injects apikey=ALPHAVANTAGE_API_KEY (AV requires it on all query endpoints; omitting it returns an HTTP-200 Information body → every live branch degrades despite a configured key). §7 test #1 asserts the key is in the request URL. - §7 goal check no longer asserts a blanket source: alphavantage. Transcript stays alphavantage; estimates (primary-wins) + insider (terminal fallback) stay finnhub when a key is present — the run either forces Finnhub off or asserts the AV-contributed fields directly. - §7 test #4 adds a non-calendar fiscal-year case proving the fiscal-label / alternate-label retry path is used, not a naive calendar-quarter mapper. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XPxFJs3jyMCXuwUPkmSjjo
This was referenced Oct 14, 2026
This was referenced Oct 23, 2026
This was referenced Oct 31, 2026
Merged
This was referenced Nov 10, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.