Skip to content

Add CI workflow for type checking and testing - #4

Merged
jhoffner merged 4 commits into
mainfrom
chores/github-workflows
Mar 1, 2026
Merged

jhoffner merged 4 commits into
mainfrom
chores/github-workflows

Conversation

@jhoffner

Copy link
Copy Markdown
Collaborator
  • Created a new GitHub Actions workflow in ci.yml to automate type checking and testing on pull requests and pushes to the main branch.
  • Configured the workflow to use Node.js version 22 and pnpm for package management.
  • Included steps for checking out the code, installing dependencies, type checking, and running tests.

- Created a new GitHub Actions workflow in ci.yml to automate type checking and testing on pull requests and pushes to the main branch.
- Configured the workflow to use Node.js version 22 and pnpm for package management.
- Included steps for checking out the code, installing dependencies, type checking, and running tests.
@vercel

vercel Bot commented Feb 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flow-state-dev-docs Ready Ready Preview, Comment Feb 28, 2026 11:20pm
flow-state-dev-kitchen-sink Ready Ready Preview, Comment Feb 28, 2026 11:20pm

- Added a new step in the GitHub Actions workflow to build packages using pnpm before type checking.
- This enhancement ensures that the packages are built and ready for type checking during the CI process.
- Added "zod": "^3.25.76" to devDependencies in package.json to support validation in development.
- This addition enhances the development environment for testing and type checking.
- Included zod version 3.25.76 in the devDependencies section of pnpm-lock.yaml.
- This addition aligns with the recent updates to enhance the development environment for validation and type checking.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@jhoffner
jhoffner merged commit 20dd9d7 into main Mar 1, 2026
4 checks passed
jhoffner pushed a commit that referenced this pull request Jul 14, 2026
… (owner-confirmed)

Owner chose clean break over migration. Replace the lazy per-scope
migration (§4.6) with a cheap first-access legacy detector that throws a
clear "legacy layout, will not read — move aside or delete" error instead
of silently mis-serving old flat files (satisfies BP-030's "reject removed
keys loudly"). This deletes the entire migration bug-class the review
surfaced: durable marker, stage-before-unlink, per-scope lock, case/Unicode
fold aliasing, empty-segment/leading-dot quarantine, notes/notes.md clobber.

Also: document Windows reserved device basenames (con/aux/nul/com*/lpt*) as
a new-write key constraint (§11 #4); a one-time migration tool is a
documented follow-up (§8) if ever needed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WdNcANsuBvoc3iw6JXNKyX
jhoffner pushed a commit that referenced this pull request Jul 14, 2026
…-guard scan; document denylist carve-out

Address re-review of 5acdfe7:
- §3.1 wrongly claimed the shared conformance suite covers files/src/utils.ts;
  verified it does not. Corrected, and §5 now requires ADDING that dotted-key
  case to the suite.
- Read-then-set gap: writing the marker is now a `set` responsibility — every
  set ensures the marker (idempotent, wx) before its data file, even if an
  earlier read cached the "fresh" scan; so no process/restart ever sees a data
  file without a marker and misreads a fresh store as legacy.
- The whole-subtree legacy scan lstat-guards and skips symlinked dirs (same
  rule as get/set/delete/collectRecords) — a vault symlink can't make the scan
  escape the store.
- Denylist minimized (.DS_Store/Thumbs.db/.gitignore/.gitkeep + .git/.obsidian/
  .svn/.hg dirs) with the residual documented as an accepted micro-limitation
  (§11 #4): a legacy key/scope-id byte-identical to a denylisted name isn't
  auto-detected — errs toward the app working on macOS/VCS vaults.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WdNcANsuBvoc3iw6JXNKyX
jhoffner pushed a commit that referenced this pull request Jul 21, 2026
… goal check + transcript retry test

Three codex P2 review findings on the spec:
- alphaVantageRequest now specifies it injects apikey=ALPHAVANTAGE_API_KEY
  (AV requires it on all query endpoints; omitting it returns an HTTP-200
  Information body → every live branch degrades despite a configured key).
  §7 test #1 asserts the key is in the request URL.
- §7 goal check no longer asserts a blanket source: alphavantage. Transcript
  stays alphavantage; estimates (primary-wins) + insider (terminal fallback)
  stay finnhub when a key is present — the run either forces Finnhub off or
  asserts the AV-contributed fields directly.
- §7 test #4 adds a non-calendar fiscal-year case proving the fiscal-label /
  alternate-label retry path is used, not a naive calendar-quarter mapper.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XPxFJs3jyMCXuwUPkmSjjo
@jhoffner
jhoffner deleted the chores/github-workflows branch November 8, 2026 16:27

This branch had an error being deployed

1 failed (outdated) and 2 active deployments
Preview – flow-state-dev-kitchen-sink — 81816d97 Deployed Feb 28, 2026 by vercel[bot]
Preview – flow-state-dev-docs — 81816d97 Deployed Feb 28, 2026 by vercel[bot]
Preview — 12730a28 Deployed Feb 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant