Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4eb29cb
refactor(workforce): rename worker messages to sendMessage and onMess…
claude Oct 27, 2026
86f9091
feat(workforce): a received message is its own item, and nothing is r…
claude Oct 27, 2026
f201a3e
FIX-2238: landing rules, task-sessions refusal and one budget
claude Oct 27, 2026
9413821
FIX-2238: every worker flow on an installation hears a message
claude Oct 27, 2026
1feba42
FIX-2238: docs, changeset, goal amended, epic seams updated
claude Oct 27, 2026
b03e4fe
Merge main into FIX-2238; review fixes
claude Oct 27, 2026
acdd330
FIX-2238: one chain for a task filed held; drop the dead messaged-wor…
claude Oct 27, 2026
752d290
FIX-2238: a received message's budget is what its chain has left
claude Oct 27, 2026
367eb69
FIX-2238: an answer reaches a worker that hears only in its tasks' se…
claude Oct 27, 2026
5d7ca95
FIX-2238 goal: the ring's own hand-offs aren't stray rows; the herald…
claude Oct 27, 2026
bfbae4c
FIX-2238 goal: 3:budget-left grades what the chain had left when heard
claude Oct 27, 2026
0e91fad
FIX-2238 follow-up: a fresh budget for a task held before it starts, …
claude Oct 28, 2026
0232b15
Merge the merged FIX-2238 branch history (no changes): the follow-up …
claude Oct 28, 2026
570849b
FIX-2238 follow-up: read a finished task session the way the steer ro…
claude Oct 28, 2026
d9d39a5
goal(FIX-2238): the goal's text for sendMessage, and its verdict
claude Oct 28, 2026
c14d50c
Merge remote-tracking branch 'origin/main' into claude/project-thread…
claude Oct 28, 2026
5bb75da
goal(FIX-2238): leg 6's one failure was the goal's timing, fixed in #…
claude Oct 28, 2026
cccdd43
Merge branch 'main' into claude/project-thread-n6abql
jhoffner Oct 28, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into claude/project-thread-n6abql
  • Loading branch information
jhoffner authored Oct 28, 2026
commit cccdd43ff333dbe3de36cd0cdccdc7393e951a3b
16 changes: 8 additions & 8 deletions goals/shift-manager/workers-message-each-other/goal.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# shift-manager › workers message each other

**Issue:** FIX-1989, amended by FIX-2238 (`specs/issues/FIX-2238/SPEC.md`); legs 6 to 8, FIX-2160 (`specs/issues/FIX-2160/SPEC.md`). Its spec's goal: `specs/issues/FIX-1989/SPEC.md` → "The goal, and how we'll know it's met".
**Issue:** FIX-1989; legs 6 to 8, FIX-2160 (`specs/issues/FIX-2160/SPEC.md`); legs 10, 10b and 10c, FIX-2239 (`specs/issues/FIX-2239/SPEC.md`), which replace leg 2b. Its spec's goal: `specs/issues/FIX-1989/SPEC.md` → "The goal, and how we'll know it's met".

**Outcome:** any worker can message any other worker on its user's roster with `sendMessage`, and hears one on `onMessageReceived`. A message lands as its own item, under the sender's name, in the session it is about: an answer (`inReplyTo`) in the session its original was sent from, even a finished task's; a message to the filer of the sender's task in the filing conversation; anything else in the recipient's own conversation. It wakes the recipient, whose plain text reaches no one. One budget per message a person types: 6 messages in all, 3 per request, a refused send spending nothing, and a delegate's ongoing session counting on in its filer's budget. A worker on another user's roster is refused as if it didn't exist, the coder (which hears only in its tasks' sessions) is refused by name before anything is written, a round-robin coordinator is heard, and the person sees every message, both sides, in Shift Manager's Messages view, across a restart.

Expand All @@ -13,13 +13,12 @@

**Signal:** each failure is tagged `<leg>:<assertion>`.

- **1** (Alice tells Researcher *"Ask the Shift Coordinator what the codename is, and tell me"*, after telling the coordinator the codename): `1:sent` Researcher's turn messages the coordinator; `1:own-item` the coordinator's conversation holds exactly one received item from Researcher, with its id and no `inReplyTo`, and the coordinator's turn ran for it; `1:answer-holds-codename` a Researcher answer to the person, in a turn after the coordinator's answer landed, holds the codename; `1:coordinator-answered` the coordinator sent Researcher a message back; `1:no-relay` the herald, messaged by Researcher and answering in plain text, has nothing of its answer reach any session.
- **1b** (the other way, and an answer to a second conversation): `1b:sent` the coordinator, told to tell Researcher a new codename, messages it; `1b:researcher-shows-message` Researcher's conversation shows it as a received item from the coordinator; `1b:next-answer-holds-it` Researcher's next answer to the person holds it; `1b:in-reply-to` the coordinator, asked in its second conversation to ask Helper A something, gets Helper A's answer in that second conversation, naming the question in `inReplyTo`.
- **2** (from a task): the coordinator's second conversation files Researcher a task to ask Helper A its favourite colour, then message the coordinator that it asked. `2:filed` the coordinator's board holds the task; `2:reached-helper` and `2:from-task` the message to Helper A was sent from the task's own session; `2:to-filer` the task's message to the coordinator lands in the filing conversation, not the default one; `2:answered` Helper A answers it; `2:lands-in-task-session` the answer lands in the task's session it was sent from, even after the task ended, and not in Researcher's own conversation; `2:no-row` Helper A's board holds no row.
- **2b** (no waiting): Researcher, told to message Helper A with `sendMessage` and wait for the answer: `2b:sent` its turn sends Helper A a message; `2b:turn-ends` its turn ends; `2b:no-wait` no call carrying `wait` was taken, and the answer never lands inside that turn.
- **3b** (through a delegation): Researcher messages Helper A, Helper A files Helper B a task, Helper B's task messages Researcher. `3b:reached` that message arrives; `3b:counts-on` it is counted in the exchange Researcher's line started: the same chain in the log, at a later hop.
- **3** (the budget): `3:per-request` the herald, told to message everyone, sends 3 and the rest are refused for the per-request limit; each of Researcher, Helper A and Helper B is told to pass every message on to the next, always, and the ring is started: `3:ring-stops-at-6` the ring's exchange (every message in the chain its first message started, whether or not it repeats the ring's word, including the ones Helper B sends from its ongoing session for Helper A's conversation) holds exactly 6 messages, and a session shows the seventh send refused `budget` (the run stops it at 20); `3:budget-left` each ring message's received item carries a budget that is a number, at least 0, at most 6 minus its hop, and never rising with the hop (a branched ring may leave less than 6 minus its hop); `3:refused-pays-nothing` the herald makes a refused send and then a sent one, and the sent one is the only row, at hop 1.
- **4** (refusals, and who can be messaged): the herald, whose instructions have it call the tool with any id it is given (so the refusal is seen at the tool, not left to a model that skips an id missing from its list), is asked to message Bob's worker, `eng.coder` and `rr-lead`. `4:bobs-worker-refused` the message to Bob's worker is refused `no_worker:` and writes no row; `4:create-check` Alice's create at Bob's derived conversation id is refused and Bob holds no session there; `4:coder-refused` a message to `eng.coder` is refused `task_sessions_only` and writes no row; `4:round-robin-heard` `rr-lead`'s conversation shows its own turn for the herald's message; `4:sender-not-settable` a call naming `from`, `call` or `budget` is never taken, and no row sent from Researcher's conversation names another sender; `4:hire-refuses` `hireWorkforce` refuses a worker flow without `onMessageReceived` and takes one with it; `4:no-task-row` every row on every conversation's board is one leg 2, 3b or 3 filed (the ring's hand-offs from Helper A to Helper B).
- **1** (Alice tells Researcher *"Ask the Shift Coordinator what the codename is, and tell me"*, after telling the coordinator the codename): `1:sent` Researcher's turn messages the coordinator; `1:answer-holds-codename` a Researcher answer to the person, in a turn after the coordinator's answer landed, holds the codename; `1:coordinator-shows-message` the coordinator's conversation shows exactly one line *From researcher:* under Researcher's name; `1:coordinator-answered` it sent Researcher a message back.
- **1b** (the other way): `1b:sent` the coordinator, told to tell Researcher a new codename, messages it; `1b:researcher-shows-message` Researcher's conversation shows it under the coordinator's name; `1b:next-answer-holds-it` Researcher's next answer to the person holds it.
- **2** (from a task): the coordinator files Researcher a task to ask Helper A its favourite colour. `2:filed` the coordinator's board holds the task; `2:reached-helper` and `2:from-task` the message to Helper A was sent from the task's own session; `2:answered` Helper A answers it; `2:lands-in-own-conversation` the answer lands in Researcher's own conversation, not the task's ended session, under Helper A's name with the colour; `2:wakes` a Researcher turn writes after it; `2:no-row` Helper A's board holds no row.
- **3b** (through a delegation): Researcher messages Helper A, Helper A files Helper B a task, Helper B's task messages Researcher. `3b:counts-on` that message is counted in the exchange Researcher's line started: the same chain in the log, at a later hop.
- **3** (the limits): `3:per-turn` the herald, told to message everyone, sends 3 and the rest are refused for the per-turn limit; each of Researcher, Helper A and Helper B is told to pass every message on to the next, always, and the ring is started: `3:ring-stops-at-6` the ring's exchange (every message in the chain its first message started, whether or not it repeats the ring's word) holds exactly 6 messages (the limit is the whole exchange's: a worker that both passes a message on and answers it branches the ring, and every branch counts against the same 6; the run stops it at 20 messages); `3:seventh-refused` a conversation shows a send refused at the hop limit; `3:another-round` one more line from the person lets the ring pass at least one more, none past hop 6.
- **4** (refusals, and no delegation): the herald, whose instructions have it call the tool with any id it is given (so the refusal is seen at the tool, not left to a model that skips an id missing from its list), is asked to message Bob's worker and then `eng.coder`. `4:bobs-worker-refused` the message to Bob's worker is refused `no_worker:` and writes no row; `4:create-check` Alice's create at Bob's derived conversation id is refused and Bob holds no session there; `4:coder-refused` a message to `eng.coder` is refused with *file a task*; `4:sender-not-settable` a call naming `from` is never taken, and no row sent from Researcher's conversation names another sender; `4:no-task-row` every row on every conversation's board is one leg 2 or 3b filed.
- **5** (after a restart on the same store, in a browser as Alice): `5:lists-every-message` the Messages view lists every message the legs' tool calls say they sent; `5:both-sides` each with sender and recipient; `5:opens-side` the recipient's and the sender's links of Researcher's first message to the coordinator open those sessions, the recipient's showing the line from Researcher.
- **6** (to a task, FIX-2160; sent by the courier, a hire told to make exactly the call it is handed, so a refusal is seen at the tool): the coordinator's conversation files Researcher a task through the board's own action. `6:lands-in-task-session` a `{ task }` message lands in the session the task's run named, as a line from the courier, and the turn that hears it starts after the task's turn ended; `6:finished-keeps-history` once the task finished, a message asking for a word only the task's goal held is answered from that session; `6:task-unchanged` the row's status, attempts, output and session are the same before and after; `6:not-started` a held task's message is refused `no_task_session` and writes no row; `6:bobs-task` Bob's started task is refused with exactly the text an unknown id gets; `6:own-task` a follow-up running in the task's session, told to message its own task, is refused `not_yourself`.
- **7** (to a conversation by id): `7:second-conversation` Researcher, told to message its second conversation with Alice (opened as Shift Manager opens one), lands there; `7:project-conversation` the courier's message to Alice's Storefront project coordinator conversation lands there; `7:refusals` Bob's conversation (`no_session`), a fired worker's (`no_worker`), a moved worker's (`worker_unavailable`), the sending conversation (`not_yourself`), a task's session and a delegate's session (`not_a_conversation`) are each refused and gain no row.
Expand Down Expand Up @@ -69,3 +68,4 @@ The spec's other-organization signals (`6:other-org`, and another org's session
| 2026-10-14 | `fd8081663` (stack head) | workers `openai/gpt-5.4-mini`, coordinator `anthropic/claude-haiku-5-5` | **FAIL** | 1, 1b, 2b, 3b, 5 PASS. 2 FAIL `2:answered` (Helper A, woken, answered in plain text instead of calling `messageWorker`; leg 2 passed in 2 of 5 runs). 3 FAIL `3:ring-stops-at-6` (10 passed: woken workers both forwarded and answered, so the ring branched; each branch stopped at the hop limit). 4 FAIL `4:bobs-worker-refused`, `4:coder-refused` (the model declined to call the tool for an id not in its list, so no refusal was seen; leg 4 passed on an earlier run). Every control failed on its assertion: `no-wake` 1:answer-holds-codename, `drop-ended` 2:lands-in-own-conversation, `no-hop-cap` 3:ring-stops-at-6 (46 passed), `no-roster-check` 4:bobs-worker-refused, `fresh-hop-on-task` 3b:hop-2, `memory-log` 5:lists-every-message. Before-state `e2ee2c18`: every leg failed except 2b, which passed with no tool to call; `2b:sent` now requires a message to have gone out. |
| 2026-10-28 | `3cbab3a64` (main, FIX-2160 merged) | workers `openai/gpt-5.4-mini`, coordinator `anthropic/claude-haiku-5-5` | **PASS** | Legs 6, 7, 8 (FIX-2160): 4 of 4 runs passed (three on the PR's heads `a0149c2d1` and `973404f23`, one on merged `main`). Every control failed on its assertion: `task-to-conversation` 6:lands-in-task-session, `no-kind-check` 7:refusals, `coder-resumes-open` 8:running-refused. The send's own controls were re-anchored to the by-name path and rerun on `main`: `pay-first` 3:refused-pays-nothing, `no-roster-check` 4:bobs-worker-refused, `no-turn-back` 4:round-robin-heard. Before-state `acdd3303c` (FIX-2238's head, `to` takes a worker's id only): 6, 7 and 8 all failed (6 on every signal it checks, 7 on second-conversation, project-conversation and refusals, 8 on finished-answered and running-refused). |
| 2026-10-28 | `570849be4` (#4021, FIX-2238 and its follow-up on `main` with FIX-2160) | workers `openai/gpt-5.4-mini`, coordinator `anthropic/claude-haiku-5-5` | **PASS** for FIX-2238's legs | Legs 1 to 5 passed in 3 runs: on `bfbae4c08` with the follow-up's changes uncommitted, and twice on `570849be4`. A fourth run on `570849be4` failed `3:ring-stops-at-6`: the ring stopped after 3 messages, with no budget refusal, which is a hand-off the model didn't make (the ring stopped at 6 in 5 of 6 full runs this session). Legs 6 to 8 (FIX-2160) ran alongside and failed `6:lands-in-task-session` in 1 of 3 runs on `570849be4`: by the turn's record, which the engine writes when a deferred request is queued; nothing of the message ran while the task's turn was open, and #4026 times the turn by its first item instead. Every FIX-2238 control failed on its assertion (run on `5d7ca952b` / `bfbae4c08`): `relay-back` 1:no-relay, `no-wake` 1:answer-holds-codename, `answer-to-conversation` 2:lands-in-task-session, `ongoing-at-0` and `no-hop-cap` 3:ring-stops-at-6, `pay-first` 3:refused-pays-nothing, `fresh-hop-on-task` 3b:counts-on, `no-roster-check` 4:bobs-worker-refused, `refuse-at-receive` 4:coder-refused, `no-turn-back` 4:round-robin-heard, `no-hire-check` 4:hire-refuses, `memory-log` 5:lists-every-message (0 of 3 listed after the restart). |
| 2026-10-28 | `f417cda1e`; controls on `4e69b7e10` | workers `openai/gpt-5.4-mini`, coordinator `anthropic/claude-haiku-5-5` | **PASS** | Legs 10, 10b, 10c (a worker's call): 3 of 3 runs passed every assertion (two on `f6536df27`, one on `f417cda1e`). Every control failed on its assertion, and each patch was confirmed to reach its code: `no-person-hold` 10b:queued, `ignore-deadline` 10b:queued, `no-default-deadline` 10:default-deadline, `send-again` 10b:kept, `relay-the-call` 10:no-second-line, `no-step-guard` 10c:one-wait-per-step. `no-default-deadline` and `no-step-guard` patch the wait check that a call shares with `getTask` (orchestration's `checkWaitable`). |
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.