Repository navigation
FIX-2280: the Teammates lab reads a worker's project from its conversation #4086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
966b1d9
FIX-2154: wire the Teammates lab to the real packages
claude 830c32d
FIX-2154: record the goal's verdicts and controls, file the gaps
claude 944bbca
FIX-2154: say user, not person, in the lab's comments
claude 2fd0c09
FIX-2154: name the Teammates lab's server config as a fallow entry
claude 95fe4cf
FIX-2154: keep host.mts's own constants unexported
claude 4d397d8
FIX-2154: answer review on the adapter and the goal
claude 0660cd6
FIX-2154: read the feed's snapshot again when the history moves while…
claude ed88b9f
FIX-2154: hand the lab's Codex runs only the environment Codex needs
claude e8207d9
FIX-2154: follow a task's run by the session its card already names
claude e7ea812
FIX-2154: name the issue in the Codex pass-list changeset
claude ffb6fdd
FIX-2280: the Teammates lab reads a worker's project from its convers…
claude 6e31e6b
FIX-2280: show a pick made here at once, before the next read confirm…
claude 4e01de4
FIX-2289: render worker text as Markdown in the Teammates lab
claude 9790706
Merge remote-tracking branch 'origin/claude/project-thread-e54cfm' in…
claude 920da34
FIX-2289: keep MessageResponse internal to the lab's Markdown component
claude ecb5e55
FIX-2280: recount the lab inventory after the merge
claude 6ee5d73
FIX-2280: a project set back elsewhere shows after a pick here
claude 649e971
FIX-2289: read the lab's entries as shown in the goal check
claude 7102c9e
FIX-2289: show a worker's answer as it is written
claude 5258966
Merge remote-tracking branch 'origin/claude/project-thread-e54cfm' in…
claude 49dd1b3
Merge main into FIX-2280 (keep both session-read tests; take main's p…
claude c295253
Merge main into FIX-2154 lab branch
claude 2480d98
Merge remote-tracking branch 'origin/claude/project-thread-e54cfm' in…
claude 0b3fc04
FIX-2280: recount the Teammates inventory after merging #4079
claude 7bd40d0
Teammates lab: an unlinked task answer is not drawn as failed; lead n…
claude b82f66d
Teammates lab: researcher answers only through sendMessage; goal wait…
claude 7f9874b
Merge remote-tracking branch 'origin/claude/project-thread-e54cfm' in…
claude a1dd201
FIX-2280: recount the Teammates inventory after merging #4079 at b82f…
claude 78ce1ac
Merge main into FIX-2280 after #4079 landed
claude 623e4db
Port fix: a task-board test still named the old human_input suspensio…
claude 50789cc
FIX-2280: recount the Teammates inventory after the main merge settled
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /** | ||
| * The project the screen names for a worker comes from the conversation's own | ||
| * `workProjectId`, as the session read shows it, so a pick made in another tab | ||
| * or client shows too (FIX-2280). | ||
| */ | ||
| import { describe, expect, it } from "vitest"; | ||
| import { shownOnChange, workProjectOf } from "../src/adapter"; | ||
|
|
||
| describe("a worker's project, read from its conversation", () => { | ||
| it("names the shared project the session read shows, whoever set it", () => { | ||
| expect(workProjectOf({ workerId: "lead", workProjectId: "shared/apollo" })).toBe("apollo"); | ||
| }); | ||
|
|
||
| it("names none before a pick, and none for a private project the screen doesn't list", () => { | ||
| expect(workProjectOf({ workerId: "lead" })).toBeUndefined(); | ||
| expect(workProjectOf(undefined)).toBeUndefined(); | ||
| expect(workProjectOf({ workProjectId: "private/apollo" })).toBeUndefined(); | ||
| expect(workProjectOf({ workProjectId: "apollo" })).toBeUndefined(); | ||
| }); | ||
|
|
||
| it("shows a change made elsewhere back to the project last read, after a pick here", () => { | ||
| const seen: (string | undefined)[] = []; | ||
| const show = shownOnChange<string | undefined>((project) => seen.push(project)); | ||
| show("apollo"); // read | ||
| show("beta"); // picked here, shown at once | ||
| show("apollo"); // read: another client set it back | ||
| show("apollo"); // read again: nothing new | ||
| expect(seen).toEqual(["apollo", "beta", "apollo"]); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.