Repository navigation
FIX-2335: Teammates lab drops projects for one working folder from config - #4206
Conversation
…nfig The lab's host now runs on the existing constant run source, a git checkout the operator names in TEAMMATES_WORKDIR, listed in localRepositories. Unset, missing or not a checkout, the lab fails at start; it never falls back to the current directory or its own checkout. Project tools, TEAMMATES_PROJECTS and the start-up project writes are gone, and so are the header project select, the New project form, the needs-project card and the repository approval card. Task cards say running and done. No WORKER.md mentions a project. ER-8 and FIX-2154 D3 get dated amendments scoped to this lab; packages/ is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiCsRqCenZsFQRpJBHi
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture pass (read-only review)Verdict: the approach is right. Reusing the existing constant run source ( Should fix
Worth a look (not blocking)
Architecture opportunity (only because this PR already touches it)
Not verified hereReal-model goal and the "hire a PM" run (as the PR notes). I read the diff only; I did not run vitest. Generated by Claude Code |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGfGi2RaecD1vUwy8K
There was a problem hiding this comment.
Simplify review (FIX-2335)
Verdict: Approve. The direction matches the ER-8 / D3 amendments: one operator-named checkout, constant localWorkspaceHost source, and deleting the projects flow, adapter surface, and UI rather than hiding it behind a single auto-seeded project. That is the cleaner operational model for "prove projects aren't required," even though the diff is wide.
Did the approach go too far?
| Alternative | Trade-off |
|---|---|
Hide UI, keep one TEAMMATES_PROJECTS + setWorkProject on open |
Smaller diff, but two sources of truth (env checkout vs project record), startup runAction, polling, and worker project tools stay live. |
| What this PR does | ~620 net lines removed, one mental model, aligns with kitchen-sink / harness-manager constant-repo hosts. Costs: Teammates no longer demos Workforce project UX until restored. |
For the documented product call, depth is justified, not accidental complexity.
What looks good
- Host wiring (
remotes: { allow: [] },source: () => ({ kind: "repo", repo: workdir })) reuses an established pattern instead of a lab-only resolver. - Removing project bootstrap,
watchProjects/watchWorkProject, and approval/project card UI is a real simplification (less polling and session I/O). - Spec amendments in DECISIONS track the supersession honestly; README inventory and "Not wired yet" notes are coherent.
Follow-ups (non-blocking)
These are suggestions, not merge gates — I'd still ship as-is if you're time-boxed.
- Brittle "no project" checks — Step 5 and
screen.test.tsxscan all page text for/project/i. That fails if a model innocently says "project" in prose, and it conflates "no project UX" with "never utter the word." Prefer asserting absence of removed UI (aria-labelproject select, approval entries, task prompt groups) like the old chip check did. workingFoldertests — Deletingwork-project.test.tsleaves no unit coverage for unset / non-dir / non-git failures; a small vitest on the exported helper would lock the fail-fast contract.- Hygiene — Stale
host.mtsfile header still mentions a projects flow; unusedcnimport inTaskCard.tsx; extra blank line inConversationEntryunion inadapter.ts. - Optional parity — Other labs use
realpathSyncon checkout paths and sometimes explicitbaseRef: "HEAD"on constant sources; worth aligning if you hit symlink edge cases (not required for this PR). - Task card status copy — Raw
running/done/failedis simpler code but less operator context thandone in …; fine if intentional.
Performance
Net win from dropping startup project creation and 3s project list polling; no new hot-path concerns in the lab app.
Sent by Cursor Automation: Review For Best Approach
There was a problem hiding this comment.
Code Snob — already tight on e117f54c. No POC.
Read labs/teammates/host.mts (workingFolder, openTeammates), fsdev.config.mts, src/adapter.ts (toBoardTask, QUIET_ACTIONS), src/components/Conversation.tsx, TaskCard.tsx, Entry.tsx, Runs.tsx, WorkersList.tsx (BackgroundItems), src/flows/coder.ts, test/screen.test.tsx, test/fake-lab.ts, and both goals/teammates-lab/*/run.mts checkouts. The ER-8 and FIX-2154 D3 amendments stay as recorded.
A rewrite would not shrink this contract:
workingFolderis the three startup messages (unset, not a folder, not a checkout) and the absolute path the constant source closes over.RunSourceis a function, sosource: () => ({ kind: "repo", repo: workdir })is the call. Collapsing the throws changes the text the start contract prints. A shared helper waits for a second caller; this file is the only one.QUIET_ACTIONSis one name (dispatch) used by two filters, with the reason on the const. Inlining the compare repeats that reason or drops it.- Conversation's
panelis only"instructions"now. A boolean is the same number of lines. TaskCardstill importscnand does not call it. Deleting the import is one line, the same card.- The consult goal's
git initis three lines. The other goal's checkout also writes a README, a gitignore, and a commit. Sharing that helper carries work this goal does not do. - Task cards and the sidebar both print
task.status. There is no second format to share.
Sent by Cursor Automation: Code Snob
…unused import Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGfGi2RaecD1vUwy8K
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9743fb337
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The project tools were the only thing asking for approval, but waitForUser is a control tool every agent worker has. Without the entry and answerApproval a worker that asked would stop with nothing on the page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGfGi2RaecD1vUwy8K
#4183 (FIX-2288) changed the lab's files without rewriting the table, so the lab's inventory test is red on main and on every PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGfGi2RaecD1vUwy8K
|
Generated by Claude Code |
Red on main since #4078: both hook-timeout failures in worker-calls.test.ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGfGi2RaecD1vUwy8K
|
Generated by Claude Code |
1 similar comment
|
Generated by Claude Code |
…to claude/project-thread-7txcx4
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGfGi2RaecD1vUwy8K
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGfGi2RaecD1vUwy8K


Requested by Jake · project thread
Closes FIX-2335 (under FIX-2152). Stacked on #4199 (FIX-2332): base it on that branch, or on main once #4199 merges. FIX-2336 (Chief of Staff) stacks on this.
What changes
Jake took projects out of the Teammates lab (2026-10-29). The lab now works in one working folder that the operator names at start.
host.mtsuses the existing constant run source,{ kind: "repo", repo: TEAMMATES_WORKDIR }, with that folder inlocalRepositories. Every coding run gets a worktree of it, and the source reads use it. There's no lab-only resolver and no new run-source kind, and no model can see or pass a path.TEAMMATES_WORKDIRis unset, missing, or not a git checkout, the lab stops with an error that names the setting and the path. It never falls back to cwd or the lab's checkout. Checked by hand:teammates: TEAMMATES_WORKDIR is not set. Set it to the git checkout the team works in.teammates: TEAMMATES_WORKDIR names /…/nope, which is not a folder on this machine.projectTools,setWorkProjectTool), the projects flow,TEAMMATES_PROJECTSand the start-up project writes.NewProjectForm, and theneeds-projectstatus, card prompt andPICKED_LINE. The approval card stays as generic plumbing. Any agent worker can callwaitForUserwith an approval (it's a control tool), so the page must still show the card and answer it.watchProjects,createProject,setWorkProjectandwatchWorkProjectfrom the adapter, andwork-project.test.ts.projectWorkspaceCapabilityis gone from the agent flow'susesand from coder's managers. A constant source reads no project collections.tools:lines droplistProjectsandsetWorkProject.rg -i project labs/teammates/src labs/teammates/workforcenow finds only the package tool namesglobProjectSource,readProjectSourceandgrepProjectSource.specs/epics/FIX-2152/DECISIONS.md) and FIX-2154 D3. They cite Jake's words and the Architect's conditions, and are limited tolabs/teammates.a-worker-talks-to-another-while-you-talksetsTEAMMATES_WORKDIRto its scratch checkout. Step 5 now fails if the page mentions a project. Theproject-not-keptcontrol is gone, since there's nothing left to patch.consults-a-conversation-without-waking-itgives the lab an empty scratch checkout.packages/has no diff.Verification
labs/teammatesvitest: 37/37 pass. The new screen test files a coding task and asserts that it runs at once, with no combobox, no group and no "project" anywhere in the page.working-folder.test.tscovers the startup check. An approval screen test (writer waits for a yes, then goes on after Approve) and anentries.test.tsmapping case cover the kept card. The mapping case fails with theuser_approvalbranch removed.fsdev devagainst a scratch git checkout: the page serves (200) and the roster lists lead, researcher, writer and coder.localWorkspaceHostwith the constant source answers{kind:"repo"}and globs the checkout.check-retired-terms, the vocabulary sweep, the goals tsc andinventory.mjsall pass.Known gap (package, not changed here):
projectSourceTools' own descriptions still say "the project this session works in". The README lists this under Not wired yet.No changeset: private lab.
🤖 Generated with Claude Code
https://claude.ai/code/session_01NczDiGfGi2RaecD1vUwy8K