Repository navigation
FIX-2343: a coding task's run reads as plain steps on every harness - #4232
Conversation
The Teammates lab's task popup names each tool call in the UI registry's words (tool-naming, tool-grouping), folds runs of steps into one line, leads with the result, and says "Starting on <harness>" from filing. The registry now reads Claude Code's, Codex's and Cursor's tools the same and keeps a file's name under a long worktree path. Claude Code runs stop loading this machine's user settings (output styles), and the Cursor block keeps its own name, so its run says what it started on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiCsRqCenZsFQRpJBHi
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
Second look + architecture pass (read-only; no edits made)Verdict: the approach is right. Naming comes from the registry, the lab parses nothing harness-specific, and 1. Grep/Glob steps still lead with the bare tool name (small, in scope)
2.
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGPxx9RA1XY7n7yd4v
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f482234010
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…dead-code findings Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGPxx9RA1XY7n7yd4v
The spec PR removed the README's inventory block, so the lab's inventory test fails on main. Ported here to get this PR green; it no-ops once main carries the same fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGPxx9RA1XY7n7yd4v
|
Generated by Claude Code |
Jake is removing README stats tables on purpose; #4127 fixes main by dropping the claude-code-style lab's table check instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGPxx9RA1XY7n7yd4v
|
@claude resolve conflicts |
Main now runs an unnamed coding task on Cursor, so the plain-steps test names Claude Code for its Claude Code row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGPxx9RA1XY7n7yd4v
|
Conflicts resolved in 80bccd7, which merges main into this branch. The only conflict was in Generated by Claude Code |
Requested by Jake · project thread
Closes FIX-2343 (under FIX-2152). Based on main.
What changes
tool-namingandtool-groupingintosrc/components/flow-state/, the way it already installsmessage-response. Nothing in the lab parses a harness's output.Bash, Codex'scommand_executionand Cursor'sshellare all "ran a command".Edit,editand Codex'sfile_changeare all "edited a file".Grepis "searched the code". Lookup ignores case, since Claude Code saysBash.file_changeis named by the files it touched.patchchangeset covers Shift Manager, since its tool lines change words.CLAUDE.md(settingSources: ["project"]). A user output style, such as Explanatory's "★ Insight" boxes, no longer comes through.cursor, so the lab's harness line never matched it (FIX-2342). The block now keeps its own name,cursor-agent.Verification
labs/teammatesvitest: 63/63 pass.runSteps.packages/uivitest: 239/239 pass. New tests:· Edit,· Bash).runSteps, give:check-retired-terms, goalstsc, the lab'svite build,packages/uitypecheck, and the Kitchen Sink and ui registry drift tests.packages/shift-managerhas 584 tests passing, with 1 failure that fails the same way on main (its built pages are missing in this checkout).Generated by Claude Code