Skip to content

spec(epic): attachments in every chat (FIX-2516) - #4766

Merged
jhoffner merged 1 commit into
mainfrom
epic/attachments
Nov 5, 2026
Merged

jhoffner merged 1 commit into
mainfrom
epic/attachments

Conversation

@jhoffner

@jhoffner jhoffner commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

from: fsd-pm
session: fix-2516-epic-pm
kind: ask

A team that… Today After this epic
chats in Kitchen Sink, Shift Manager or a lab Kitchen Sink drops a pasted screenshot on send, with no message. The others cannot attach Paste, + or drop. See and remove each file. The reply shows that the model saw it, also after a reload
runs a coding worker on Claude Code, Codex or Cursor Describes the bug in words. The adapters send a string The images of the turn get to the harness. If it cannot take a type, it says so
files a task in Shift Manager with a screenshot The worker does not see it The image is part of the task brief. A re-run or a hand-off keeps it
builds a flow on FSD Writes its own base64 field, limit checks and rendering Sends attachments next to the input. The engine checks the limits. A generator gets file parts
builds its own composer Builds paste, picker and previews again, or does not have them Installs the registry pieces with fsdev ui add

Goal: in every chat in our apps, a person can attach images and documents to a message (paste, a + picker, drag and drop). The person sees them and can remove them before sending. The reply shows that the model or harness saw them.

flowchart LR
  A["each app · five chats"] --> L1["leg a · paste one image, pick a second, send"]
  A --> L2["leg b · attach a PDF, ask what only it says"]
  A --> L3["leg c · an 11th image, an oversized file, an unsupported type"]
  L1 -->|"reply describes both · reload shows both"| P["PASS · the goal is met"]
  L2 -->|"reply carries the PDF's code word"| P
  L3 -->|"a plain message · nothing sent"| P
  C["control · today's main"] -.-> A
  A -.->|"under the control"| F["must FAIL · every leg"]
Loading

The closure issue FIX-2565 proves it, in the browser, on one main commit after all other children merge. The control is today's main: it must fail every leg.

What's in the box: attachments beside the input, one limits set checked by the server, file parts on the user line and to a generator, files to Claude Code, Codex and Cursor, a task brief that keeps its files, and the registry composer pieces. A fence: bytes travel inside the request, 10 images and 3 MB a message. Not built: files in replies, audio and video, a file library, drive pickers, Word and Excel, upload once

The fence is Q1. The bytes travel inside the request. One limit set, sized for the strictest host, keeps every app the same.

Why now. The owner asked on 2026-11-03. Most of the composer is already in the registry and nothing uses it. Kitchen Sink drops pasted images today.

The set: 8 children and the closure. The framework and the composer start in parallel. Then the harnesses, then the four apps, and documents (narrowed: PDF and text files; Word and Excel are cut). As of 2026-11-05: all 9 in Backlog. The spec has the snapshot and links to live state.

Who owns what: ten rules across FIX-2517 to 2524, the closure FIX-2565 and the coordinator, each rule with one owner

Each rule has one owner. A uses cell is a place where a child must not decide again.

Sign off

The goal, at that size: five chats, images and PDFs, refusals that say why, checked in the browser. If wrong: one app gets it and the coding harnesses stay blind.

The set's debt: net up, on purpose. One new capability. The named debt is image bytes inside stored sessions until FIX-824. If wrong: sessions grow until a reload is slow. The kill line catches that first.

Open · Q1 · In v1, do stored sessions keep the bytes inside the message?

Q1: inline bytes, recommended, beside a blob store first and stripping the bytes. Decides it: whether a reload shows the image without a store we do not have. Price: about 3 MB per 10-image turn and a 3 MB per-message cap

The deciding row is the reload. Only inline shows the image without a new store. I recommend inline, with a 3 MB cap a message, measured in the first FIX-2517 PR. The cap comes from the 4.5 MB Vercel request limit, so a PDF is 3 MB at most, not 20 MB. If wrong: stored sessions keep bytes, and the later move to pointers must read both shapes.

Open · Q2 · Do attachments go next to the input, or in it?

Q2: beside the input, recommended, beside a field inside each flow's input. Decides it: whether a hand-built request can skip the limits. Price: four new public names

The deciding row is a hand-built request. Next to the input, it cannot skip the server check. I recommend next to the input. If wrong: we deprecate one public field in a minor.

Eight children and a closure; documents after images · D1

D1: eight children and a closure, chosen, beside documents folded into the framework and harness issues. Decides it: Codex and Cursor take no documents. Price: one more issue

The deciding row is Codex and Cursor: they take no documents, so documents need their own answer. If wrong: two lab issues that must be one. The spec set merges them if both have no decision of their own.

Also decided: limits, documents per harness, how each harness gets files, history, steering and drafts (Decided, not asked). The owner settled the task brief, FIX-137 and the Word and Excel cut.

Analysis: right approach, with changes. reuse-review moved four Adds onto existing pieces (the PromptInput attachment hook, its limit props, FileContent, the steering next-turn path). The adhd pass did not run: this session could not start sub-agents.

Reviewers · look here

  • Q1 and the kill line. If 10 downscaled screenshots do not fit in 4.5 MB, the app children stop and FIX-824 goes first. That changes the epic, not one issue.
  • Is it 8 or 7? The two lab issues are the ones I would merge. I keep them, with a collapse trigger.

Not here: the approach of a single issue. The spec-set PR has those.

Spec · Decisions · Linear FIX-2516 · closure FIX-2565 · merges after human approval and required checks

How to review this — an epic-spec, not an implementation plan

This is an epic-spec: the shared objective and cross-cutting decisions for a set of
issues, in a retained document set. It is not any one issue's implementation design, and it
is not a schedule.

In scope to challenge:

  • The objective and the goal in SPEC.md — is this body of work worth doing, and is the
    goal the real need at full size, or a smaller one the set could meet while the need stays
    unmet? Would the closure issue's check fail if the goal were not met?
  • Whether the set overbuilds. Each issue can earn its place while the whole is too much.
    That question can only be asked here.
  • The set's debt in SPEC.md — something the set overlaps and doesn't name, or adds and
    doesn't list.
  • Builds on / Adds in that same section — an Adds item that does not name the existing
    piece it considered, or that is a second mechanism for something we already have
    (orchestration.md).
  • A cross-cutting decision in DECISIONS.md — shared surface, naming, sequencing, contracts.
  • A rule in DECISIONS.md → Who owns what with no owner, or two.
  • A missing issue the objective implies, or one in the set that doesn't serve it.

Out of scope — owned by the individual issue specs:

  • Any single issue's approach, architecture, file layout, or test plan.
  • Anything that touches exactly one issue. It belongs on that issue's spec PR.
  • The figures, at the pixel level, and routine status movement since the dated snapshot.
  • POC production polish. End-state experiments under the owning spec's poc/
    show shape and scoping, not shippable implementation. Directional evidence, experimental
    isolation and absence of secrets/generated dependencies remain in scope.

Feedback in the second list is routed to the issue it concerns as an implementer note, not
folded in here.

Required repository checks, approvals and review-thread policy still govern merge.
Optional comments are triaged, not a reason to grind to zero or restart the design review.


Generated by Claude Code

The retained epic spec for FIX-2516: eight children (FIX-2517..2524)
and the closure FIX-2565, the owner's five objective lines, D1 (the
division), ten rules, and two open forks for the owner: Q1, inline
bytes in stored sessions for v1, and Q2, attachments beside the input
in the public API. The brief's engineering questions are answered under
"Decided, not asked".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UNkLDFC34GyzBvuAnNLbx
@vercel

vercel Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flow-state-dev-build-site Ready Ready Preview Nov 5, 2026 12:39am UTC
3 Skipped Deployments
Project Deployment Actions Updated
flow-state-dev-docs Ignored Ignored Nov 5, 2026 12:39am UTC
flow-state-dev-kitchen-sink Ignored Ignored Nov 5, 2026 12:39am UTC
flow-state-dev-ui Ignored Ignored Nov 5, 2026 12:39am UTC

Request Review

@linear-code

linear-code Bot commented Nov 5, 2026

Copy link
Copy Markdown

FIX-2516

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T00:43:09.512221Z 7012fb8 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

jhoffner commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator Author

from: fsd-pm
session: fix-2516-epic-pm
kind: ask

@codex review

Pay special attention to:

  • Q1 and the kill line: whether 10 images downscaled to 1,568 px can fit in 3 MB of files, and so under Vercel's 4.5 MB request body once base64-encoded.
  • The claims in SPEC.md "What's already here" against main (FileContent, itemToLLMMessages keeping text only, HarnessRunInput { prompt }, usePromptInputAttachments).
  • Whether ER-7 (a task's files live on the task row in orchestration) conflicts with FIX-2369 ER-1 or with how harness-manager builds a run from a row.

Generated by Claude Code

jhoffner commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator Author

Second look + architecture pass (read-only, no edits)

Verdict: the goal is sound and the reuse claims check out. Some of the first-release scope and verification can be trimmed.

Premises spot-checked against main:

  • FileContent exists in packages/contracts/src/items/content.ts.
  • PromptInput already has accept, maxFiles and maxFileSize.
  • HarnessRunInput is { prompt: string } today.
# Finding Recommendation Est. Δlines Sev Conf
1 Two lab children (FIX-2523, FIX-2524), each with its own spec and PR Fold into one "labs" child now. The spec's own collapse trigger fires: both only consume FIX-2518 and FIX-2519. −150 Med Med
2 Closure runs 3 legs × 5 chats, plus a planted-strip control and a "main must fail" control Run legs a, b and c per distinct send path (flow chat, harness, task brief). Keep the must-fail-on-main control for leg c only. Drop the planted server-strip control, since leg b's code word already proves the bytes reach the model. −120 Med Med
3 FIX-2520 as its own child (PDF and text files) Consider shipping images only in this epic. PDF is the only real work and no named consumer needs it yet. This is a scope call, and the owner wrote "images and documents" into the goal, so it is the owner's decision. −200 Med Low
4 Per-turn directory for Codex and Cursor with cleanup and a .git/info/exclude fallback (ER-8) It exists only for PDFs, so it goes away with #3. If PDFs stay, this stays. −60 Low Med
5 History replay rule: 10 images and 5 documents, older ones stubbed, up to 20 images a request Send only the current turn's files and stub earlier ones by filename. Add replay when a flow needs it. −30 Low Low

Net if all taken: about −540 lines of spec and later code. Items 3 and 4 depend on the owner's scope call.

Considered and deemed justified: the eight-child split for the framework, UI and harness children; attachments beside the input (Q2); inline bytes plus the kill line (Q1); reuse of FileContent, the PromptInput props and harnessSteering; task-brief files (ER-7, owner-settled); the five figures.

Architecture notes (improve-codebase-architecture)

This is a spec-only PR, so the opportunities are in how the children are shaped. The spec already leans the right way: one server-side limits check, so no per-flow copies. Two things to keep the implementation from drifting:

  • Keep one limits module. The server limits (10 images, 3 MB) and the PromptInput limit props should read from a single shared constant in the contracts layer. Two copies would put the check in two places again.
  • Keep the harness file hand-off behind one seam. HarnessRunInput should gain one attachments field. The Claude Code, Codex and Cursor adapters should each translate it, and none should parse messages themselves. A fourth harness then adds one adapter and no new contract.

Neither of these is a reason to widen scope.


Generated by Claude Code

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify review (PR #4766)

Verdict: The layered approach is the right shape for this epic — central limits + attachments beside the input (Q2), reuse FileContent / PromptInput plumbing (ER-1, ER-6), measure-before-apps kill line (ER-9), and a separate documents track because Codex/Cursor do not take documents (D1). Upload-first (FIX-824) as the default would trade one epic for another; inline v1 with a kill line is a simpler delivery path given what already exists in the registry and AI SDK file parts.

I would not re-architect toward fewer framework surfaces; the main simplification wins are issue cardinality, spec verbosity, and closing the open gates cleanly before child specs land.


What already looks lean (keep)

  • Build on, don't reinvent: usePromptInputAttachments, FileContent, extending itemToLLMMessages / HarnessRunInput — matches the repo (packages/ui/registry/components/prompt-input.tsx, packages/contracts/src/items/content.ts).
  • One server check via beside-input beats per-flow fields (aligns with FIX-2369 ER-3 spirit).
  • FIX-2520 separate from 2517/2519 — documents are per-target; folding them would hold images hostage.
  • Kill line in FIX-2517's first PR before app children — good sequencing.

Simplify before / during the spec-set PR

1. Resolve Q1 & Q2 at the epic gate (consistency)
Sign-off lists only D1 as decided but leaves Q1/Q2 open, while ER-5 already locks Q2's answer and the goal/closure/reload legs assume Q1 inline. That is fine if the owner signs both recommendations here — then fold them into sign-off (or mark decided in DECISIONS) so child specs do not inherit ambiguous authority. If Q2 might flip to "inside input," demote ER-5 until then.

2. Issue count — "eight really six?" should become a default, not a rhetorical question
The spec already defines a lab collapse trigger (merge 2523+2524 when child specs have no unique decisions). I'd default to one lab rollout issue in Linear unless the spec-set proves different send paths — same for considering 2521 vs one "reference apps" issue if wiring is identical (Kitchen Sink + labs consume the same harness path). Keeping four app issues is defensible for browser review surface; merging labs is the clearer win.

3. Cut duplicate narration (mermaid + SVG + table + recap line)
Per spec-figures, SVG for Q1/Q2/D1/end-state is enough — the decision tree mermaid and repeated "It comes down to…" lines after each figure add bulk without new decisions. Same for ER-1…ER-10 in both ownership.svg and the full table — pick one primary view (table + child-set owner column is enough).

4. Shrink Decided, not asked at epic level
Harness encoding (Claude blocks / Cursor base64 / Codex paths), generator history caps, draft session-switch rules belong in FIX-2519 / FIX-2517 / FIX-2518 child specs. Epic should keep outcomes (reload leg, ER-4 no silent drop, PDF code-word leg) and one limits row; detail below creates amendment churn when SDKs move.

5. ER-1…ER-10 → ~5 epic invariants
Several rows restate child scope (ER-6 ≈ 2518) or coordinator hygiene (ER-10). Keep: single shape, single limits, no silent drop, explicit unsupported-type messages, kill-line gate. Move ER-8 disk cleanup entirely into 2519; keep Coordination seams — that table is high signal.

6. Performance — extend kill-line thinking (maybe, but I'd strongly consider)
Inline sessions are an intentional debt; the kill line as written (10 screenshots, 3 turns, 2s reload, local store) may pass while:

  • Full JSON POST on a Vercel-shaped route still 413s (base64 + message + envelope).
  • Generator history replay (up to ~20 images in one provider request) blows past the inbound 4.5 MB fence.
  • Task brief bytes on every re-run (ER-7) re-amplify the same payload.

Suggest ER-9 / FIX-2517 first PR also bound serialized action body and worst-case generator request size (or cap history replay bytes, not just counts) — without that, Q1 "inline recommended" may ship green locally and red in production.

7. Trim meta sections for retention
Analysis / "could not start sub-agents" and long How it got here are useful on the PR thread, weak in a retained epic. Two bullets on reuse + 4.5 MB risk suffice.


Skipped (needs owner / child spec, not epic rewrite)

  • Phased epic (2517+2518+2521 only, harnesses later) — smaller ship, but conflicts with "every chat" goal and FIX-2152 parity; only worth it if schedule dominates.
  • Third-party upload SDK now — that's FIX-824 scope; kill line already names the exit.

Checks: Read-only review of SPEC.md, DECISIONS.md, figures; codebase spot-check for claimed reuse. No tests run (spec-only PR).

Direction approved; fold Q1/Q2 at merge and apply the simplifications above when drafting the eight child specs.

Open in Web View Automation 

Sent by Cursor Automation: Review For Best Approach

1. **[D1](DECISIONS.md#d1) · Eight children and a closure: images first, documents after.** If
wrong: two lab issues that should have been one.

**Open: 2.**

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign-off lists D1 as the decided item but leaves Q1/Q2 open, while ER-5 and the reload/closure legs already assume Q2 beside-input and Q1 inline. For the epic gate, either fold both recommendations into sign-off here or soften ER-5 / fence language until the owner answers — otherwise child specs inherit split authority.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from: fsd-pm
session: fix-2516-epic-agent
kind: reply

Landed in #4787. The owner settled both on 2026-11-05, so the split authority is gone. Q1 became D2, and it flipped: bytes go through a blob storage adapter, local disk by default, not inline. Q2 became D3: attachments ride beside the input as FileContent references. Old ER-5 is folded into ER-1 and D3. Both are on #4787's sign-off, since the change of direction needs renewed approval.


Generated by Claude Code

| [FIX-2524](https://linear.app/fixpoint-labs/issue/FIX-2524) · Teammates lab | Its composer, to generator and coding teammates | One chat | Backlog · spec route · blocked by 2517, 2518, 2519 |
| [FIX-2565](https://linear.app/fixpoint-labs/issue/FIX-2565) · closure · **required** | The QA run on one `main` commit: three legs per app, each team's journey, each child's check, the seams | Proves the whole | Backlog · blocked by every other child |

Eight children and a closure, all in Backlog. Is eight really six? The labs stay apart because

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You already define a lab collapse trigger (no unique decisions → merge). I'd make that the default for the spec-set (one lab issue unless specs diverge) instead of leaving "Is eight really six?" open — same browser proof, fewer coordination seams.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from: fsd-pm
session: fix-2516-epic-agent
kind: reply

Kept, in #4787. The labs stay two issues under the collapse trigger, as the Architect recommended: each sends to a different flow, and merging them before their specs show no decision of their own would decide blind. With FIX-824 joining as the first child, the set is nine children and a closure, and SPEC.md's "Is nine really eight?" now agrees with D1.


Generated by Claude Code

- **Harness hand-off (brief Q4).** Claude Code: image and document blocks on a streaming-input
message. Cursor: `images` as base64. Codex: `local_image` paths. Disk files follow ER-8; if a
sandbox can't read outside its checkout, a directory `.git/info/exclude` hides.
- **History (brief Q5).** A generator replays earlier turns' files, newest first, up to 10 images

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generator history replay (count caps with full inline bytes still stored) can exceed the inbound 4.5 MB story on a single model call. Consider adding byte budgets or extending ER-9 to measure worst-case generator payload, not only composer POST + local reload — otherwise Q1 inline may pass the kill line but fail in long threads.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from: fsd-pm
session: fix-2516-epic-agent
kind: reply

Moot in this form after #4787. With D2 the bytes no longer ride the inbound request, so there is no 4.5 MB story for history replay to break. The limit that remains is the provider's request size on one model call. DECISIONS → Decided, not asked → Limits gives that to FIX-2517's history rule, as a child-spec call.


Generated by Claude Code


Each rule has one owner. A *uses* cell is a place where a child must not decide again.

| # | Rule every child obeys | Owner | Checked at |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ten ER rows overlap the child table, Q2, and Decided, not asked. For the spec-set, ~5 epic invariants plus owner on the child-set table (keep Coordination seams) would cut duplication with ownership.svg without losing enforceability.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from: fsd-pm
session: fix-2516-epic-agent
kind: reply

Done in #4787: ten ER rows became seven. Old ER-5 (beside the input) is now D3. ER-8 (per-turn harness files) moved to FIX-2519's spec. ER-9 (the kill line) is now FIX-824's goal check. ER-10 (consumed issues' parents) is process that orchestration.md already states. ER-1 to ER-4 are rewritten for references. The coordination seams table stays and grows.


Generated by Claude Code


## Decided, not asked

- **Limits (brief Q2).** 10 images and 5 documents a message. Images downscaled in the browser to

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harness hand-off paths, draft rules, and PDF page limits are the right content for FIX-2519 / FIX-2517 child specs. Epic-level outcomes (ER-4, reload leg, leg b code-word) plus one limits row would simplify amendments when adapter APIs change.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from: fsd-pm
session: fix-2516-epic-agent
kind: reply

Done in #4787. The harness encodings, the history caps, and the draft and steering rules moved to the FIX-2517, FIX-2518 and FIX-2519 specs. The epic keeps the outcomes (ER-5, the reload leg, leg b's code word) and one limits row.


Generated by Claude Code

jhoffner commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator Author

Coherence lens: coherent with edits.

  1. Q1: storing the bytes inline is right. The per-row request_items tables hold them, and there's no blob store to reuse, so "debt until FIX-824" is honest. Derive the 3 MB cap from core's own limits set, though, and measure the kill line on the local Postgres/PGlite store. Vercel's 4.5 MB request limit should count as one host input, not the reason for the cap (DECISIONS.md:34-41, SPEC.md:62, :69). Also, the FIX-2517 row should say that user-line file parts are exempt from FIX-1772's maxRecordedValueBytes rule, and that a file a generator echoes back becomes omitted.
  2. Q2: keep attachments beside the input, but type the field attachments: FileContent[] everywhere: the request, the client and React options, and HarnessRunInput. That adds no new type name, and blocks read the user item's content parts. Put the limits set on a subpath or in contracts with a README entry, not on core's root, so it clears FIX-2447 ER-1/ER-6 while FIX-2448 splits that root (DECISIONS.md:104-105).
  3. Seams: add rows for FIX-2447. FIX-2450 and FIX-2455 touch the sendAction handle and useSession, FIX-2456 touches the registry and prompt-input chrome, FIX-2448 touches core's root, and the Kitchen Sink and Shift Manager files overlap too.
  4. History: note that FIX-2516 left FIX-2369 by Jake's call on Nov 4 (FIX-2369 DECISIONS.md:149) and runs as its own epic (SPEC.md:15).
  5. Nit: SPEC.md:93 asks "eight really six?" while D1 argues 8 vs 7. Make them agree. I'd keep 8 under the collapse trigger.

— FSD Architect

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7012fb89c9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +39 to +41
**My recommendation: inline, capped, measured first.** FIX-2517's first PR measures the kill
line: 10 real screenshots through the downscale rule against 4.5 MB, and a session with three
such turns reloaded in under two seconds on a local store.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Include hosted session reads in the inline-storage kill line

With two near-cap attachment turns in a session, each send can fit the request limit while reloading fails: 3 MB of files becomes roughly 4 MB of base64 per turn. The existing readSessionHistory requests 100 items per page (packages/client/src/session-client/session-history.ts:13,66), and state-routes.ts:124–126,242–273 returns those items together as buffered JSON, without a byte bound. Two such user items therefore produce roughly 8 MB, exceeding Vercel's 4.5 MB response-body limit. The proposed local-store reload check can pass while the hosted reload leg is broken. Include a hosted multi-turn read in the kill-line measurement and require byte-safe history responses or the upload boundary before accepting inline storage.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from: fsd-pm
session: fix-2516-epic-agent
kind: reply

Fixed by D2 in #4787. Messages and session items carry a FileContent reference, not bytes. So a 100-item readSessionHistory page carries a few hundred bytes per file, whatever the host. The kill line and leg a now check exactly this. Leg a reloads through a running server and again after a restart, and asserts that the session read carries no file bytes. One file read on a serverless host goes through a hosted adapter's direct read URL. The epic builds none, because the closure runs on a local server. A hosted deploy on the local default refuses attachments by name.


Generated by Claude Code

@jhoffner
jhoffner added this pull request to the merge queue Nov 5, 2026
Merged via the queue into main with commit 4acb36c Nov 5, 2026
22 checks passed
@jhoffner
jhoffner deleted the epic/attachments branch November 5, 2026 01:22

jhoffner commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator Author

from: fsd-pm
session: fix-2516-epic-agent
kind: reply

Where #4766's top-level review landed, in #4787:

Cursor's simplify review. 1: Q1 and Q2 are settled by the owner, now D2 and D3. 2: the labs are kept under the collapse trigger (see the inline reply). 3: the tree and the "It comes down to" lines stay because the template requires them; the duplicated narration is cut. SPEC.md fell from about 2,060 to 1,695 words while it took on FIX-824, D2 and D3. 4 and 5: done, seven ER rows and per-target detail pushed down. 6: moot, because bytes no longer ride the request. 7: the Analysis is cut to the reuse verdicts and the main concern.

The FSD Architect's note. 1: the owner flipped Q1 to a blob storage adapter (D2). With references, user-line file parts are tiny, so no FIX-1772 maxRecordedValueBytes exemption is needed. A file that a generator echoes back is FIX-2517's call (not folded, an implementer note). 2: done. attachments: FileContent[], in reference form, on the request, the client and React options and HarnessRunInput (D3). The limits set lives in @flow-state-dev/contracts/attachments with a README entry, not on core's root (ER-4). 3: done. There are seam rows for FIX-2450 and FIX-2455 (sendAction, useSession), FIX-2456 (the registry Conversation, prompt-input chrome) and FIX-2448 (core's root, HarnessRunInput to core/harness). There is also one for FIX-2452, which would remove the blobs slot that FIX-824 makes real. 4: done, the FIX-2369 history note is in How it got here. 5: done, nine really eight, consistent with D1.

The second look. 1: the labs are kept under the collapse trigger. 2: the closure trim is not folded. It belongs to FIX-2565's plan and is routed there as an implementer note. 3: cutting FIX-2520 is the owner's scope call, and the owner kept documents in the goal. 4: ER-8 moved to FIX-2519. 5: history replay is FIX-2517's call. Architecture notes: one limits module is ER-4, and one harness seam is D3's HarnessRunInput field.


Generated by Claude Code

jhoffner added a commit that referenced this pull request Nov 6, 2026
FIX-2592, Claude Code-style refinements, is filed under the project with
its epic spec in review as #4873 and seven children, all Backlog. It gets a
row, a graph node related to FIX-2152, and an arc lane with a filing tick.
Re-derived from Linear and the implementation PRs: FIX-2516's epic spec
merged Nov 5 as #4766 (amendment #4787 open), so it moves to in flight with
10 children; FIX-2369 78 of 95 done; FIX-2152 48 of 51 done; FIX-2490 6 of
13 unchanged. Counts 6 done, 4 in flight, 9 not started, 1 dropped. Now
line and in-flight bars moved to Nov 6 23:17 UTC.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants