Repository navigation
spec(epic): Claude Code-style lab refinements: repositories, one sidebar, a status line, a harness and plan mode (FIX-2592) - #4873
Conversation
…sidebar, a status line, a harness and plan mode Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…2597 behind FIX-2458, the choice rides the task Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture pass (spec PR #4873)Read 1. Split the epic (agree with the PR's own recommendation, and I'd go further)The harness/model/plan legs (FIX-2597/2598/2599) share no decision with the repository legs (FIX-2593/2594). The spec says so itself. They differ in the following ways:
Keeping one set means the closure (FIX-2596) can't run until the slowest leg lands. The repository half is held behind leg d's real-Claude requirement. Suggestion: two epics and two closures. If the owner wants one set, make the closure legs independently reportable, so a leg-d environment problem doesn't block a leg-a pass. 2. ER-1: the lock and the persisted list need one owner of "what is admitted"
3. ER-4 / Q1: the gate should live in the package, not the labER-4 assigns "decided by the transport" to FIX-2594 (the lab). But the epic's own argument is that the registration call is a package capability that grants operator-level access. If the lab is the only place that checks the bind, any other host app built on the package gets an ungated
4. D2: "worktree of the real repository" has an unstated cost
5. FIX-2595 should drop out of the setThe spec already concedes it is "five lines beside a sticky pattern the lab already has" and the one the set could cut. A child with a spec route, a spec PR and a closure leg for a 5-line change is the restraint failure the analysis names. Ship it as 6. Plan sign-off: don't leave the mechanism open past the specFIX-2599 "picks one" of the review stop or the tool-approval hold. ER-10 and the plan leg already depend on it. Recommend deciding in the epic: reuse the existing review stop. Rationale: it is already a user-visible hold with Resolve/Request changes, which matches leg d ("changes asked, sign-off, then work"). A tool-approval hold models a different thing (a single call), and the spec says "no new kind of hold". 7. Smaller notes
VerdictDirection is sound. Highest value changes before merge: (1) split or decouple the closure legs, (2) specify the registry/locking model for runtime registration, (3) put the registration gate in the package, (5) cut FIX-2595 to a quick fix. Generated by Claude Code |
FIX-2592, Claude Code-style refinements, is filed under the project with its epic spec in review as #4873 and seven children, all Backlog. It gets a row, a graph node related to FIX-2152, and an arc lane with a filing tick. Re-derived from Linear and the implementation PRs: FIX-2516's epic spec merged Nov 5 as #4766 (amendment #4787 open), so it moves to in flight with 10 children; FIX-2369 78 of 95 done; FIX-2152 48 of 51 done; FIX-2490 6 of 13 unchanged. Counts 6 done, 4 in flight, 9 not started, 1 dropped. Now line and in-flight bars moved to Nov 6 23:17 UTC. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…nes and excludes, each leg reported alone ER-4 moves to FIX-2593 (registration off unless the host is built to allow it); ER-3 prunes a crashed run's worktree and excludes a concurrent add; the closure reports each leg by itself; SPEC rows match ER-3 on occupancy and Remove; FIX-2597's graph edge and figure no longer carry model lists; debt read slightly up; predecessor anchors made exact. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Code Review ✅ Approved 2 closed / 2 findings🟢 Low risk · The PR adds epic specifications and diagrams only; these document proposed behavior without changing executable code or runtime interfaces. Epic spec for Claude Code-style lab refinements (repositories in Settings, one sidebar, working line, harness and model choice, plan mode) with its decisions and ownership rules. Two prior spec inconsistencies were resolved: Remove no longer reuses setRepository and the in-use lock, and the flow graph and end-state figure now give FIX-2597 the model lists. No open findings remain. ✅ 2 closed✅ Quality: SPEC says Remove reuses setRepository and the in-use lock; ER-3 forbids both
✅ Quality: Flow graph and end-state figure still give FIX-2597 the model lists
VerificationRules No rules evaluated Functional validation Not enabledFor more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
Goal: In the Claude Code-style lab, a person registers a repository once in Settings, starts either kind of session on it from one sidebar, and chooses a harness and one of its models. Where the harness has a plan mode, the person signs the plan off before work starts. Every run uses a git worktree of the real repository.
Four legs, because the repository leg alone passes while the lab still cannot pick a model. The closure issue FIX-2596 runs the check and reports each leg by itself. Today's
mainmust fail every leg.The fence is the cost of the worktree: a run acts with the operator's own access to the repository. The package refuses registration unless the host is built to allow it; the lab allows it by the bind.
Why now. The owner's review of the lab found these gaps together. The pieces exist: FIX-2403's checks are merged, FIX-2369 ER-5 puts a run in a worktree, and FIX-2458's spec gives each harness a model list.
The set: six issues and a closure issue. FIX-2458 and FIX-2585 are consumed, not owned. As of 2026-11-06 all are in Backlog. The spec links to the live state.
Every rule has one owner. Two owners would be a seam. No owner would be a gap.
Sign off
The goal, at that size: four legs, in the browser. If wrong: we ship a lab that adds repositories and still cannot pick a model.
The set's debt: slightly up. The lab loses a switch, a private list, a hand list and a plan worker. The packages gain two entries, one a permanent public call. If wrong: a project row that nobody can delete.
The objective. It serves goals 1 and 4 of
docs/objectives.md, narrowly. It does not move the Phase 1 finish line, except through one new goal in the closure.A run uses a worktree of the real repository, and the package registers one while running · D2
It comes down to where the work lands. If wrong: a run moves a branch the operator did not expect.
Open · Adding a repository in Settings: on at any bind, or only at loopback? · Q1
I recommend loopback only. A signed-in user is not the operator. If wrong: a flag nobody needed.
Open · What does the sidebar call the coordinator group? · Q2
I recommend Coordinators. Workstreams is a Shift Manager palette group. Project Sessions puts project back beside Repository. If wrong: one label changes.
What would change my mind on D2: an operator who refuses a run access to a repository's branches. Reasoning and the rules every child obeys: DECISIONS.md.
Analysis: right approach, with folds. The host now keeps the list of admitted repositories. Removal is refused while a worktree exists. FIX-2597 waits behind FIX-2458. A review moved the registration gate into the package (ER-4). DECISIONS.md → Analysis.
Reviewers · look here
Not here: any single issue's approach. Those are the spec PRs.
Spec · Decisions · Linear FIX-2592 · Project: Workforce: Shift Manager · merges after human approval and required checks
How to review this — an epic-spec, not an implementation plan
This is an epic-spec: the shared objective and cross-cutting decisions for a set of
issues, in a retained document set. It is not any one issue's implementation design, and it
is not a schedule.
In scope to challenge:
SPEC.md— is this body of work worth doing, and is thegoal the real need at full size, or a smaller one the set could meet while the need stays
unmet? Would the closure issue's check fail if the goal were not met?
That question can only be asked here.
SPEC.md— something the set overlaps and doesn't name, or adds anddoesn't list.
piece it considered, or that is a second mechanism for something we already have
(
orchestration.md).DECISIONS.md— shared surface, naming, sequencing, contracts.DECISIONS.md→ Who owns what with no owner, or two.Out of scope — owned by the individual issue specs:
poc/show shape and scoping, not shippable implementation. Directional evidence, experimental
isolation and absence of secrets/generated dependencies remain in scope.
Feedback in the second list is routed to the issue it concerns as an implementer note, not
folded in here.
Required repository checks, approvals and review-thread policy still govern merge.
Optional comments are triaged, not a reason to grind to zero or restart the design review.
🤖 Generated with Claude Code