Repository navigation
Conversation
The epic set for FIX-2615: a host installs MCP servers once as named connectors, a project enables some from that set, a run with no project gets the host's own set, and a key reaches no run, prompt or response. Two features (FIX-2645, FIX-1986), one bug (FIX-2012) and the closure (FIX-2646). FIX-2331 stays a separate epic, with the seam named. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGthqcWLSoHxXN7UFG
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture pass (read-only review of the epic spec)I checked the spec's code claims against 1. The leg-a check can pass for the rejected smaller goal (should fold)Leg a's signal says the worker and run call the tool "with the operator's key". The spec rejects "Teammates gets Linear via an env key" because it hands every user the operator's key. But the control list has no case that tells the two apart. Add a control: a non-operator user with no stored key, outside a project, must get no connector, and the test server must record no call carrying the operator's key. Without it, the smaller goal passes leg a. The spec's own sentence ("its check reads which user's key the server received") needs this case to be true. 2. ER-3 fences the key but not the Codex relay endpoint (should fold into ER-3 or FIX-1986's brief)Codex needs a local endpoint FSD serves. The key never reaches the run, but the endpoint hands key-backed tool calls to anything that can connect to it. ER-3 and the scan do not cover that. Recommend recording as a rule for FIX-1986 now: loopback only, a per-run bearer token, and a closure control that a call without the run's token must fail. This is cheap to write now and expensive to find at the closure. 3. The
|
…ring is a control Fold review comment 4520231144: with one user, a lab-only createMcpCapability with the operator's environment key passed leg a, so the check could not fail for the rejected smaller goal (BP-003). Leg a now has a second Teammates user whose calls must carry that user's stored key, and the lab-only wiring is a control that must fail. Trims SPEC.md and DECISIONS.md prose; no direction change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGthqcWLSoHxXN7UFG
|
I want to see a list of which packages will be updated and what classes/functions we will provisionally build. |
Answers the owner's ask on #5010 for the packages the set touches and the symbols it provisionally builds, each grounded in main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGthqcWLSoHxXN7UFG
|
Here's the list. Every existing symbol is on
Not touched, so the L1/L2 line holds: In the spec at this commit: SPEC.md → Packages and provisional surface Generated by Claude Code |
…h MCP today The Claude Code-style lab has no project or MCP wiring on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGthqcWLSoHxXN7UFG
Code Review ✅ Approved 1 closed / 1 findings🟢 Low risk · The new epic specifications and diagrams document proposed connector and key-handling work without changing executable behavior. Spec for the MCP connectors epic (FIX-2615) defining that a host installs a connector once and runs reach it with the user's own key, with or without a project. Leg a's signal now uses two Teammates users with per-user keys, so the rejected smaller goal can no longer pass it. No open findings remain. ✅ 1 closed✅ Quality: Leg a's signal uses the operator's key, so the rejected goal passes it
VerificationRules No rules evaluated Functional validation Not enabledFor more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
Decision: the MCP key route is owned by FIX-2775 D3 (#5463), which moves it into
|
Owner decision on #5010: the key route moves into @flow-state-dev/workforce under FIX-2775 D3 (#5463). mcpCredentialsAdapter no longer stays in teams/devteam; the Teammates lab imports the workforce route instead of serving a copy (ER-2). New coordination seam with FIX-2775: its move lands first, in connector names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGthqcWLSoHxXN7UFG
|
Folded the key-route decision at 663f69a. I checked #5463 first: its D3 (at 2bd7467) moves the connector keys route into SPEC.md
DECISIONS.md
Linear: FIX-2645's description now says the same thing, and FIX-2645 is linked to FIX-2775 as related. Generated by Claude Code |
|
Architect: key-route fold matches the decision at 663f69a All three asks are in: One open seam, now on #5463: your new seam row says the Teammates lab has no projects flow, so FIX-2775 must shape an export a host without one can reach. #5463's D3 says the route lives inside — FSD Architect |
Requested by Jake · project thread
Goal: a host installs a connector once, and a worker or a coding run reaches it with its own user's key, with or without a project. No key reaches a run, a prompt or a response.
The closure issue FIX-2646 runs this check. Today's
mainmust fail leg a and the scan. A planted canary must make the scan fail. Why this goal.''``The box is the one model every host gets. The fence is the key rule.
Why now. The Teammates lab needs a tracker and has no projects. MCP shipped only through a project, so each new app must choose a side of that gap. FIX-2331 also waits for these definitions.
The set: two features, one bug and a closure. FIX-2645 adds connectors, with or without a project. FIX-1986 adds Codex and Cursor runs. FIX-2012 makes one redaction rule. FIX-2646 is the closure. As of 2026-11-10, all 4 are in Backlog. Live table.
Each rule has one owner. FIX-2645 owns the model and the key path.
Sign off
The goal, at that size: with or without a project, on every harness, with a key scan on every route. If wrong: Codex and Cursor runs still get nothing, or a key leaks on a route that nobody checked.
The set's debt: about flat. The set removes a gate, a relay gap and a rule. It adds one host option, one renamed field and Codex's endpoint. If wrong: the next app copies Kitchen Sink's second MCP route.
These three calls are yours. Each one is my recommendation.
A project is a body of work, and a project with no repository is first-class · D1
D1 trade-off figure: a body of work, recommended, beside a repository and a settings bag.
The deciding row is work without code. A project that must have a repository refuses that work, and you chose to keep it on 2026-10-04. If wrong: the next epic must redraw stored data.
MCP goes to workers' models and to coding runs on every harness, with no project needed · D2
D2 trade-off figure: both, on every harness, recommended, beside coding runs only and workers only.
The deciding row is work that names an issue. With one side only, someone must paste the issue across. If wrong: we build a Codex endpoint that nobody uses.
With no project, the host enables a set of connectors itself · D3
The deciding row is a host that already has projects. If all connectors are on, every Shift Manager conversation outside a project gets Linear, and nobody asked for that. If wrong: one host option to widen later.
What would change my mind: no app we plan has work without code (D1). Nobody runs Codex on project work (D2). A host needs a connector for only some users outside projects (D3). DECISIONS.md.
Analysis: right approach. The pass moved
allowonto the connector so both routes obey it. I ran it in my own context, because this dispatch had no sub-agent. Analysis.Reviewers · look here
Not here: the approach of a single issue. The spec-set PR covers each one.
Spec · Decisions · Linear FIX-2615 · Project: MCP · merges after human approval and required checks
How to review this — an epic-spec, not an implementation plan
This is an epic-spec: the shared objective and cross-cutting decisions for a set of
issues, in a retained document set. It is not any one issue's implementation design, and it
is not a schedule.
In scope to challenge:
SPEC.md— is this body of work worth doing, and is thegoal the real need at full size, or a smaller one the set could meet while the need stays
unmet? Would the closure issue's check fail if the goal were not met?
That question can only be asked here.
SPEC.md— something the set overlaps and doesn't name, or adds anddoesn't list.
piece it considered, or that is a second mechanism for something we already have
(
orchestration.md).DECISIONS.md— shared surface, naming, sequencing, contracts.DECISIONS.md→ Who owns what with no owner, or two.Out of scope — owned by the individual issue specs:
poc/show shape and scoping, not shippable implementation. Directional evidence, experimental
isolation and absence of secrets/generated dependencies remain in scope.
Feedback in the second list is routed to the issue it concerns as an implementer note, not
folded in here.
Required repository checks, approvals and review-thread policy still govern merge.
Optional comments are triaged, not a reason to grind to zero or restart the design review.
https://claude.ai/code/session_01NczDiGthqcWLSoHxXN7UFG
Generated by Claude Code