Skip to content

goals(FIX-2368): the closure re-run on main - #5480

Open
jhoffner wants to merge 4 commits into
mainfrom
fix/FIX-2368-closure-rerun
Open

jhoffner wants to merge 4 commits into
mainfrom
fix/FIX-2368-closure-rerun

Conversation

@jhoffner

@jhoffner jhoffner commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

This PR records the closure check for epic FIX-2367 ("a change reaches every screen"), run on current main.

Verdict: clean. The closure goal passes on main, and each of its four controls fails what its line names. Every child check in plan row 3 also passes on main, and each child control fails the assertions its line names.

The one failure in the first run was FIX-2466's c:fallback-reads. The check had gone stale; the product hadn't regressed. FIX-2846 (#5482, merged) fixed it, and the check passes when re-run on af2cf8116e.

Closure legs and journeys (main)

Assertion Result Numbers
a:org-state PASS 77/27/74/39/34 ms
a:org-row PASS 150/97/94/95/97 ms
a:no-timer PASS B sent 0 requests in 10 s idle; 25 reads while A wrote, 0 unprompted
d:plain-reply PASS 144/135/135/134/133 ms
d:no-timed-read PASS p2 logged 0 statements naming a watched session in 10 s idle
c:refused PASS 1 mint, 0 granted, 0 notices heard
c:other-org-silent PASS 0 reads, 0 changes
c:reconnect-refused PASS 1 re-mint, 0 granted; the reply showed in 435 ms
b:settles PASS 42/35/26/37/25 ms
b:no-read-between PASS 56 reads in 10 s, 0 without a notice
j2:no-poll (Shift Manager) PASS 0 requests in 10 s on all three screens; 0 statements naming the conversation
j2:message (Shift Manager) PASS 201/225/188/201/186 ms after send
j3:worker-reply PASS 184/136/137/144/131 ms
j3:no-timed-read PASS 0 statements naming the session
j4:polls PASS push null; 1879–3020 ms (bound 4000); 0 sockets

Closure controls

Control Must fail Failed
memory-bus a:org-state, a:org-row both: B never updated. Also d:plain-reply and j3:worker-reply
no-request-publish d:plain-reply (and j3), with leg a passing both, and leg a passes. Also j2:message, which its line now names, plus a side effect on c:reconnect-refused's floor
skip-check c:refused c:refused, c:reconnect-refused
main-before every a: assertion, b:no-read-between all of them, plus d, c, j3, b:settles, j2

Plan row 3: the children's checks

Child Main Controls
FIX-2426 session-stream/wakes-on-a-change PASS no-publish fails a:reply, a:run
FIX-2427 session-stream/wakes-across-processes PASS no-listen fails 1, 3, 4 · trust-listen fails 3:drop, 3:back · no-bus fails 1, 3, 4, as its line now says
FIX-2428 realtime/websocket-delivery PASS no-socket, skip-check, ignore-crossing each fail what their lines name
FIX-1506 realtime/scope-changes-reach-other-sessions PASS no-publish fails a, b, c · no-origin fails d:reads-as-plain
FIX-2429 task-board/a-settled-task-reaches-the-board PASS whole-topic fails a:0-reads · tasks-only fails a:plan-step
FIX-2466 realtime/app-views-read-on-notice PASS on af2cf8116e: task screen 0 board reads over 10 s waiting, link 77 ms; with no crossing bus, the link showed in 57 ms and the screen made 2 reads over 6 s timer fails a:idle-0-reads · every-kind fails b:as-short (144/145/145 reads against 6/6/6)

What this PR changes

All the changes are goal text. No runner or product code changes.

Not graded: shutdown noise. When process 2 restarts, the server logs "Cannot use a pool after calling end on the pool". Every assertion around that restart passed.

No changeset: goals is private.

🤖 Generated with Claude Code

https://claude.ai/code/session_011UNkLEJU1iqxFYoPadTRfn

RetriggerView in GreptileConfidence Score: 5/5

This documentation-only PR appears safe to merge.

Summary

This PR updates the saved realtime check results and corrects two control descriptions. It changes no runtime code.

  • The closure goal records its latest full run and control results.
  • The task screen gets a three-second fallback window in the goal.
  • The no-bus control now checks delivery instead of idle reads.

Acknowledged by jhoffner: the earlier fallback failure came from a stale read counter and is superseded by the corrected run; wider control failures are expected because those screens share the session stream; pool-close errors during shutdown were not graded. No new actionable issues found.

Reviews (1) · Last reviewed commit: "goals(FIX-2368): FIX-2466 passes on main..." · Reviewed by Greptile

On 803d3a6 the closure check passes every leg and journey (a, b, c, d,
j2 on Shift Manager, j3, j4) and each control fails where its line says.
Plan row 3: five children pass with their controls; FIX-2466's check fails
c:fallback-reads on main (Shift Manager's task run link makes no read while
it waits on a host with no crossing bus).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UNkLEJU1iqxFYoPadTRfn
@vercel

vercel Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flow-state-dev-build-site Ready Ready Preview Nov 19, 2026 11:40pm UTC
flow-state-dev-docs Ready Ready Preview Nov 19, 2026 11:40pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
flow-state-dev-ui Ignored Ignored Preview Nov 19, 2026 11:40pm UTC

Request Review

@linear-code

linear-code Bot commented Nov 19, 2026

Copy link
Copy Markdown

FIX-2368

@gitar-bot

gitar-bot Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Note

Automatic reviews are paused because your team has used its included automatic processing for this billing period (headroom scales with your seat count). You can still comment "Gitar review" to run one anytime, and automatic reviews resume on their own by December 1. Add seats for more headroom.
Learn more

Code Review ✅ Approved 🟢 Low risk

The change adds closure-run results and failure notes to a goal document; it changes no executable behavior or operational authority.

Re-runs the FIX-2368 closure check for epic FIX-2367 against current main after FIX-2841 and FIX-2842 merged, with the goal's assertions and controls exercised on the goals fixture. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

Was this helpful? React with 👍 / 👎 | Gitar

Copy link
Copy Markdown
Collaborator Author

@codex review

What I'm unsure of: whether the verdict rows and the two updated control lines describe each control's actual failure accurately. The updated lines are no-request-publish also failing j2:message, and FIX-2427 no-bus now failing on delivery rather than 2:idle. Also, whether recording the FIX-2466 child FAIL as an open finding, tracked as FIX-2846, is correct rather than a verdict to change.


Generated by Claude Code

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T21:32:34.873432Z 55d12a5 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 55d12a52f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…st-publish row matches its line

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UNkLEJU1iqxFYoPadTRfn
… states the 3 s pace

Merges main. Records the FIX-2466 re-run on af2cf81 (PASS, both controls
FAIL as named) and fixes the app-views goal's c:within-poll line to
3 s + 1 s, matching RUN_LINK_POLL_MS + BOUND_MS (Codex and Greptile on #5482).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UNkLEJU1iqxFYoPadTRfn

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/simplify review

Macro: This is the right shape for a closure record: goal text only, no runner churn, child contract fixes where drift was real (no-bus after FIX-2545, c:within-poll after FIX-2776 / FIX-2846, no-request-publish naming j2:message). The heavy part is deliberate — FIX-2368’s spec asks for the closure PR body and verdict-log evidence on one main commit with every child beside its controls. I don’t see a simpler approach that still satisfies that without dropping audit detail.

Did the approach go too far? Mostly in volume, not direction.

  • Plan row 3 meg-rows (lines 52–58) duplicate tables already in the PR description and are unique in the repo (no other goal.md inlines six child summaries). That’s defensible as a single closure artifact, but it’s the main complexity smell: two canonical narratives (PR body + parent table) and child goals that don’t get matching verdict rows in this diff (e.g. FIX-2466 PASS on af2cf8116e lives only here, not in app-views-read-on-notice/goal.md).
  • Keeping row 57 (FAIL at 803d3a685) plus 58 (supersedes) is honest history; a single amended row would be shorter if you ever want to trim.

Cleaner alternatives (optional, not blockers):

  1. Thin closure log: One PASS row + four closure-control FAIL rows on the closure commit; point Plan row 3 at the PR section or children.mts output instead of seven long Notes cells.
  2. Push child outcomes home: Log FIX-2466’s re-run in app-views-read-on-notice/goal.md; keep the closure goal to closure legs/controls only.
  3. Follow-up on FIX-2427: Controls (line 19) are correct; verdict rows from 2026-11-03 still say no-bus FAILs 2:idle with 80 statements — a short “control drift” row or note would stop the next hand-run from reading stale law.

Earlier Codex threads: P1 (hold for FIX-2846) is addressed by row 58 on af2cf8116e; no-bus and no-request-publish wording fixes match current HEAD.

Skipped (larger than this PR): Automating verdict append from the closure worker; third-party tooling wouldn’t simplify much here — the issue is where evidence lives, not parsing markdown.

Verdict: Approve. Closure is clean on the recorded commits; remaining feedback is maintainability / DRY on goal docs, not correctness.

Open in Web View Automation 

Sent by Cursor Automation: Review For Best Approach

| 2026-11-19 | 803d3a685 | n/a | FAIL (expected) | `no-request-publish`: `d:plain-reply`, `j3:worker-reply` (never in 6 s); a passes (plan 63/40/33/41/34, seat 108/90/102/98/90 ms). Also fails `j2:message` (never in 6 s; the store ended each request 26–50 ms after sent) and `c:reconnect-refused`'s floor (A's view on the restarted p2 never showed the reply): both follow the session stream, which the patch silences; the control line now names `j2:message`, and the reconnect floor is a side effect it doesn't grade |
| 2026-11-19 | 803d3a685 | n/a | FAIL (expected) | `skip-check`: `c:refused` (granted, 94 notices heard) and `c:reconnect-refused` (granted again, 7 notices) only |
| 2026-11-19 | 803d3a685 | n/a | FAIL (expected) | `main-before` (db498b976, the cached extract; its `packages/` diff-clean against `git archive db498b976`): `a:no-timer` (no crossing frame), `a:org-state`, `a:org-row` (never in 6 s), `b:no-read-between` (8 reads, 0 notices); also `d:no-timed-read` (80 statements), c's three (no mint answer to read), `j3` (945–1036 ms, 40 statements idle), `b:settles` (2045–3023 ms), `j2:no-poll` (6/2/2 requests, 12 statements), `j2:message` (1682–3516 ms). j4 not run, by design |
| 2026-11-19 | 803d3a685 | n/a | PASS · controls FAIL (expected) | Plan row 3, FIX-2426 (`session-stream/wakes-on-a-change`): b 0 statements in 10 s idle; a reply 106 ms, run 101 ms; c 468 ms. `no-publish` FAILs `a:reply`, `a:run` only |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(suggestion, not blocking) These Plan row 3 rows are the only place in goals/ that embed full child check + control matrices. If verdict-log growth becomes painful, consider one closure row that links to the PR’s child table (or automation output) and leave per-child meg-rows in each child goal.md instead.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not changing this here. FIX-2368's spec asks for exactly this layout: every child's check beside its controls, recorded against one main commit in the closure goal's verdict log. Moving those rows into each child's goal.md would change what the spec asks for, which belongs in a spec amendment, not a closure record. Your point about the log growing is fair, and it's worth raising at the epic retrospective.


Generated by Claude Code

- `GOAL_CONTROL=no-listen` — the bus never `LISTEN`s but says it crosses (a scratch patch to `packages/store-postgres/src/bus.ts`). Must FAIL `1:reply`. It fails `3` and `4` too: the patch says "crosses" with no tail pool as well.
- `GOAL_CONTROL=trust-listen` — the bus trusts a `LISTEN` that succeeded: no ping, and a lost connection changes nothing. Must FAIL `3:drop`.
- `GOAL_CONTROL=no-bus` — today's `main`: the Postgres adapter declares no `bus`, so each process gets an in-memory one (a scratch patch to `packages/store-postgres/src/registry.ts`, where `postgresStores` declares its slots). Must FAIL `2:idle`: process 2's two views read the store 4 times a second each.
- `GOAL_CONTROL=no-bus` — the Postgres adapter declares no `bus`, so each process gets an in-memory one (a scratch patch to `packages/store-postgres/src/registry.ts`, where `postgresStores` declares its slots). Since FIX-2545 the in-memory bus says it crosses, so the views keep no timer and `2:idle` logs 0 statements. Must FAIL on delivery: `1:reply` and `1:run` (p2 never hears p1), `3:drop` (no listening backend to terminate), `3:back`, and `4:no-tail`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Controls here are aligned with FIX-2545. The Verdict log below still has 2026-11-03 rows saying no-bus must FAIL 2:idle with 80 statements. Worth a follow-up row or a one-line note above the table so hand re-runs don’t treat that history as current contract.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving the 2026-11-03 rows as they are. A verdict row records what a control did on that date, and no-bus did log 80 statements before FIX-2545. The control line above the table is the current contract, and since this PR it names today's failures. If FIX-2427's goal is run again later, its own new row will show the current behaviour, which is clearer than editing old history.


Generated by Claude Code

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No security findings.

This diff is three goal contracts and their verdict logs. No route, principal resolver, store key, mint, tool, or egress path changes. The runners that enforce the assertions below are not in the diff; I read them to check the contract text did not drop a guard they still apply.

1. Identity and authorization. Touched only as recorded results. c:refused, c:other-org-silent, c:reconnect-refused, and GOAL_CONTROL=skip-check are unchanged. The new PASS row still has user C at 0 grants and 0 notices, and org 2's board at 0 reads while org 1 is written. skip-check still fails both c:refused and c:reconnect-refused (mint grants the session, notices are heard). The new no-request-publish note that it does not grade c:reconnect-refused's floor is the owner's own view on the restarted process (tell.over of A's reply latency in run.mts), not C's grant. The refusal checks (reGranted, notices after restart, C's page) are separate failures.push calls and still run; the unpatched and skip-check rows show they fired.

2. Data segmentation. Same goals. Session viewing stays the owner's alone; the other-org board stays silent. No new key, list, or stream topic.

7. Timing / fallback. c:within-poll for the task-screen run link moves from 2 s + 1 s to 3 s + 1 s. That matches RUN_LINK_POLL_MS = 3_000 already in goals/realtime/app-views-read-on-notice/run.mts (useView's default after FIX-2776). c:fallback-reads still requires a read inside 6 s when the bus does not cross. The no-bus control text now expects missed delivery (1, 3, 4) instead of a polling 2:idle failure, which is the in-memory bus claiming crosses since FIX-2545. 4:no-tail is unchanged: an honest non-crossing bus still has to deliver on the timed read.

Sections 3 (source gate), 4 (model-facing text), 5 (harnesses), 6 (SSRF), and 8 (supply chain / CI) are not touched.

Open in Web View Automation 

Sent by Cursor Automation: Security Review

This branch was successfully deployed

1 active deployment
Preview – flow-state-dev-docs — 7b59a7c3 Deployed Nov 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants