Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync code from spark master #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Sync code from spark master #3
Changes from 1 commit
ff14801cdcccd734811e0119f6a00b6cead3a4d15e707e650487377e9e26473dea381d486f99ea89cdf57965c91269cd532ce37b542cf48e5ff72ffa366b95947b4e64586ead98a5c0aba622f4b0f422cf2cab5650857397706eeaf6b49f98c5b34cad640a5e8a259d8bceb894c587eb04e71c333c2cb2aff7d8153561d2c99fc9aac76eff77c91ccfe22f329bb239cd6632d12cb23a87013eea92e7ecb3be4adfea48099e7bbca8d90e77b2c367362ca9bb010b06571a54f48b6f837cb304e07d5b41ae567bd3123370559ddd1e2918fb9b1098933279b3db4f5bad67c3e89956e8f4815c3c98761889618f85753675af7c2632edca83526c9520005414abcdffeac388d8de99945b02bd201bf8a727348a1efe361487b3745c8c04de638cf15906d5f4deff56632185e7bc2a7f5e8aa2c4b996477d6bd983e8d9500b21cbf09f2f8d7911398d0ea3918c7e92b89e4aa091ee60604bea95e51ff5c9eaa64d37008a649fcfb2edc305fa438492e95256ac4fba8b56f16cb43bbe95c03cba336553816a5495f653d4e4bec7ca9350d7087fb31eb48edfb30a7d23e778f535997b5c68ec4eed72bad34c4b9c761565aea2fdc0641aec6505480c491ec11a7755fdb348901df05fb6b02e76c5b5a36ebc8d093ae9172015298b9529f84744a9f8e6151f29fe2b7a4a7c19d928ea4e3a135182441d0d08020f667cf9fab66a3a5a1035aaa359375e5cfd5fa16ef6ba5197562a355236cccaaa1d8379e5d3bd043c5c8b541822ecdb2329fbd9ca1c94807d38f2ac087d65e531249007e6ade5cb9452401d766ea2c926acfd23a805b6935ffe9982506ab134c2c1fe646a73457710a68c8d40a7932471bad81f29e10f45bb7c1654e252468a61b7247f94f362649888495034af3323b15e179658adb222b4f1e8b97c7570dc7622be87611bbc604d65271c891653fe023cb820475a18309d960dee904dfa6a2289e0b191220f93b91682002b14291b0ab7b9611018be44b070360323e61a83ae0d4dfd74625892f3558f31bcbb41a073f2853c0964936931022083cf2250037360461482fd990a914844a61cc66a005ae74730ffb530a9172aed4101d3990daaf39e82c1ca3c505fccdae1e3b876310a8cdcce4694f81fa47f09a9e9a9066470c94e488bb0df2d5bec4846bb2b51b08c43e1341659e10f69d96c3e30deaa526e19f76a4718809ea8d3de55953bb3fde5ae6b4660File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
… to starting with 'org.slf4j' ## What changes were proposed in this pull request? isSharedClass returns if some classes can/should be shared or not. It checks if the classes names have some keywords or start with some names. Following the logic, it can occur unintended behaviors when a custom package has `slf4j` inside the package or class name. As I guess, the first intention seems to figure out the class containing `org.slf4j`. It would be better to change the comparison logic to `name.startsWith("org.slf4j")` ## How was this patch tested? This patch should pass all of the current tests and keep all of the current behaviors. In my case, I'm using ProtobufDeserializer to get a table schema from hive tables. Thus some Protobuf packages and names have `slf4j` inside. Without this patch, it cannot be resolved because of ClassCastException from different classloaders. Author: Jongyoul Lee <[email protected]> Closes apache#20860 from jongyoul/SPARK-23743.Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing