Update Joplin to 3.4.12

[generic-pers0n]

This PR updates Joplin to 3.4.12, which is the latest version at this time. It is in response to #283 to ensure that the version of Joplin packaged here is at the latest version.

Note: if preferred, I am willing to take over maintenance of it because I actively use Joplin for my school notes. At least, I can take over maintenance until an official developer decides to take it over. I say this because it appears that there might be a backlog of work, and since I use Joplin on a daily basis, I can assist with getting some of this work done.

[flathubbot]

🚧 Test build enqueued.

[flathubbot]

🚧 Started test build.

[flathubbot]

❌ Test build failed.

Help

• bot, build - Restart the test build
• bot, ping admins - Contact Flathub admins

[MarSik]

You have to update the checksum too.

[generic-pers0n]

You have to update the checksum too.

Ah, I forgot about that. I just quickly made this PR.

I'll do that soon. Thanks for the catch! 😄

[flathubbot]

🚧 Test build enqueued.

[flathubbot]

🚧 Started test build.

[flathubbot]

❌ Test build failed.

Help

• bot, build - Restart the test build
• bot, ping admins - Contact Flathub admins

[ndsvw]

Hi,

• flatpak-builder --allow-missing-runtimes --force-clean --sandbox --download-only builddir net.cozic.joplin_desktop.yml
  error: org.freedesktop.Sdk/x86_64/24.08 not installed
  error: org.freedesktop.Sdk/x86_64/24.08 not installed
  error: org.freedesktop.Platform/x86_64/24.08 not installed
  error: org.electronjs.Electron2.BaseApp/x86_64/24.08 not installed

Do you already know what is causing the error?

I'd love to get a new release, because a plugin I am trying to use requires it.

BTW: Would it even be possible to merge the PR without @catsout, who has done it in the past, but is not as active as before in this project?

[generic-pers0n]

Hi,

• flatpak-builder --allow-missing-runtimes --force-clean --sandbox --download-only builddir net.cozic.joplin_desktop.yml
  error: org.freedesktop.Sdk/x86_64/24.08 not installed
  error: org.freedesktop.Sdk/x86_64/24.08 not installed
  error: org.freedesktop.Platform/x86_64/24.08 not installed
  error: org.electronjs.Electron2.BaseApp/x86_64/24.08 not installed

Do you already know what is causing the error?

On your end, you need to install the appropriate runtimes. Do flatpak install org.freedesktop.Platform/x86_64/24.08 and you should be good to go.

On the builder's end, I think it's because I haven't updated the dependencies here. Once I figure that out (provided I have the time to do so because I'm a little busy right now), I'll update this PR accordingly.

I'd love to get a new release, because a plugin I am trying to use requires it.

BTW: Would it even be possible to merge the PR without @catsout, who has done it in the past, but is not as active as before in this project?

I'm not sure if there is, but hopefully they see this PR and merge it once it's ready! 😄

[personalizedrefrigerator]

For the yarnpkg-related build failure (line 1442 in the build log):

Running: yarn convertToZip $(which yarn)
Internal Error: Invalid configuration key "lockfileFilename"
    at t.get (/run/build/joplin/.yarn/releases/yarn-4.9.2.cjs:147:24090)
    at convertToZipCommand.execute (/run/build/joplin/.yarn/plugins/flatpak-builder.cjs:133:73)
    at async convertToZipCommand.validateAndExecute (/run/build/joplin/.yarn/releases/yarn-4.9.2.cjs:94:787)
    at async t.run (/run/build/joplin/.yarn/releases/yarn-4.9.2.cjs:98:3263)
    at async C6t (/run/build/joplin/.yarn/releases/yarn-4.9.2.cjs:752:7977)
    at async KR (/run/build/joplin/.yarn/releases/yarn-4.9.2.cjs:753:142)

This seems to be related to this line in a custom Yarn plugin:

// Line 133 in flatpak_node_generator/flatpak-yarn.js
        const lockfilePath = ppath.join(this.context.cwd, configuration.get(`lockfileFilename`));

Joplin 3.4.x uses Yarn v4, which no longer includes the lockfileFilename configuration option. A different Yarn plugin seems to have resolved this by replacing configuration.get(`lockfileFilename`) with 'yarn.lock'.

Note: The flatpak-yarn.js file seems to live in the yarn2 branch of this fork of flatpak-builder-tools (catsout/flatpak-builder-tools).

Edit: See this comment for a possible workaround.

[flathubbot]

🚧 Test build enqueued.

[flathubbot]

🚧 Started test build.

[flathubbot]

❌ Test build failed.

Help

• bot, build - Restart the test build
• bot, ping admins - Contact Flathub admins

[generic-pers0n]

It looks like we may also have to change flatpak-builder-tools to the upstream version because of what appear to be new linter rules. (At least, I haven't seem them before). The current version appears to be a fork that adds Yarn 2 support.