Use builtin harfbuzz to workaround GDExtension crash #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Started test build 184476 |
Contributor
|
Build 184476 successful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since godotengine/godot#100052 is merged in v4.4, we can now configure linux dependency modules independently.
Currently Godot has a bug (godotengine/godot#91401) that if the engine is using system-provided harfbuzz library, it will crash when GDExtension libraries call
std::call_onceduring static initialization. Libraries with such pattern are including but not limited to Tensorflow/Protobuf-based projects, GDExtension libraries with these dependencies will always crash flatpak Godot unless builtin harfbuzz is used.This PR remove the
builtin_harfbuzz=nofrom Scons flags, making the editor to use builtin harfbuzz instead of system-provided one from Freedesktop SDK/Platform. The editor executable size increase in my testing is from139.2 MiB (145,966,624)to139.9 MiB (146,660,800)which is acceptable at the scale of flatpak apps IMO.