Skip to content

add keep-build-dirs flag #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ranfdev wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add keep-build-dirs flag #229

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d32e3f5
keepBuildDirs flag
ranfdev Aug 19, 2025
6d3b3c2
dist
ranfdev Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
dist
  • Loading branch information
@ranfdev
ranfdev committed Sep 25, 2025
commit 6d3b3c208261312d94f5154c566b1aa6359895e8
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ If you plan to contribute to flatpak-github-actions, here's a couple of things t

For more details, we recommend looking the extensive guide at [Creating a JavaScript action](https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#prerequisites)

Once you have modified the `index.js` of either `flatpak-builder` or `flat-manager` action. Make sure to compile the file to the `dist` directory. You can do so with
Once you have modified the `index.js` of either `flatpak-builder` or `flat-manager` action, make sure to compile the file to the `dist` directory.
Note: You should have already installed the npm packages of both `flatpak-builder` and `flat-manager`, with yarn.
Copy link
Member

@bilelmoussaoui bilelmoussaoui Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not needed, no? you just need to do a build

Copy link
Author

@ranfdev ranfdev Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If those packages aren't in the node_modules folders, they don't get included in the bundle and the ncc bundler doesn't even print a warning. At least that's what happened in my case 🤷🏻, feel free to remove it if you can't reproduce


```shell
ncc build ./flatpak-builder/index.js -o ./flatpak-builder/dist/
Expand Down
5 changes: 5 additions & 0 deletions flatpak-builder/dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ class Configuration {
this.mirrorScreenshotsUrl = core.getInput('mirror-screenshots-url')
// The key to sign the package
this.gpgSign = core.getInput('gpg-sign')
// Keep build directories after the build (pass --keep-build-dirs)
this.keepBuildDirs = core.getBooleanInput('keep-build-dirs')
// Modified manifest path
this.modifiedManifestPath = path.join(
path.dirname(this.manifestPath),
Expand Down Expand Up @@ -232,6 +234,9 @@ const build = async (manifest, manifestPath, cacheHitKey, config) => {
`--default-branch=${branch}`,
`--arch=${config.arch}`
]
if (config.keepBuildDirs) {
args.push('--keep-build-dirs')
}
if (config.cacheBuildDir) {
args.push('--ccache')
}
Expand Down