Adding support for events during animation #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There're many issues that would be solved by simply passing the settings object straight into jQuery.animate, I'll get on with this when I get back from vacations and solve all these issues at once. |
ghost
assigned
|
It may not be directly related but it would be nice if the animation is cancelled when the user tries to manually scroll during scroll animation. |
|
Three open issues can be closed by passing the object directly but need a slight different code than yours, tried to implement it but find there's a conflict with the setting "queue". I'll try to nail this asap. |
|
Made possible on 2.0 via #109, thanks for helping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a situation yesterday where I needed scrollTo to fire an event to update an object as the scroll was occurring (so I could change an element from fixed position to absolute positioned)
I added support to the settings object to take in onProgress which is supported in jQuery as of 1.9.