-
-
Notifications
You must be signed in to change notification settings - Fork 432
Allow passing multiple actors to Flipper.enabled? #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeepers
reviewed
Mar 19, 2023
Collaborator
Author
|
Forgot to drop here that checking 5 actors at once vs 5 enabled checks with 1 actor each is like 5x faster so that's good! |
bkeepers
approved these changes
Mar 20, 2023
thing was being instrumented before even as nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
The biggest benefit is not re-running all the gates and instrumentation for every actor and every gate. Instead this runs the boolean and & of time once. Then it just checks multiple actors in the actor, % of actors and group gates.
I'm going to give this another pass to see if anything needs to change back or not.