Fix a bug which broke the battery charging flow from solar #833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dpayk
added a commit
to dpayk/power-flow-card-plus
that referenced
this pull request
Oct 7, 2025
flixlix
approved these changes
Dec 1, 2025
Owner
flixlix
left a comment
flixlix
left a comment
There was a problem hiding this comment.
sorry for the late review, I've been very busy and have only now found some free time for this project.
I've tested this PR and tried replicating the issue at #830 using fake sensors. This is the result:
Before:
https://github.com/user-attachments/assets/4e200c2d-62f5-4d0d-b44f-e7b1a75b592a
After:
https://github.com/user-attachments/assets/3ab12330-ff36-4641-81c7-c6e43166c809
So, in this case, everything seems to be fixed. Thank you very much for your contribution! ❤️
I will be merging this for 0.2.6
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (hopefully) a few issues related to power flow from grid to battery and solar to battery. I might have introduced the bug in my previous PR #742. I don't have a way to test my changes, but perhaps others who are having the issues can check.
fixes #782
fixes #795
fixes #830