Skip to content

New module for live backgrounds #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phlash merged 9 commits into from
Aug 30, 2021
Merged

New module for live backgrounds #100

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
83d20bd
New module for live backgrounds
phlash Aug 18, 2021
faa27a8
bug fixes: work with blocking input streams, retain last frame if bac…
phlash Aug 18, 2021
6848e93
review follow up: std:chrono for timing, std::shared_ptr for memory s…
phlash Aug 18, 2021
a5a50a0
review followup: use shared_ptr custom deleter to manage background t…
phlash Aug 21, 2021
bfd3759
review followup: readability
phlash Aug 21, 2021
ccd74d2
review followup: cleaner wait mechanism in background videos
phlash Aug 21, 2021
9407bb2
review followup: remove unnecessary lambda
phlash Aug 21, 2021
60392f9
bug fix: only show background thumbnail if double debugging
phlash Aug 23, 2021
b76ab71
Merge branch 'experimental' into live-backgrounds
phlash Aug 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review followup: remove unnecessary lambda
  • Loading branch information
@phlash
phlash committed Aug 21, 2021
commit 9407bb2b03e6d2bf8eedb93fbd2d0ef810a60203
2 changes: 1 addition & 1 deletion app/background.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ static void drop_background(background_t *pbkd) {

std::shared_ptr<background_t> load_background(const char *path, int debug) {
// allocate a shared pointer around storage for the handle, associate custom deleter to clean up when eventually released
auto pbkd = std::shared_ptr<background_t>(new background_t, [](background_t *p) { drop_background(p); });
auto pbkd = std::shared_ptr<background_t>(new background_t, drop_background);
try {
pbkd->dbg = debug;
pbkd->vid = false;
Expand Down