Add program option to explicitly show the progress bar#53
Merged
Conversation
BenBE
requested changes
Feb 24, 2021
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
BenBE
approved these changes
Feb 24, 2021
Collaborator
|
Looks good to me, merging. @cristicc FYI we are looking to refactor the debug/display parts in the experimental branch, along with more dynamic controls (on/off, flip, resize, change camera devices...) that would be useful in a live presentation situation where we cannot drop and restart the virtual camera, thus we cannot restart this app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added an option
-pto enable explicitly the display of the dotted progress bar, by default it won't be shown.The rationale is that, with this feature always enabled, it will pollute the terminal where the program was launched without bringing much value. For monitoring the activity I think
-d(given one time) is a better approach, anyway.Additionally, I have updated the usage info to group width & height options under a single optional expression (i.e.
[-w <width> -h <height>]) since they cannot be used separately.Thanks for the great work,
Cristi