-
Notifications
You must be signed in to change notification settings - Fork 545
Updated for new api endpoints and missing config options for vivo exporter output plugin docs. Fixes #2217. #2224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated for new api endpoints and missing config options for vivo exporter output plugin docs. Fixes #2217. #2224
Conversation
…orter output plugin docs. Signed-off-by: Eric D. Schabell <[email protected]>
…orter output plugin docs. Fixes #2217. Signed-off-by: Eric D. Schabell <[email protected]>
|
Warning Rate limit exceeded@eschabell has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 2 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughDocumentation for the Vivo exporter was updated to reflect new API endpoints under Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
pipeline/outputs/vivo-exporter.md (2)
12-12: New configuration parameters added, but usage examples would improve clarity.The new
hostandportparameters are documented with defaults, but the "Get started" configuration examples (lines 25–38, 43–55) don't demonstrate these parameters. While defaults may be suitable for most users, adding at least one example showing how to override the host/port binding would help users understand when and how to use these settings.Consider adding a configuration snippet that explicitly sets
hostandportto make the feature more discoverable.Also applies to: 14-15
184-216: The new groups section lacks clarity on triggering conditions and usage.The "Log output format with groups" section introduces the JSON structure for OTLP and non-OTLP grouped output, but important context is missing:
Unclear triggering conditions: There is no explanation of what configuration or conditions cause the
otlporflb_groupfields to appear in the output. Is this automatic based on input type? Is a configuration option required?No configuration or invocation examples: The section shows hypothetical JSON structures but doesn't explain how to actually produce this output (e.g., no curl examples or configuration snippets showing group setup).
Vague terminology: The phrase "group metadata or attributes" is not defined in relation to Fluent Bit concepts.
To align with the PR objective of "adding support for groups," please clarify:
- Under what conditions groups appear in the output
- Any new configuration options needed to enable group support
- At least one curl example demonstrating grouped output retrieval
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pipeline/outputs/vivo-exporter.md(5 hunks)
🔇 Additional comments (1)
pipeline/outputs/vivo-exporter.md (1)
70-75: API endpoint updates are clear and consistent.The endpoint table has been properly updated to reflect the new
/api/v1/prefix, and the curl examples throughout the document (lines 116 and 165) are consistently updated. The addition of the/api/v1/internal/metricsendpoint is well-documented.
…s on groups. Signed-off-by: Eric D. Schabell <[email protected]>
…s on groups. Signed-off-by: Eric D. Schabell <[email protected]>
Signed-off-by: Eric D. Schabell <[email protected]>
|
AI review passed, merging. |
|
@esmerel would you mind a post merge PR review here? |
Updated for new api endpoints and missing config options for vivo exporter output plugin docs. Fixes #2217.
Summary by CodeRabbit
New Features
/api/v1/internal/metricsAPI endpoint availableDocumentation
/api/v1/logs,/api/v1/metrics,/api/v1/traces)✏️ Tip: You can customize this high-level summary in your review settings.