-
Notifications
You must be signed in to change notification settings - Fork 1.8k
trace: add new command line options for enabling tracing at startup. #6726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9edcb7c to
a8ff97f
Compare
Syn3rman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few comments and requested a few changes. We are ignoring the return values from all the functions and while I have pointed out only one instance, we do need to check it everywhere.
|
@pwhelan please let me know once you have addressed these requests widely in the code. I've noticed many places where the results are not being checked but it makes no sense to point anything out before you have a chance to go over your changes and fix it. |
|
Valgrind log: |
a8ff97f to
1074297
Compare
9f25d96 to
b5fa1bb
Compare
Signed-off-by: Phillip Whelan <[email protected]>
Add new command line options to enable tracing from the start: * --trace: define a complete trace pipeline in a single line. * --trace-input: define the input to trace. * --trace-output: define the trace output. * --trace-output-property: define a trace output property. Signed-off-by: Phillip Whelan <[email protected]>
Signed-off-by: Phillip Whelan <[email protected]>
* free up memory used when parsing '--trace' option.
* add flb_start_trace() which avoids setting the global
fluent-bit context.
Signed-off-by: Phillip Whelan <[email protected]>
79a7de0 to
5311fa8
Compare
|
Here is a valgrind log after the latest changes: |
|
@pwhelan do you have a PR for docs ? |
@edsiper not yet, open one ASAP. |
Document the new trace command line options introduced by fluent/fluent-bit#6726. Signed-off-by: Phillip Whelan <[email protected]>
Document the new trace command line options introduced by fluent/fluent-bit#6726. Signed-off-by: Phillip Whelan <[email protected]>
…luent#6726) Add new command line options to enable tracing from the start: * --trace: define a complete trace pipeline in a single line. * --trace-input: define the input to trace. * --trace-output: define the trace output. * --trace-output-property: define a trace output property. Signed-off-by: Phillip Whelan <[email protected]>
…6726) Add new command line options to enable tracing from the start: * --trace: define a complete trace pipeline in a single line. * --trace-input: define the input to trace. * --trace-output: define the trace output. * --trace-output-property: define a trace output property. Signed-off-by: Phillip Whelan <[email protected]>
Document the new trace command line options introduced by fluent/fluent-bit#6726. Signed-off-by: Phillip Whelan <[email protected]> Signed-off-by: Tom <[email protected]>
Add new command line options to enable tracing from the start:
The format for the
--traceoption is the following:input=$INPUT_NAME output=$OUTPUT_PLUGIN output.$PROPERTY=$VALUESeveral properties can be defined for the output plugin. Support for spaces in property values is not supported yet...
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.