Skip to content

Conversation

@jbasko
Copy link
Contributor

@jbasko jbasko commented Jul 8, 2014

There is no JSONDecodeError class in built-in json (at least for me on Python 2.7.5). It is only present in simplejson, but in simplejson it's a subclass of ValueError so removing it from the tuple of exception classes doesn't change the behaviour.

…n Python 2.7.5). It is only present in simplejson, but in simplejson it's a subclass of ValueError so removing it from the tuple of exception classes doesn't change behaviour
EvaSDK added a commit to EvaSDK/fluent-logger-python that referenced this pull request Aug 1, 2014
This was meant to handle simplejson's exception class but it makes no
sense if it's inheriting from ValueError and would raise an exception
if simplejson is not installed which is not acceptable. See fluent#16.
EvaSDK added a commit to EvaSDK/fluent-logger-python that referenced this pull request Aug 1, 2014
This was meant to handle simplejson's exception class but it makes no
sense if it's inheriting from ValueError and would raise an exception
if simplejson is not installed which is not acceptable. See fluent#16.
EvaSDK added a commit to EvaSDK/fluent-logger-python that referenced this pull request Aug 1, 2014
This was meant to handle simplejson's exception class but it makes no
sense if it's inheriting from ValueError and would raise an exception
if simplejson is not installed which is not acceptable. See fluent#16.
kzk added a commit that referenced this pull request Jan 30, 2015
AttributeError: 'module' object has no attribute 'JSONDecodeError'
@kzk kzk merged commit 7d652d2 into fluent:master Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants