Skip to content

bugfix: false positive on expressions containing Count #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 7, 2024
Merged

bugfix: false positive on expressions containing Count #384

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f919693
bugfix: false positive on expressions containing Count
Meir017 Oct 7, 2024
52d3795
bugfix: false positive on expressions containing Count
Meir017 Oct 7, 2024
8b07915
bugfix: false positive on expressions containing Count
Meir017 Oct 7, 2024
5049148
bugfix: false positive on expressions containing Count
Meir017 Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bugfix: false positive on expressions containing Count
  • Loading branch information
@Meir017
Meir017 committed Oct 7, 2024
commit 8b07915a3e2e34bd4ed6605f3678a2951f9bba08
2 changes: 1 addition & 1 deletion src/FluentAssertions.Analyzers.Tests/Tips/CollectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ public class CollectionTests
[AssertionDiagnostic(@"var array = new string[1, 1]; array.Length.Should().Be(0{0});")]
[AssertionDiagnostic(@"var array = new string[2, 2]; array.Length.Should().Be(0{0});")]
[AssertionDiagnostic(@"var array = new string[3, 3, 3]; array.Length.Should().Be(0{0});")]
[AssertionDiagnostic(@"int[] array1 = [1, 2, 3]; int[] array2 = [4, 5, 6]; var both = array1.Concat(array2).ToArray(); (array1.Length + array2.Length).Should().Be(both.Length{0});")]
[AssertionDiagnostic(@"int[] array1 = [1, 2, 3]; int[] array2 = [4, 5, 6]; int[] both = [..array1, ..array2]; (array1.Length + array2.Length).Should().Be(both.Length{0});")]
[Implemented(Reason = "https://github.com/fluentassertions/fluentassertions.analyzers/issues/309")]
public void CollectionShouldHaveCount_LengthShouldBe_TestNoAnalyzer(string assertion) => DiagnosticVerifier.VerifyCSharpDiagnosticUsingAllAnalyzers(new StringBuilder()
.AppendLine("using System;")
Expand Down
Loading