Skip to content

Add conditional net48 targeting to FluentMigrator.Analyzers.Tests #2184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jzabroski merged 5 commits into from
Nov 20, 2025
+29 −8
Merged

Add conditional net48 targeting to FluentMigrator.Analyzers.Tests #2184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91fe664
Initial plan
Copilot Nov 19, 2025
45b951f
Add conditional targeting for net48 on Windows to FluentMigrator.Anal…
Copilot Nov 19, 2025
38c2822
Add artifact cleaning step in pull request workflow
jzabroski Nov 19, 2025
63c1d85
Merge branch 'main' into copilot/target-net48-in-tests
jzabroski Nov 20, 2025
615872d
Add .NET Framework 4.8 Developer Pack installation for Windows CI builds
Copilot Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions .github/workflows/pull-requests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,21 @@ jobs:
with:
dotnet-version: '9.0.x'

- name: Restore
run: dotnet restore

- name: Build, Test
run: dotnet test --no-restore --framework ${{ matrix.dotnet-tfm }} --configuration ${{ env.buildConfiguration }} --verbosity quiet --logger trx --collect:"XPlat Code Coverage" --results-directory "TestResults-${{ matrix.dotnet-tfm }}"
- name: Setup .NET Framework 4.8 Developer Pack (Windows)
if: matrix.os == 'windows-latest'
shell: pwsh
run: |
# Install .NET Framework 4.8 Developer Pack for building net48 projects
$installerUrl = "https://download.visualstudio.microsoft.com/download/pr/014120d7-d689-4305-befd-3cb711108212/0fd66638cde16859462a6243a4629a50/ndp48-devpack-enu.exe"
$installerPath = "$env:TEMP\ndp48-devpack-enu.exe"
Write-Host "Downloading .NET Framework 4.8 Developer Pack..."
Invoke-WebRequest -Uri $installerUrl -OutFile $installerPath
Write-Host "Installing .NET Framework 4.8 Developer Pack..."
Start-Process -FilePath $installerPath -ArgumentList "/quiet", "/norestart" -Wait
Write-Host ".NET Framework 4.8 Developer Pack installed."

- name: Restore, Build, Test
run: dotnet test --framework ${{ matrix.dotnet-tfm }} --configuration ${{ env.buildConfiguration }} --verbosity quiet --logger trx --collect:"XPlat Code Coverage" --results-directory "TestResults-${{ matrix.dotnet-tfm }}"
env:
# Enable containers for integration tests only on Linux
FM_TestConnectionStrings__MySql__ContainerEnabled: ${{ matrix.os == 'ubuntu-latest' }}
Expand Down
17 changes: 14 additions & 3 deletions test/FluentMigrator.Analyzers.Tests/FluentMigrator.Analyzers.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@
<Project Sdk="Microsoft.NET.Sdk">

<Choose>
<When Condition="$([MSBuild]::IsOSPlatform('Linux'))">
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
</PropertyGroup>
</When>
<Otherwise>
<!-- Condition="!$([MSBuild]::IsOSPlatform('Linux'))"; Assume Windows OS; we still test .NET Framework 4.8 for backwards compatibility reasons -->
<PropertyGroup>
<TargetFramework>net48</TargetFramework>
</PropertyGroup>
</Otherwise>
</Choose>
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>

<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
<GenerateBindingRedirectsOutputType>true</GenerateBindingRedirectsOutputType>

Expand All @@ -19,6 +29,7 @@
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.CodeFix.Testing" Version="$(MsCodeAnalysisAnalyzerTestingVersion)" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
<PackageReference Include="NUnit" Version="3.12.0" />
<PackageReference Include="NUnit3TestAdapter" Version="5.2.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading