Skip to content

Exit application method can be replaced by 'ui_app_exit' #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swift-kim merged 2 commits into from
Nov 28, 2020
Merged

Exit application method can be replaced by 'ui_app_exit' #3

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1659bd
Exit application method can be replaced by 'ui_app_exit'
xiaowei-guan Nov 27, 2020
995c110
Code format for platform_channel.cc
xiaowei-guan Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions shell/platform/tizen/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ source_set("flutter_tizen") {

include_dirs = [
"//third_party/tizen_tools/sysroot/$target_cpu/usr/include",
"//third_party/tizen_tools/sysroot/$target_cpu/usr/include/appfw",
"//third_party/tizen_tools/sysroot/$target_cpu/usr/include/base",
"//third_party/tizen_tools/sysroot/$target_cpu/usr/include/dlog",
"//third_party/tizen_tools/sysroot/$target_cpu/usr/include/ecore-1",
Expand All @@ -89,6 +90,7 @@ source_set("flutter_tizen") {

libs = [
"base-utils-i18n",
"capi-appfw-application",
"capi-system-info",
"capi-system-system-settings",
"dlog",
Expand Down
3 changes: 2 additions & 1 deletion shell/platform/tizen/channels/platform_channel.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include <app.h>
Copy link
Member

@swift-kim swift-kim Nov 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this line. Otherwise looks good.

#include "platform_channel.h"

#include <app.h>

#include ...

Copy link
Author

@xiaowei-guan xiaowei-guan Nov 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

#include "platform_channel.h"

#include "flutter/shell/platform/common/cpp/json_method_codec.h"
Expand All @@ -28,7 +29,7 @@ void PlatformChannel::HandleMethodCall(
const auto method = call.method_name();

if (method == "SystemNavigator.pop") {
exit(EXIT_SUCCESS);
ui_app_exit();
result->Success();
} else if (method == "SystemSound.play") {
result->NotImplemented();
Expand Down