Skip to content

Sync with analysis_options.yaml in flutter/packages #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSUYA merged 2 commits into from
Mar 8, 2024
Merged

Sync with analysis_options.yaml in flutter/packages #675

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2150d03
Sync with analysis_options.yaml in flutter/packages
JSUYA Mar 6, 2024
b59cb44
Apply review comment
JSUYA Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply review comment
  • Loading branch information
@JSUYA
JSUYA committed Mar 7, 2024
commit b59cb446903aa2e3350b2cfd99adcfcc8edac99b
8 changes: 2 additions & 6 deletions analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
# Specify analysis options.
#
# This file is a copy of analysis_options.yaml from flutter repo
# as of 2023-12-18, but with some modifications marked with
# "DIFFERENT FROM FLUTTER/FLUTTER" below. The file is expected to
# be kept in sync with the master file from the flutter repo.
# This file is a copy of analysis_options.yaml from flutter/packages repo
# as of 2024-03-07.

analyzer:
language:
Expand Down
6 changes: 3 additions & 3 deletions packages/messageport/example/integration_test/messageport_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ void main() {

testWidgets('Create remote port', (WidgetTester tester) async {
final LocalPort localPort = await LocalPort.create(kTestPort);
localPort.register((dynamic message, [RemotePort? remotePort]) => () {});
localPort.register((dynamic message, [RemotePort? remotePort]) {});

final RemotePort remotePort =
await RemotePort.connect(kTestAppId, kTestPort);
Expand All @@ -40,7 +40,7 @@ void main() {
(WidgetTester tester) async {
final LocalPort localPort =
await LocalPort.create(kTestPort, trusted: false);
localPort.register((dynamic message, [RemotePort? remotePort]) => () {});
localPort.register((dynamic message, [RemotePort? remotePort]) {});

await expectLater(
() => RemotePort.connect(kTestAppId, kTestPort),
Expand All @@ -52,7 +52,7 @@ void main() {

testWidgets('Check for remote', (WidgetTester tester) async {
final LocalPort localPort = await LocalPort.create(kTestPort);
localPort.register((dynamic message, [RemotePort? remotePort]) => () {});
localPort.register((dynamic message, [RemotePort? remotePort]) {});

final RemotePort remotePort =
await RemotePort.connect(kTestAppId, kTestPort);
Expand Down