Skip to content

Add the mimetype for smcbin file extension #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 2 commits into from
May 18, 2023
Merged

Add the mimetype for smcbin file extension #2776

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
837c2ad
Add the mimetype for smcbin file extension for AssetManifest.smcbin
May 18, 2023
694c6e1
Removed unused import.
May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add the mimetype for smcbin file extension for AssetManifest.smcbin
  • Loading branch information
Ricardo Amador committed May 18, 2023
commit 837c2adf3b7aecba1a0dbbec8acfbe5a12864517
1 change: 1 addition & 0 deletions app_dart/lib/src/request_handling/static_file_handler.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ class StaticFileHandler extends RequestHandler<Body> {
final Map<String, String> mimeTypeMap = <String, String>{
'.map': 'application/json',
'': 'text/plain',
'.smcbin': 'application/octet-stream',
};

final String resultPath = filePath == '/' ? '/index.html' : filePath;
Expand Down
12 changes: 12 additions & 0 deletions app_dart/test/request_handling/static_file_handler_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import 'package:cocoon_service/src/request_handling/exceptions.dart';
import 'package:file/file.dart';
import 'package:file/memory.dart';
import 'package:test/test.dart';
import 'package:mime/mime.dart';

import '../src/datastore/fake_config.dart';
import '../src/request_handling/request_handler_tester.dart';
Expand All @@ -23,12 +24,14 @@ void main() {
const String indexFileName = 'index.html';
const String indexFileContent = 'some html';
const String dartMapFileName = 'main.dart.js.map';
const String assetManifestSmcbin = 'AssetManifest.smcbin';

setUp(() {
tester = RequestHandlerTester();
fs = MemoryFileSystem();
fs.file('build/web/$indexFileName').createSync(recursive: true);
fs.file('build/web/$indexFileName').writeAsStringSync(indexFileContent);
fs.file('build/web/$assetManifestSmcbin').writeAsStringSync(assetManifestSmcbin);
fs.file('build/web/$dartMapFileName').writeAsStringSync('[{}]');
});

Expand Down Expand Up @@ -60,6 +63,15 @@ void main() {
expect(response, '[{}]');
});

test('smcbin file extension is handled correctly', () async {
final StaticFileHandler staticFileHandler = StaticFileHandler('/$assetManifestSmcbin', config: config, fs: fs);

final Body body = await tester.get(staticFileHandler);
expect(body, isNotNull);
final String response = await decodeHandlerBody(body);
expect(response, assetManifestSmcbin);
});

test('No extension files default to plain text', () async {
fs.file('build/web/NOTICE').writeAsStringSync('abc');
final StaticFileHandler staticFileHandler = StaticFileHandler('/NOTICE', config: config, fs: fs);
Expand Down