Skip to content

[dashboard] Fix Log-In button not showing up. #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Jan 25, 2024
Merged

[dashboard] Fix Log-In button not showing up. #3443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions dashboard/lib/widgets/sign_in_button/sign_in_button_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,14 @@
// found in the LICENSE file.

import 'package:flutter/material.dart';

import 'package:google_sign_in_platform_interface/google_sign_in_platform_interface.dart';
import 'package:google_sign_in_web/google_sign_in_web.dart';
import 'package:google_sign_in_web/web_only.dart' as gsi_web;

/// Widget that users can click to initiate the Sign In process.
class SignInButton extends StatelessWidget {
const SignInButton({super.key});

@override
Widget build(BuildContext context) {
return (GoogleSignInPlatform.instance as GoogleSignInPlugin).renderButton();
return gsi_web.renderButton();
}
}
3 changes: 1 addition & 2 deletions dashboard/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ dependencies:
fixnum: 1.1.0 # Rolled by dependabot
flutter_app_icons: 0.0.9 # Rolled by dependabot
google_sign_in: 6.2.1 # Rolled by dependabot
google_sign_in_platform_interface: any # Match google_sign_in
google_sign_in_web: 0.12.3 # Rolled by dependabot
google_sign_in_web: 0.12.3+2 # Rolled by dependabot
Copy link
Contributor

@christopherfujino christopherfujino Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible dependabot reverts this?

Copy link
Contributor

@godofredoc godofredoc Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give it a try with a dependabot manual run to see if it will try to revert the change

Copy link
Member Author

@ditman ditman Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to see if we want to move the _web package to something > 1.0.0 so this isn't an issue anymore.

However, if we don't update it to 1.0.0, and then don't do any backwards-incompatible changes, it's likely that this can stay as 0.12.Y+Z for a while!

http: 1.2.0 # Rolled by dependabot
protobuf: 3.1.0 # Rolled by dependabot
provider: 6.1.1 # Rolled by dependabot
Expand Down