Skip to content

Conversation

@stuartmorgan-g
Copy link
Contributor

By repo convention, plugins using the shared darwin source structure put unit tests in darwin/Tests/

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

By repo convention, plugins using the shared darwin source structure put unit tests in darwin/Tests/
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App. label Feb 12, 2024
@auto-submit auto-submit bot merged commit f163e34 into main Feb 12, 2024
@guidezpl guidezpl deleted the plugin-shared-darwin-test-pattern branch April 18, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants