Skip to content

Break glass v2 #4171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 7 commits into from
Jan 23, 2025
Merged

Break glass v2 #4171

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f4bc855
merge guard stays open until tests pass
yjbanov Jan 21, 2025
7a8342b
emergency label breaks glass
yjbanov Jan 22, 2025
ed1f963
fix test
yjbanov Jan 22, 2025
3025630
remove unnecessary await
yjbanov Jan 22, 2025
1b8f0e3
dartfmt
yjbanov Jan 22, 2025
80bfe63
emergency label closes guard
yjbanov Jan 22, 2025
e584c31
address comments
yjbanov Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unnecessary await
  • Loading branch information
@yjbanov
yjbanov committed Jan 22, 2025
commit 3025630c541a940d0260d8898ba85eca117efb43
10 changes: 5 additions & 5 deletions auto_submit/test/service/pull_request_validation_service_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,29 +187,29 @@ void main() {
test('Should process message when autosubmit label exists and pr is open', () async {
final PullRequest pullRequest = generatePullRequest(prNumber: 0, repoName: slug.name);
githubService.pullRequestData = pullRequest;
expect(await validationService.shouldProcess(pullRequest), true);
expect(validationService.shouldProcess(pullRequest), true);
});

test('Skip processing message when autosubmit label does not exist anymore', () async {
final PullRequest pullRequest = generatePullRequest(prNumber: 0, repoName: slug.name);
pullRequest.labels = <IssueLabel>[];
githubService.pullRequestData = pullRequest;
expect(await validationService.shouldProcess(pullRequest), false);
expect(validationService.shouldProcess(pullRequest), false);
});

test('Skip processing message when the pull request is closed', () async {
final PullRequest pullRequest = generatePullRequest(prNumber: 0, repoName: slug.name);
pullRequest.state = 'closed';
githubService.pullRequestData = pullRequest;
expect(await validationService.shouldProcess(pullRequest), false);
expect(validationService.shouldProcess(pullRequest), false);
});

test('Should not process message when revert label exists and pr is open', () async {
final PullRequest pullRequest = generatePullRequest(prNumber: 0, repoName: slug.name);
final IssueLabel issueLabel = IssueLabel(name: 'revert');
pullRequest.labels = <IssueLabel>[issueLabel];
githubService.pullRequestData = pullRequest;
expect(await validationService.shouldProcess(pullRequest), false);
expect(validationService.shouldProcess(pullRequest), false);
});

test('Skip processing message when revert label exists and pr is closed', () async {
Expand All @@ -218,7 +218,7 @@ void main() {
final IssueLabel issueLabel = IssueLabel(name: 'revert');
pullRequest.labels = <IssueLabel>[issueLabel];
githubService.pullRequestData = pullRequest;
expect(await validationService.shouldProcess(pullRequest), false);
expect(validationService.shouldProcess(pullRequest), false);
});
});

Expand Down