Google Sign In Service #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 29, 2019 10:22
wasn't really being used since Google Sign In works locally
CaseyHillers
changed the title
Contributor
IIRC this is the case if you don't specify what size image you want. |
| GoogleSignInService({GoogleSignIn googleSignIn}) | ||
| : _googleSignIn = googleSignIn ?? | ||
| setupGoogleSignIn( | ||
| scopes: <String>[ |
Contributor
There was a problem hiding this comment.
Maybe hoist these into private consts
Contributor
Author
So this is a Googler only |
Contributor
|
Ahh weird, probably fine though :) |
Member
|
So close! flutter/plugins#2244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Google Sign In service to
FlutterBuildState. This gives easy access to authentication from the build dashboard.Since Flutter's google_sign_in does not support web, this currently uses an open sourced fork called google_sign_in_all.
This fixes flutter/flutter#43108 bringing us one pull request closer to feature parity with v1.
Preview
Open Issues
google_sign_in_all, but because of the low priority I have not investigated furtherFuture Work
accessTokentoCocoonServicefor authenticated requestsgoogle_sign_in_allplugin togoogle_sign_inwhen web support is addedgoogle_sign_inGoogleUserCircleAvatarwidgetGoogleSignInServiceto a more global scope when new pages are added