Reland migration to use new flutter bootstrapping methods #7865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
requested review from
bkonyi,
elliette and
eyebrowsoffire
and removed request for
a team
elliette
reviewed
May 30, 2024
| } | ||
|
|
||
| // Bootstrap app for 1P environments: | ||
| function bootstrapAppFor1P() { |
Member
There was a problem hiding this comment.
Do we need this with cl/638797386?
Member
Author
There was a problem hiding this comment.
I would opt to leave it so that things can work without needing to change anything once b/343786318 is resolved.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of #7599, which was reverted in #7688 because the new bootstrapping syntax is not supported in google3. This is still true, but I have prepared cl/638797386 to use the existing bootstrapping in google3 until the new syntax is supported.
Work toward #7856.