Skip to content

Show Dart file locations in the stacktraces for errors #8385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elliette merged 7 commits into from
Oct 2, 2024
Merged

Show Dart file locations in the stacktraces for errors #8385

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9243d0b
Try to map to Dart stack traces
elliette Oct 1, 2024
54b0add
Stack trace mapping works for dart2js and dart2wasm
elliette Oct 1, 2024
ded2c35
Resolve merge conflicts and update flutter candidate
elliette Oct 2, 2024
4d967d1
Update release notes
elliette Oct 2, 2024
5a48068
Respond to PR comments
elliette Oct 2, 2024
7727d28
typo
elliette Oct 2, 2024
8f31a28
Another typo
elliette Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Respond to PR comments
  • Loading branch information
@elliette
elliette committed Oct 2, 2024
commit 5a48068b3959db789e78545aa93b022d7e0cd32b
10 changes: 4 additions & 6 deletions packages/devtools_app/lib/src/framework/app_error_handling.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,18 +112,16 @@ SingleMapping? _cachedJsSourceMapping;
SingleMapping? _cachedWasmSourceMapping;

Future<SingleMapping?> _fetchSourceMapping() async {
final cachedSourceMapping = preferences.wasmEnabled.value
? _cachedWasmSourceMapping
: _cachedJsSourceMapping;
final cachedSourceMapping =
kIsWasm ? _cachedWasmSourceMapping : _cachedJsSourceMapping;

return cachedSourceMapping ?? (await _initializeSourceMapping());
}

Future<SingleMapping?> _initializeSourceMapping() async {
try {
final wasmEnabled = preferences.wasmEnabled.value;
final sourceMapUri = Uri.parse(
'main.dart.${wasmEnabled ? 'wasm' : 'js'}.map',
'main.dart.${kIsWasm ? 'wasm' : 'js'}.map',
);
final sourceMapFile = await get(sourceMapUri);

Expand All @@ -133,7 +131,7 @@ Future<SingleMapping?> _initializeSourceMapping() async {
);
} catch (_) {
// Ignore any errors loading the source map.
return Future.value();
return null;
}
}

Expand Down