Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2948eda
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 223d61d
Choose a head ref
  • 12 commits
  • 29 files changed
  • 6 contributors

Commits on Sep 19, 2023

  1. Rename layoutGoals to kLayoutGoals to enforce lints on headers. (#… 

    …46054)

This is required to eventually land flutter/flutter#134969 (lint header files).
    @matanlurey
    matanlurey authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7ef3d8c View commit details
    Browse the repository at this point in the history

  2. Deprecate fml::LOG_X in favor of kLogX. (#46052) 

    This is required to eventually land flutter/flutter#134969 (lint header files).

No changes in behavior in this PR. Future steps:

 - Change existing `LOG_X` references to `kLogX`
 - Delete `LOG_X`
    @matanlurey
    matanlurey authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    090ed08 View commit details
    Browse the repository at this point in the history

  3. Roll Dart SDK from e7cd697bd0e9 to b8f006d88c07 (1 revision) (#46055) 

    https://dart.googlesource.com/sdk.git/+log/e7cd697bd0e9..b8f006d88c07

2023-09-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-180.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    efadf62 View commit details
    Browse the repository at this point in the history

  4. Roll Skia from d756a2f5665d to 559a964f9f1b (9 revisions) (#46059) 

    https://skia.googlesource.com/skia.git/+log/d756a2f5665d..559a964f9f1b

2023-09-19 brianosman@google.com Fix encoder funtion for 101010_xr
2023-09-19 johnstiles@google.com Pass the GraphiteTestContext to the most-complex DEF_TESTs.
2023-09-19 johnstiles@google.com Return a ContextInfo from Graphite's ContextFactory.
2023-09-19 kjlubick@google.com Add grep (pgrep) to Docker container used to build Skia-release
2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 640b7331b244 to e1a78e7e85a9 (2 revisions)
2023-09-19 bungeman@google.com [skshaper] Stage "Split off SkUnicode specific code"
2023-09-19 jvanverth@google.com [graphite] Track whether ordered Recordings are required.
2023-09-19 jmbetancourt@google.com expose textProperty slot support to CanvasKit
2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 91ef1f3cfd30 to 7cb117e0b06c (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    fdb33e4 View commit details
    Browse the repository at this point in the history

  5. [ios]Adjust golden test threshold for TwoPlatformViewsWithOtherBackDr… 

    …opFilterTests based on current macOS version (#45891)

TwoPlatformViewsWithOtherBackDropFilterTests is failing on macOS 13 with the same simulator version used in macOS 12. The image diff looks identical and slightly above the threshold. This PR adjusts the threshold for this test temporarily so our CI can run on both macOS 13 and 12. This change can be reverted when we move all our CI to macOS 13

Fixes flutter/flutter#134740

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    Chris Yang authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    9807293 View commit details
    Browse the repository at this point in the history

  6. Add TODO(name) to comply with Clang Tidy. (#46057) 

    Partial work towards flutter/flutter#134969.
    @matanlurey
    matanlurey authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    10c4803 View commit details
    Browse the repository at this point in the history

  7. FlutterMouse.* -> kFlutterMouse.*, so we can lint header files. (#… 

    …46056)

Partial work towards flutter/flutter#134969.

---------

Co-authored-by: Chris Bracken <chris@bracken.jp>
    @matanlurey @cbracken
    matanlurey and cbracken authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    f1fd0a3 View commit details
    Browse the repository at this point in the history

  8. Implement JSObject instead of extending (#46070) 

    JSObject will have a factory constructor to create an object literal, so
you can't extend it as it will no longer have a generative constructor
(@staticInterop types can't have generative constructors).
    @srujzs
    srujzs authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    838d0a0 View commit details
    Browse the repository at this point in the history

  9. Roll Skia from 559a964f9f1b to fe3568162721 (5 revisions) (#46069) 

    https://skia.googlesource.com/skia.git/+log/559a964f9f1b..fe3568162721

2023-09-19 jvanverth@google.com [graphite] Switch signed unique ID iterators to unsigned.
2023-09-19 jamesgk@google.com Add "unsafe apis" toggle for Adapter in Graphite DawnTestContext
2023-09-19 fmalita@chromium.org [skottie] Make text shaper header public
2023-09-19 jvanverth@google.com [graphite] Add option to disable cached glyph uploads.
2023-09-19 jamesgk@google.com [graphite] Use Dawn's dual-src blend coeffs when possible

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    a96f26f View commit details
    Browse the repository at this point in the history

  10. Enable strict-inference (#46062) 

    Avoids that dynamic accidentally sneaks in, see https://dart.dev/tools/analysis#enabling-additional-type-checks
    @goderbauer
    goderbauer authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    a7af55c View commit details
    Browse the repository at this point in the history

  11. Reapply "[ios] use python script to generate extension safe framework… 

    …s and code sign them" (#46004)

This reverts commit 21372b1.
    Chris Yang committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    15f077e View commit details
    Browse the repository at this point in the history

  12. only zip extension_safe/xcframework

    Chris Yang committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    223d61d View commit details
    Browse the repository at this point in the history
Loading