This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Interpret negative radii as 0 in recording_canvas.dart #12431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows drawing DRRects that may have some negative values on its corners (caused by deflating a RRect with some non-round corners, for example) See added unit test for an example of the above. Fixes flutter/flutter#40728
yjbanov
approved these changes
Sep 24, 2019
ferhatb
approved these changes
Sep 24, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 25, 2019
[email protected]:flutter/engine.git/compare/63949eb0fd98...48ad8a0 git log 63949eb..48ad8a0 --no-merges --oneline 2019-09-25 [email protected] add dart:html, dart:js, and dart:js_util to the copy of the Dart SDK used for analysis (flutter/engine#12435) 2019-09-25 [email protected] Roll fuchsia/sdk/core/linux-amd64 from dmzjj... to worpw... (flutter/engine#12441) 2019-09-25 [email protected] Roll src/third_party/skia 2da97da4b024..6abaff3041a3 (1 commits) (flutter/engine#12440) 2019-09-25 [email protected] Roll fuchsia/sdk/core/mac-amd64 from rEYHD... to avi05... (flutter/engine#12439) 2019-09-25 [email protected] Roll src/third_party/skia 2137f90b9d98..2da97da4b024 (3 commits) (flutter/engine#12438) 2019-09-25 [email protected] Roll src/third_party/skia f050422f3285..2137f90b9d98 (4 commits) (flutter/engine#12437) 2019-09-25 [email protected] Interpret negative radii as 0 in recording_canvas drawDRRect (flutter/engine#12431) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
[email protected]:flutter/engine.git/compare/63949eb0fd98...48ad8a0 git log 63949eb..48ad8a0 --no-merges --oneline 2019-09-25 [email protected] add dart:html, dart:js, and dart:js_util to the copy of the Dart SDK used for analysis (flutter/engine#12435) 2019-09-25 [email protected] Roll fuchsia/sdk/core/linux-amd64 from dmzjj... to worpw... (flutter/engine#12441) 2019-09-25 [email protected] Roll src/third_party/skia 2da97da4b024..6abaff3041a3 (1 commits) (flutter/engine#12440) 2019-09-25 [email protected] Roll fuchsia/sdk/core/mac-amd64 from rEYHD... to avi05... (flutter/engine#12439) 2019-09-25 [email protected] Roll src/third_party/skia 2137f90b9d98..2da97da4b024 (3 commits) (flutter/engine#12438) 2019-09-25 [email protected] Roll src/third_party/skia f050422f3285..2137f90b9d98 (4 commits) (flutter/engine#12437) 2019-09-25 [email protected] Interpret negative radii as 0 in recording_canvas drawDRRect (flutter/engine#12431) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows drawing DRRects that may have some negative values on
their corners (caused by deflating a RRect with some non-round corners,
for example)
See added unit test for an example of the above.
Fixes flutter/flutter#40728