Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reformat BUILD.gn files to comply with the format checker presubmit script #13401

Merged
jason-simmons merged 1 commit into from
Oct 29, 2019
Merged

Reformat BUILD.gn files to comply with the format checker presubmit script #13401

jason-simmons merged 1 commit into from
Oct 29, 2019

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Oct 28, 2019

No description provided.

iskakaushik
iskakaushik approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde
Copy link
Contributor

chinmaygarde commented Oct 28, 2019

How did this pass presubmits before?

@jason-simmons
Copy link
Member Author

jason-simmons commented Oct 29, 2019

The ci/check_gn_format.py script was intending to do a dry run of gn format that would return a result indicating whether the build files were correctly formatted. But instead it's doing a real run of gn format that modifies the files and doesn't return the result code.

I'll fix the check_gn_format.py script.

@jason-simmons jason-simmons merged commit 7069025 into flutter:master Oct 29, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2019
@engine-flutter-autoroll
7069025 Reformat BUILD.gn files to comply with the format checker pre…
0259d59 
…submit script (flutter/engine#13401)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2019
@engine-flutter-autoroll
7069025 Reformat BUILD.gn files to comply with the format checker pre…
d569761 
…submit script (flutter/engine#13401)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2019
Merged
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Oct 30, 2019
@engine-flutter-autoroll
Roll engine 419f5d5..46c757b (6 commits) (#43769)
dc44c56 
[email protected]:flutter/engine.git/compare/419f5d594afc...46c757b

git log 419f5d5..46c757b --no-merges --oneline
2019-10-29 [email protected] [dart_runner] Common libs need to exist for aot runner (flutter/engine#13419)
2019-10-29 [email protected] Fix the dry run mode of the GN format checker script (flutter/engine#13406)
2019-10-29 [email protected] Reformat BUILD.gn files to comply with the format checker presubmit script (flutter/engine#13401)
2019-10-29 [email protected] Use DartExecutor.getBinaryMessenger in FlutterNativeView instead of deprecated send methods (flutter/engine#13403)
2019-10-29 [email protected] Roll src/third_party/dart e1fce75301..0b96f9f9ae (28 commits)
2019-10-29 [email protected] Converted ActivityAware and ServiceAware Lifecycles to opaque objects (#43670) (flutter/engine#13402)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@engine-flutter-autoroll @Inconnu08
Roll engine 419f5d5..46c757b (6 commits) (flutter#43769)
f41851c 
[email protected]:flutter/engine.git/compare/419f5d594afc...46c757b

git log 419f5d5..46c757b --no-merges --oneline
2019-10-29 [email protected] [dart_runner] Common libs need to exist for aot runner (flutter/engine#13419)
2019-10-29 [email protected] Fix the dry run mode of the GN format checker script (flutter/engine#13406)
2019-10-29 [email protected] Reformat BUILD.gn files to comply with the format checker presubmit script (flutter/engine#13401)
2019-10-29 [email protected] Use DartExecutor.getBinaryMessenger in FlutterNativeView instead of deprecated send methods (flutter/engine#13403)
2019-10-29 [email protected] Roll src/third_party/dart e1fce75301..0b96f9f9ae (28 commits)
2019-10-29 [email protected] Converted ActivityAware and ServiceAware Lifecycles to opaque objects (flutter#43670) (flutter/engine#13402)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

1 more reviewer

@iskakaushik iskakaushik iskakaushik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jason-simmons @chinmaygarde @iskakaushik @googlebot