-
Notifications
You must be signed in to change notification settings - Fork 6k
[runner] Corrects logging of close() status #16698
Conversation
|
What do I need to do to have this merged? Thanks! |
|
Added the "waiting for the tree to go green" label. This will merge the commit when the tree is stable. |
|
This pull request is not suitable for automatic merging in its current state.
|
|
Given that the change is trivial (inverting an |
e65d60f to
c96618e
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
close() returns a nonzero in case of an error. Old code had it log only when *no* error happens on close, which is exactly the opposite of what we want.
|
@jason-simmons Anything else I need to do to get this merged? Thanks! |
* 97083b4 Roll src/third_party/dart 232308723704..cd8f712bcb01 (18 commits) (flutter/engine#17328) * 23dff31 [runner] Corrects logging of close() status (flutter/engine#16698)
close() returns a nonzero in case of an error. Old code had it log
only when no error happens on close, which is exactly the opposite
of what we want.