Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@filmil
Copy link
Contributor

@filmil filmil commented Feb 20, 2020

close() returns a nonzero in case of an error. Old code had it log
only when no error happens on close, which is exactly the opposite
of what we want.

@filmil
Copy link
Contributor Author

filmil commented Feb 20, 2020

What do I need to do to have this merged? Thanks!

@jason-simmons jason-simmons added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 20, 2020
@jason-simmons
Copy link
Member

Added the "waiting for the tree to go green" label. This will merge the commit when the tree is stable.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Fuchsia has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux Web Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows Web Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite build_and_test_linux_unopt_debug has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 20, 2020
@filmil
Copy link
Contributor Author

filmil commented Feb 20, 2020

Given that the change is trivial (inverting an if condition), the presubmit check failures seem unrelated. Is there a way to force them to run again? Perhaps rebase and retry?

@filmil filmil force-pushed the fix-close branch 2 times, most recently from e65d60f to c96618e Compare March 13, 2020 18:27
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@filmil
Copy link
Contributor Author

filmil commented Mar 13, 2020

@googlebot I fixed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

close() returns a nonzero in case of an error.  Old code had it log
only when *no* error happens on close, which is exactly the opposite
of what we want.
@filmil
Copy link
Contributor Author

filmil commented Mar 25, 2020

@jason-simmons Anything else I need to do to get this merged? Thanks!

renyou pushed a commit to flutter/flutter that referenced this pull request Mar 26, 2020
* 97083b4 Roll src/third_party/dart 232308723704..cd8f712bcb01 (18 commits) (flutter/engine#17328)

* 23dff31 [runner] Corrects logging of close() status (flutter/engine#16698)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants