Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Mar 24, 2020

Preserve zones in Window callbacks.

Bonus:

  • Fix some typos and remove dead code in the mobile implementation.

Fixes flutter/flutter#51057

@yjbanov yjbanov requested review from ferhatb, mdebbar and nturgut March 24, 2020 18:08
@auto-assign auto-assign bot requested a review from gaaclarke March 24, 2020 18:08
@nturgut
Copy link
Contributor

nturgut commented Mar 24, 2020

please use this PR instead: #17299

Sorry for the inconvenience.

@yjbanov
Copy link
Contributor Author

yjbanov commented Mar 24, 2020

please use this PR instead: #17299

Sorry for the inconvenience.

I'll rebase once your PR lands. No worries.

Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

runZoned onError does not catch exceptions on web platform

5 participants