This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Android change to match the Google internal changes. #17331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehmetf
reviewed
Mar 25, 2020
| Log.e( | ||
| TAG, | ||
| "Could not read meta-data for FlutterFragmentActivity. Using the launch theme as normal theme."); | ||
| "Could not read meta-data for FlutterFragmentActivity. Using the launch theme as normal" |
Contributor
There was a problem hiding this comment.
You can revert this. Totally unnecessary; the internal tooling for some reason made this change. It should be reverted in google3 as well (which will happen automatically with the roll).
| eventDelegate.onPostResume(); | ||
| } | ||
|
|
||
| // @Override - added in API level 23 |
Contributor
There was a problem hiding this comment.
I believe we can also remove this comment because this is now using androidx support library so it should not matter when the API was added.
| "Could not read meta-data for FlutterFragmentActivity. Using the launch theme as normal" | ||
| + " theme."); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
There must be a similar change here as well for calling super. Check around line 490.
Contributor
Author
There was a problem hiding this comment.
Done. Sorry somehow I missed this.
mehmetf
approved these changes
Mar 26, 2020
mehmetf
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to match the Google internal changes, so the flutter/flutter can build correctly internally.