This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Do not drop toString for enums #17352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Ahh yeah enums. I've definitely written some of this code myself, but it was easy to forget about it (apparently) |
dnfield
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
Contributor
Author
|
LUCI is red on an out of order commit - top of tree is actually green. Fuchsia builder on this is a flake, and this change does not impact fuchsia. Landing to kick tree. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered when attempting to use this in google3. A number of method channels/platform channels call
toStringon an enum (e.g.Brightness.dark) to pass platform data back and forth.It would be better if these just used indices (encoding a single int instead of encoding a string), we can't really stop customers from doing it and it can cause unexpected failures in release mode.