Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Fix extra canvas generation due to context access #17710

Merged
ferhatb merged 3 commits into from
Apr 14, 2020
Merged

[web] Fix extra canvas generation due to context access #17710

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49f44f7
Fix extra canvas generation due to context access
ferhatb Apr 14, 2020
2a3653b
add comment
ferhatb Apr 14, 2020
dad38b4
address review comment
ferhatb Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/web_ui/lib/src/engine/bitmap_canvas.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,10 +489,11 @@ class BitmapCanvas extends EngineCanvas {
@override
void drawParagraph(EngineParagraph paragraph, ui.Offset offset) {
assert(paragraph._isLaidOut);
html.CanvasRenderingContext2D ctx = _canvasPool.context;
final ParagraphGeometricStyle style = paragraph._geometricStyle;

if (paragraph._drawOnCanvas && _childOverdraw == false) {
// !Do not move this assignment above this if clause since, accessing
// context will generate extra <canvas> tags.
final List<EngineLineMetrics> lines = paragraph._measurementResult.lines;

final SurfacePaintData backgroundPaint = paragraph._background?.paintData;
Expand All @@ -503,6 +504,7 @@ class BitmapCanvas extends EngineCanvas {
}

if (style != _cachedLastStyle) {
html.CanvasRenderingContext2D ctx = _canvasPool.context;
ctx.font = style.cssFontString;
_cachedLastStyle = style;
}
Expand Down