Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Enabled metal on ios simulator #17881

Merged
fluttergithubbot merged 15 commits into from
Oct 8, 2020
Merged

Enabled metal on ios simulator #17881

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a4fff2f
Enabled metal on ios simulator
Kavantix Apr 22, 2020
839185c
Added os version constant for metal availablitity
Kavantix Apr 27, 2020
5c92d7d
Updated outdated comment in the gn file
Kavantix Apr 27, 2020
ea495b7
Renamed macro to METAL_IOS_VERSION_BASELINE
Kavantix Apr 28, 2020
eed65a5
Merge branch 'master' into metal-on-simulator
Kavantix Oct 1, 2020
63d1a38
Update gpu_surface_metal.h
Kavantix Oct 1, 2020
13bd8e5
Update ios_surface_metal.h
Kavantix Oct 1, 2020
5b8e616
Merge remote-tracking branch 'upstream/master' into metal-on-simulator
dnfield Oct 1, 2020
5bce7ab
Merge remote-tracking branch 'upstream/master' into metal-on-simulator
dnfield Oct 7, 2020
40fb32b
Enable software rendering, make golden tests use it
dnfield Oct 7, 2020
db5db70
review
dnfield Oct 7, 2020
a2b792b
Apply suggestions from code review
dnfield Oct 7, 2020
eaf87d0
unnecessary ,
dnfield Oct 7, 2020
f323636
better comment
dnfield Oct 7, 2020
c0a9f73
more chinmay review
dnfield Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
unnecessary ,
  • Loading branch information
@dnfield
dnfield committed Oct 7, 2020
commit eaf87d02ccbc64eade83490604fcd4fa74825e87
2 changes: 1 addition & 1 deletion shell/platform/darwin/ios/rendering_api_selection.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ IOSRenderingAPI GetRenderingAPIForProcess(bool force_software) {
}
#elif !FLUTTER_RELEASE
Copy link
Member

@chinmaygarde chinmaygarde Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on the log. Why !FLUTTER_RELEASE though? This is still a warning log that will only show up when verbose logging is enabled. I'd just use #else.

Copy link
Contributor

@dnfield dnfield Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figure avoid the overhead if you're on release, since you should've seen it already in debug/profile if you're trying. I guess it's probably not a ton of overhead to do the bool check though.. I'll change it to else.

if (force_software) {
FML_LOG(WARNING) << "The --enable-software-rendering is only supported on Simulator targets, "
FML_LOG(WARNING) << "The --enable-software-rendering is only supported on Simulator targets "
"and will be ignored.";
}
#endif // TARGET_OS_SIMULATOR
Expand Down